From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:42835) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2eCA-0002zl-Us for guix-patches@gnu.org; Fri, 14 Feb 2020 11:52:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2eCA-0002ww-15 for guix-patches@gnu.org; Fri, 14 Feb 2020 11:52:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56869) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2eC9-0002wn-QZ for guix-patches@gnu.org; Fri, 14 Feb 2020 11:52:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j2eC9-0004lo-Pi for guix-patches@gnu.org; Fri, 14 Feb 2020 11:52:01 -0500 Subject: bug#39108: [PATCH] gnu: Add gst-editing-services. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: References: <20200112234026.12266-1-leo.prikler@student.tugraz.at> <874kwzvuq5.fsf@devup.no> <1dd8b61e8e1435a1e1cd214e30b70f500cf9def5.camel@student.tugraz.at> <02823ea592a1cec21c0de7cc7efc1256bc7add09.camel@student.tugraz.at> <878sl588jt.fsf@devup.no> <28a17d6a51b46ed190c544de7f357ec7cff44ae9.camel@student.tugraz.at> <87y2t56tcc.fsf@devup.no> Date: Fri, 14 Feb 2020 17:51:07 +0100 Message-ID: <87mu9l6rk4.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Prikler , 39108-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > Am Freitag, den 14.02.2020, 17:12 +0100 schrieb Marius Bakke: >> I'm getting a strange build failure with this patch: >>=20 >>=20 >> ... >> Dependency gstreamer-plugins-base-1.0 found: YES 1.16.2 >> Dependency gstreamer-plugins-bad-1.0 found: NO (tried pkgconfig and >> cmake) >>=20 >> tests/check/meson.build:41:2: ERROR: 'not-found' is not a pkgconfig >> dependency >>=20 >> A full log can be found at /tmp/guix-build-gst-editing-services- >> 1.16.2.drv-0/build/meson-logs/meson-log.txt >>=20 >> I suppose it needs 'gst-plugins-bad'? > Indeed, it does, though interestingly just for tests, which are > currently broken. I already had this back when I tried meson, but have > since forgot about it. There are no actual references to it, so I've > made it a native input. As far as using it is concerned, I think one > might be able to do without a certain set of plugins depending on the > codecs used. Either way, I'm not really sure whether it should > propagate the main plugin set. > > I also added the good plugins even if they are not mentioned, just to > be on the safe side.=20=20 OK. I changed the TODO to a FIXME and added a copyright line for you. Pushed in 64fc4f3705423c83c680a95d8dea81a39fce9a70, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl5Gz/sACgkQoqBt8qM6 VPrVpwf8DohluVagW3FbSMEZOjvMN60qbEqMyE8LPBguY3jy2ZqWYFiLEqd8sk+n NtiK7U6XRVjOvGotaJ6zFXgDpjG69EOZZQ1PGK+mAhKDTJ4WVw9cr37Ks4ZK3BWT BR2gzlL5mLqoWKjub1O2RdiE/VDasDrVu/pM1gifCxWy73Y8ccLJ3PShxZh/BvKV 32ARMXwuW7Zoy5U2CGQhc9tdfkBvWyp0HRmuB5O145rjl3lJWNkPTL+I3XMqXtQX hJnwjrLFGZkkn5I0CE9q83V+n3tahXRP/vi9leU2rZ7nqPy7YfCSlkDDwP+26NFC kOKzsUlYkc0t5qXbrcLfhOJD375AEg== =BP/R -----END PGP SIGNATURE----- --=-=-=--