From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: 01/03: ui: Only display link in capable terminals.
Date: Mon, 24 Feb 2020 21:38:41 +0100
Message-ID: <87mu97g1pq.fsf@gnu.org>
References: <20200224101817.20439.52918@vcs0.savannah.gnu.org>
 <20200224101818.9A1FC206ED@vcs0.savannah.gnu.org>
 <8736b0m21m.fsf@gnu.org> <878sksc677.fsf@ambrevar.xyz>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:47318)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@gnu.org>) id 1j6KV3-0007WG-42
 for guix-devel@gnu.org; Mon, 24 Feb 2020 15:38:46 -0500
In-Reply-To: <878sksc677.fsf@ambrevar.xyz> (Pierre Neidhardt's message of
 "Mon, 24 Feb 2020 17:15:24 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org

Hi,

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> So people see less information on terminals that support hyperlinks,
>> right?
>>
>> I think there should be as much information displayed whether or not the
>> terminal supports hyperlinks.  Otherwise it can be confusing.
>> (Especially since we can=E2=80=99t tell whether the terminal really supp=
orts
>> hyperlinks: we don=E2=80=99t know whether it displays clickable links.)
>>
>> Thoughts?
>
> The file/URL was not displayed in terminals that support hyperlinks.
> This was also true before this commit.
>
> The user has to guess that they are clickable.

The user can hover over it, but VTE, Eterm, etc. make hyperlinks visible
even when you don=E2=80=99t hover over them.

The hyperlink is an enhancement, not a piece of information that was
intended to be displayed upfront.

>>> --- a/guix/ui.scm
>>> +++ b/guix/ui.scm
>>> @@ -1637,7 +1637,7 @@ DURATION-RELATION with the current time."
>>>      (let* ((file   (generation-file-name profile number))
>>>             (link   (if (supports-hyperlinks?)
>>>                         (cut file-hyperlink file <>)
>>> -                       identity))
>>> +                       (cut format #f (G_ "~a~%file: ~a") <> file)))
>>>             (header (format #f (link (highlight (G_ "Generation ~a\t~a"=
)))
>>
>> I understand it=E2=80=99s a matter of taste, but I=E2=80=99m not a fan o=
f the extra
>> line here.
>
> You mean the "~%" in "~a~%file: ~a"?
> How would you like to display it?

I would not display it at all.  I think it=E2=80=99s a bit of clutter that=
=E2=80=99s
best avoided.

I guess I=E2=80=99m suggesting a revert of this patch.

WDYT?

Ludo=E2=80=99.