From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:45248) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7GOh-0001zD-CQ for guix-patches@gnu.org; Thu, 27 Feb 2020 05:28:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7GOg-0005if-9h for guix-patches@gnu.org; Thu, 27 Feb 2020 05:28:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52742) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7GOg-0005gS-4p for guix-patches@gnu.org; Thu, 27 Feb 2020 05:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j7GOf-00055c-Vk for guix-patches@gnu.org; Thu, 27 Feb 2020 05:28:02 -0500 Subject: [bug#39717] [PATCH 1/3] gnu: delft-icon-theme: Use the copy-build-system. Resent-Message-ID: From: Pierre Neidhardt References: <20200221163215.11008-1-leo.prikler@student.tugraz.at> Date: Thu, 27 Feb 2020 11:27:49 +0100 In-Reply-To: <20200221163215.11008-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Fri, 21 Feb 2020 17:32:13 +0100") Message-ID: <87mu9472ai.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Prikler Cc: 39717@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thanks for the patch! Comments below: > (arguments > - `(#:modules ((guix build utils)) > - #:builder > - (begin > - (use-modules (guix build utils)) > - (copy-recursively (assoc-ref %build-inputs "source") "icons") > - (substitute* "icons/Delft/index.theme" > - (("gnome") "Adwaita")) > - (delete-file "icons/README.md") > - (delete-file "icons/LICENSE") > - (delete-file "icons/logo.jpg") > - (copy-recursively "icons" (string-append %output "/share/icons"= ))))) > + `(#:install-plan > + '(,@(append-map (lambda (file) > + `((,file "share/icons/") > + (,(string-append file "-Dark") "share/icons/") > + (,(string-append file "-Darker") "share/icons= /") > + (,(string-append file "-Darkest") "share/icon= s/"))) > + '("Delft" "Delft-Amber" "Delft-Aqua" "Delft-Blue" > + "Delft-Gray" "Delft-Green" "Delft-Mint" "Delft-= Purple" > + "Delft-Red" "Delft-Teal"))))) Interesting use of install-plan, but wouldn't it be to copy everything and simply exclude the previous delete files? E.g. (untested): #:install-plan `(("." "./" #:exclude ("README.md" "LICENSE" "logo.jpg"))) =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl5XmaUACgkQm9z0l6S7 zH+FSQf/Q7UR/AEMIjz30snykn5p8ZrhjxwWMx411WeroAMbp1NcPB9mqHtwsyEW f3qDP6XLo36jPJwXAiTWgmohXRkU0Q1WgWYH+sjExcFPVrAfafeVTjw23gDF2JHD p8PhhI3b02i5YVqWDavImC4Mp67DVte7ZiB2BJS7WWd7WdlVXHHVgFrsKgx260BU Wpl2dHUS1zpeFhR8dpcZlk4AdU7CMXYjCE0cwoPWSn52oCJQy9c6lF9fzqGPcm0D kSELtlpwi19xhnFYMW3/nI2zWHBLg9Q+Ahsyj7LURjTeGKyPaeBiwODVZhvtcnKd CJyemX1oV7fyBODnDeXRVHErTs4y/g== =dtWV -----END PGP SIGNATURE----- --=-=-=--