From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36867) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7Lkh-0007Ni-7U for guix-patches@gnu.org; Thu, 27 Feb 2020 11:11:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7Lkc-0001TB-8S for guix-patches@gnu.org; Thu, 27 Feb 2020 11:11:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54179) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7Lkc-0001T4-3U for guix-patches@gnu.org; Thu, 27 Feb 2020 11:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j7Lkb-00007P-UN for guix-patches@gnu.org; Thu, 27 Feb 2020 11:11:01 -0500 Subject: [bug#39729] [PATCH 0/7] Testing the graphical installer Resent-Message-ID: References: <20200221231652.27632-1-ludo@gnu.org> From: Mathieu Othacehe In-reply-to: <20200221231652.27632-1-ludo@gnu.org> Date: Thu, 27 Feb 2020 17:10:42 +0100 Message-ID: <87mu946mf1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 39729@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Hey! > The second part implements the actual test. The new (gnu installer > tests) module provides tools to implement a dialogue with the installer, > and the new =E2=80=9Cgui-installed-os=E2=80=9D test uses it to perform a = bare-bones > style installation. There=E2=80=99s a commented out variant that does it= on > an encrypted root, but it currently fails presumably due to > . > > That=E2=80=99s it! > > Feedback welcome! This serie LGTM, this is really impressive :) About the umounting issue, you were right. Umounting failed for both %test-gui-installed-os and %test-gui-installed-os-encrypted. The issue was that guix-daemon was keeping open files inside the cow-store, preventing the umount. I discovered then a second issue, some udevd workers, started while the cow-store was active were also preventing the umounting. I published a few patches on top of yours on wip-installer-test to fix those issues. Thanks, Mathieu PS: I had a hard time debugging the marionette, couldn't find better to add some syslog, wait an hour to test & repeat. Do you have a better approach? Would it be possible to have a debug ssh in the marionette?