"make dist" broken by German cookbook translation

"make dist" broken by German cookbook translation

[Vagrant Cascadian]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

It looks like the commit adding the German translation for the cookbook
f98e83a17fa30587520e858231ec9c61f3624ecd broke "make dist".

in an environment built using:

  guix environment --pure guix --ad-hoc git imagemagick

running:

  ./bootstrap && ./configure --localstatedir=/var && make -j4 && make doc-pot-update && make -j4 dist

Results in:

make[1]: Leaving directory '/home/vagrant/src/guix-tarball'
for f in po/doc/guix-manual.de.po; do
\
  lang="`echo "$f" |
  /gnu/store/zsq3ficl0hmid7aw50qma1ixmbs0jzq9-profile/bin/sed
  -es'|.*/guix-cookb\
ook\.\(.*\)\.po$|\1|g'`";        \
  make "doc-po-update-cookbook-$lang";
  \
done
make[1]: Entering directory '/home/vagrant/src/guix-tarball'
make[1]: *** No rule to make target
'doc-po-update-cookbook-po/doc/guix-manual.de.po'.  Stop.
make[1]: Leaving directory '/home/vagrant/src/guix-tarball'
make: *** [Makefile:5735: doc-po-update] Error 2


I haven't tracked down how to fix it properly, but it looks like maybe
some rules from guix-manual maybe were copied from the cookbook without
sufficiently being adjusted?

Reverting the commit works around the issue and generates a tarball,
though with the obvious downside of the German translation missing.


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

Re: "make dist" broken by German cookbook translation

[pelzflorian (Florian Pelz)]

On Fri, Mar 06, 2020 at 11:19:27AM -0800, Vagrant Cascadian wrote:
> It looks like the commit adding the German translation for the cookbook
> f98e83a17fa30587520e858231ec9c61f3624ecd broke "make dist".
> 


Sorry!  I should have tested more.  Fixed in
895e6e8af657d28527f7cccf68eab7319f50fba5.

Regards,
Florian

Re: "make dist" broken by German cookbook translation

[Vagrant Cascadian]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

On 2020-03-06, pelzflorian (Florian Pelz) wrote:
> On Fri, Mar 06, 2020 at 11:19:27AM -0800, Vagrant Cascadian wrote:
>> It looks like the commit adding the German translation for the cookbook
>> f98e83a17fa30587520e858231ec9c61f3624ecd broke "make dist".
>
> Sorry!  I should have tested more.  Fixed in
> 895e6e8af657d28527f7cccf68eab7319f50fba5.

Thanks for the quick fix!

live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]