all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: maxim.cournoyer@gmail.com
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: Danny Milosavljevic <dannym@scratchpost.org>, 40264@debbugs.gnu.org
Subject: [bug#40264] Linphone: 11-add-mediastreamer-v2
Date: Sun, 05 Apr 2020 00:08:08 -0400	[thread overview]
Message-ID: <87mu7q3787.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <bd99706f2abe3a1b4217235ee954385e@disroot.org> (Raghav Gururajan's message of "Fri, 03 Apr 2020 14:30:09 +0000")

Hello Raghav,

"Raghav Gururajan" <raghavgururajan@disroot.org> writes:

> Hi Danny!
>
>>> + (list
>>>
>>> + ;; For fixing definitions.
>>
>> Yes, but why? What would happen if we didn't do it?
>
> Otherwise, we get `-Werror` flag related compilation errors.

Could you please clarify that in a comment above the patch?

>>> + (origin
>>> + (method url-fetch)
>>> + (uri
>>> + (string-append "https://gitlab.linphone.org/BC/public/mediastreamer2/commit"
>>> + "de3a24b795d7a78e78eab6b974e7ec5abf2259ac.diff"))
>>> + (file-name "mediastreamer-msfactory.patch")
>>
>> I'm not sure what the outcome of the latest discussion on carrying patches was.
>> Should we carry patches in Guix now or fetch them from external source?
>
> I think it's good as long as we use hash to verify. :-)

The problem is that metadata or format of auto-generated patches may
change on a whim.  In past discussions it was decided best to not use
them (that is, it's best to embed a copy of it in Guix sources) [0].

[0]  https://lists.gnu.org/archive/html/guix-devel/2018-11/msg00554.html

I'll post more comments in your original message.

Maxim

  reply	other threads:[~2020-04-05  4:09 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 23:10 [bug#40264] Linphone Raghav Gururajan
2020-03-27 23:13 ` [bug#40264] Linphone: 1-create-linphone-module Raghav Gururajan
2020-03-27 23:14 ` [bug#40264] Linphone: 2-update-linphone-module Raghav Gururajan
2020-03-27 23:15 ` [bug#40264] Linphone: 3-add-bcunit Raghav Gururajan
2020-04-01  2:46   ` Maxim Cournoyer
2020-03-27 23:21 ` [bug#40264] Linphone: 4-add-bctoolbox Raghav Gururajan
2020-03-28 18:40 ` [bug#40264] Linphone: 5-add-belr Raghav Gururajan
2020-03-28 19:40 ` [bug#40264] Linphone: 6-add-belcard Raghav Gururajan
2020-03-28 21:22 ` [bug#40264] Linphone: 7-add-bcmatroska2 Raghav Gururajan
2020-03-28 21:35 ` [bug#40264] Linphone: 8-add-bcg729 Raghav Gururajan
2020-03-28 22:14 ` [bug#40264] Linphone: 9-add-ortp Raghav Gururajan
2020-03-28 22:36 ` [bug#40264] Linphone: 10-add-bzrtp Raghav Gururajan
2020-03-29  8:58 ` [bug#40264] Linphone: 11-add-mediastreamer Raghav Gururajan
2020-03-30  2:45 ` [bug#40264] Linphone: 12-add-belle-sip Raghav Gururajan
2020-03-30 20:45   ` Danny Milosavljevic
2020-03-31 16:32   ` Raghav Gururajan
2020-04-01  2:38     ` Maxim Cournoyer
2020-03-30  9:47 ` [bug#40264] Linphone: 13-add-linphone Raghav Gururajan
2020-03-30 16:50 ` [bug#40264] Linphone: 14-add-linphoneqt Raghav Gururajan
2020-03-31 13:44 ` [bug#40264] Linphone: 15-add-msamr Raghav Gururajan
2020-03-31 14:12 ` [bug#40264] Linphone: 16-add-openh264 Raghav Gururajan
2020-03-31 14:31 ` [bug#40264] Linphone: 17-add-mssilk Raghav Gururajan
2020-03-31 14:50 ` [bug#40264] Linphone: 18-add-mswebrtc Raghav Gururajan
2020-04-01 20:21 ` [bug#40264] Linphone: 3-add-bcunit-v2 Raghav Gururajan
2020-04-03 10:51   ` Danny Milosavljevic
2020-04-01 22:13 ` [bug#40264] Linphone: 4-add-bctoolbox-v2 Raghav Gururajan
2020-04-03 10:52   ` Danny Milosavljevic
2020-04-01 22:20 ` [bug#40264] Linphone: 5-add-belr-v2 Raghav Gururajan
2020-04-03 10:52   ` Danny Milosavljevic
2020-04-01 22:32 ` [bug#40264] Linphone: 6-add-belcard-v2 Raghav Gururajan
2020-04-03 10:51   ` Danny Milosavljevic
2020-04-01 22:40 ` [bug#40264] Linphone: 7-add-bcmatroska2-v2 Raghav Gururajan
2020-04-03 10:52   ` Danny Milosavljevic
2020-04-01 22:46 ` [bug#40264] Linphone: 8-add-bcg729-v2 Raghav Gururajan
2020-04-03 11:01   ` Danny Milosavljevic
2020-04-01 22:56 ` [bug#40264] Linphone: 9-add-ortp-v2 Raghav Gururajan
2020-04-03 11:02   ` Danny Milosavljevic
2020-04-01 23:04 ` [bug#40264] Linphone: 10-add-bzrtp-v2 Raghav Gururajan
2020-04-03 11:09   ` Danny Milosavljevic
2020-04-02  0:20 ` [bug#40264] Linphone: 11-add-mediastreamer-v2 Raghav Gururajan
2020-04-03 11:38   ` Danny Milosavljevic
2020-04-03 14:30   ` Raghav Gururajan
2020-04-05  4:08     ` maxim.cournoyer [this message]
2020-04-05  4:16   ` maxim.cournoyer
2020-04-05  7:29   ` Raghav Gururajan
2020-04-02  0:44 ` [bug#40264] Linphone: 12-add-belle-sip-v2 Raghav Gururajan
2020-04-02 11:24   ` Danny Milosavljevic
2020-04-02 16:33   ` Raghav Gururajan
2020-04-02 17:19   ` Raghav Gururajan
2020-04-03 11:34     ` Danny Milosavljevic
2020-04-04 17:36       ` Maxim Cournoyer
2020-04-04 18:18       ` Raghav Gururajan
2020-04-05  4:18         ` maxim.cournoyer
2020-04-05 19:06       ` Danny Milosavljevic
2020-04-02  1:20 ` [bug#40264] Linphone: 13-add-linphone-v2 Raghav Gururajan
2020-04-05 19:49   ` Danny Milosavljevic
2020-04-05 19:57   ` Danny Milosavljevic
2020-04-05 22:54   ` Raghav Gururajan
2020-04-05 22:55   ` Raghav Gururajan
2020-04-02  1:47 ` [bug#40264] Linphone: 14-add-linphoneqt-v2 Raghav Gururajan
2020-04-02  2:06 ` [bug#40264] Linohone: 15-add-msamr-v2 Raghav Gururajan
2020-04-06  0:03   ` Danny Milosavljevic
2020-04-02  2:55 ` [bug#40264] Linphone: 16-add-msopenh264-v2 Raghav Gururajan
2020-04-05 23:05   ` Danny Milosavljevic
2020-04-02  3:00 ` [bug#40264] Linphone: 17-add-mssilk-v2 Raghav Gururajan
2020-04-05 23:06   ` Danny Milosavljevic
2020-04-02  3:06 ` [bug#40264] Linphone: 18-add-mswebrtc-v2 Raghav Gururajan
2020-04-05 23:06   ` Danny Milosavljevic
2020-04-02  8:56 ` [bug#40264] Linphone: 14-add-linphoneqt-v3 Raghav Gururajan
2020-04-02 16:27   ` Raghav Gururajan
2020-04-02 20:56   ` Raghav Gururajan
2020-04-03 23:50   ` Raghav Gururajan
2020-04-02 20:53 ` [bug#40264] Linphone: 14-add-linphoneqt-v4 Raghav Gururajan
2020-04-02 23:19 ` [bug#40264] Linphone: 13-add-linphone-v3 Raghav Gururajan
2020-04-05 20:05   ` Danny Milosavljevic
2020-04-03  0:24 ` [bug#40264] Linphone: 14-add-linphoneqt-v5 Raghav Gururajan
2020-04-03 23:47 ` [bug#40264] Linphone: 14-add-linphoneqt-v6 Raghav Gururajan
2020-04-05 20:19   ` Danny Milosavljevic
2020-04-06  3:01   ` Raghav Gururajan
2020-04-06  5:56   ` Raghav Gururajan
2020-04-05  7:28 ` [bug#40264] Linphone: 11-add-mediastreamer-v3 Raghav Gururajan
2020-04-05 15:02   ` maxim.cournoyer
2020-04-05 18:29   ` Danny Milosavljevic
2020-04-05 19:41     ` Danny Milosavljevic
2020-04-05 22:52     ` Raghav Gururajan
2020-04-06  0:14       ` Danny Milosavljevic
2020-04-06  0:28       ` Raghav Gururajan
2020-04-06  2:40         ` maxim.cournoyer
2020-04-06  4:04 ` [bug#40264] Linphone: 14-add-linphoneqt-v7 Raghav Gururajan
2020-04-10 21:47   ` Danny Milosavljevic
2020-04-10 23:50   ` Danny Milosavljevic
2020-04-15  2:50     ` Maxim Cournoyer
2020-04-15  4:36       ` Maxim Cournoyer
2020-04-15  6:13         ` Maxim Cournoyer
2020-04-12  3:55   ` Raghav Gururajan
2020-04-08  7:01 ` [bug#40264] Replace source URI with mirror Raghav Gururajan
2020-04-08  7:29   ` [bug#40264] Mirror and Formatting Raghav Gururajan
2020-04-16  4:49     ` bug#40264: " maxim.cournoyer
2020-04-15  2:07   ` [bug#40264] Replace source URI with mirror Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu7q3787.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me \
    --to=maxim.cournoyer@gmail.com \
    --cc=40264@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    --cc=raghavgururajan@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.