From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:37793)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jPmME-0001Pn-QU
 for guix-patches@gnu.org; Sat, 18 Apr 2020 08:14:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jPmMD-0003Vg-Rm
 for guix-patches@gnu.org; Sat, 18 Apr 2020 08:14:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:58778)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jPmMD-0003VK-MZ
 for guix-patches@gnu.org; Sat, 18 Apr 2020 08:14:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jPmMD-00034D-Im
 for guix-patches@gnu.org; Sat, 18 Apr 2020 08:14:01 -0400
Subject: [bug#40677] [PATCH 01/30] gnu: jami: Move Jami and its dependencies
 to jami.scm.
Resent-Message-ID: <handler.40677.B40677.158721203211767@debbugs.gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
References: <20200417015857.0650ff6a@interia.pl>
 <20200417003433.5608-1-tona_kosmicznego_smiecia@interia.pl>
Date: Sat, 18 Apr 2020 14:13:42 +0200
In-Reply-To: <20200417003433.5608-1-tona_kosmicznego_smiecia@interia.pl> (Jan
 Wielkiewicz's message of "Fri, 17 Apr 2020 02:34:04 +0200")
Message-ID: <87mu79j8jt.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
Cc: 40677@debbugs.gnu.org


Hello Jan,

Nice work! Please find my comments below.

>  gnu/packages/jami.scm      | 350 +++++++++++++++++++++++++++++++++++++
>  gnu/packages/telephony.scm | 291 ------------------------------
>  2 files changed, 350 insertions(+), 291 deletions(-)
>  create mode 100644 gnu/packages/jami.scm

You also need to update 'gnu/local.mk' when adding new files.

Thanks,

Mathieu