From: Tobias Geerinckx-Rice <me@tobias.gr>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: guix-devel@gnu.org
Subject: Re: [FONTS]: Media Type Specification Changed.
Date: Wed, 13 May 2020 18:13:08 +0200 [thread overview]
Message-ID: <87mu6b3jaj.fsf@nckx> (raw)
In-Reply-To: <259afe46-ebd1-bf95-3893-6120ef50097a@disroot.org>
[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]
Raghav,
Raghav Gururajan 写道:
> Oh! How are you doing now? Let me know if you need anything. I
> can try
> and help in any way plausible. :-)
Thanks! I'm better than I've been, don't worry.
> That change has been discussed during review and was only merged
> after I
> gave the fact of about fontconfig. :-)
All right!
> I understand. I should have mentioned in the log. But it was not
> sneaky.
I tried to be very clear that I didn't actually think so. Sorry
if I failed.
> But yeah, I should add that to my workflow of making
> comments/logs.
Sweet.
> Agreed! I do not like inconsistencies either. Please find the
> patch
> attached with this email.
LGTM, apart from one nitpick.
Both /share/fonts/{true,open}type are extremely common on other
distributions, while /share/fonts/webopen would be unique to Guix.
The de facto ’standard’ for (the much newer) WOFF seems to be,
well, /share/fonts/woff. So despite my previous comments about
avoiding acronyms, I'll keep the latter. We can always revisit
this later.
Applied as 7d426c5b0e27cc3e72c6e12e07b8c42055cedba0. Thanks!
Kind regards,
T G-R
[0]:
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2020-05-13 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 14:41 [FONTS]: Media Type Specification Changed Raghav Gururajan
2020-05-10 15:55 ` Tobias Geerinckx-Rice
2020-05-10 16:13 ` Raghav Gururajan
2020-05-10 18:09 ` Tobias Geerinckx-Rice
2020-05-11 4:11 ` Raghav Gururajan
2020-05-13 16:13 ` Tobias Geerinckx-Rice [this message]
2020-05-13 19:04 ` Raghav Gururajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu6b3jaj.fsf@nckx \
--to=me@tobias.gr \
--cc=guix-devel@gnu.org \
--cc=raghavgururajan@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.