From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yEEwAhdLHF82CwAA0tVLHw (envelope-from ) for ; Sat, 25 Jul 2020 15:09:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uLGsORZLHF8UXwAAB5/wlQ (envelope-from ) for ; Sat, 25 Jul 2020 15:09:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 70F789400E1 for ; Sat, 25 Jul 2020 15:09:10 +0000 (UTC) Received: from localhost ([::1]:48390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzLnQ-0000PE-WD for larch@yhetil.org; Sat, 25 Jul 2020 11:09:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzLnK-0000Os-Qt for guix-patches@gnu.org; Sat, 25 Jul 2020 11:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39271) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzLnK-0000mo-IV for guix-patches@gnu.org; Sat, 25 Jul 2020 11:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jzLnK-0003LW-EU for guix-patches@gnu.org; Sat, 25 Jul 2020 11:09:02 -0400 Subject: bug#41818: [PATCH] gnu: Add syncthing-gtk. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 25 Jul 2020 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41818 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: paul , 41818-done@debbugs.gnu.org Mail-Followup-To: 41818@debbugs.gnu.org, marius@gnu.org, goodoldpaul@autistici.org Received: via spool by 41818-done@debbugs.gnu.org id=D41818.159568968612791 (code D ref 41818); Sat, 25 Jul 2020 15:09:02 +0000 Received: (at 41818-done) by debbugs.gnu.org; 25 Jul 2020 15:08:06 +0000 Received: from localhost ([127.0.0.1]:50816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzLmQ-0003KF-Fw for submit@debbugs.gnu.org; Sat, 25 Jul 2020 11:08:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzLmO-0003Jk-8n for 41818-done@debbugs.gnu.org; Sat, 25 Jul 2020 11:08:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45332) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzLmI-0000hN-7b; Sat, 25 Jul 2020 11:07:58 -0400 Received: from 84-52-226.102.3p.ntebredband.no ([84.52.226.102]:38856 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jzLmH-0006HP-PP; Sat, 25 Jul 2020 11:07:58 -0400 From: Marius Bakke In-Reply-To: <79263f3e-be1c-b7a8-aa46-bdf82c0cafeb@autistici.org> References: <20200611213707.22562-1-goodoldpaul@autistici.org> <87h7v2c0uw.fsf@gnu.org> <79263f3e-be1c-b7a8-aa46-bdf82c0cafeb@autistici.org> Date: Sat, 25 Jul 2020 17:07:41 +0200 Message-ID: <87mu3nvdj6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: ukkqcxDSwrFZ --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable paul writes: > Hi Marius, > > On 6/22/20 10:16 PM, Marius Bakke wrote: >> Giacomo Leidi writes: >> >>> * gnu/packages/syncthing.scm (syncthing-gtk): New variable. >> [...] >>=20=20=20=20 >>> + (build-system python-build-system) >>> + (arguments >>> + `(#:python ,python-2)) >>> + (propagated-inputs >>> + `(("python2-bcrypt" ,python2-bcrypt) >>> + ("python2-dateutil" ,python2-dateutil) >>> + ("python2-pycairo" ,python2-pycairo) >>> + ("python2-pygobject" ,python2-pygobject) >>> + ("python-nautilus" ,python-nautilus) >>> + ("libappindicator" ,libappindicator) >>> + ("libnotify" ,libnotify) >>> + ("psmisc" ,psmisc) >>> + ("syncthing" ,syncthing))) >> I don't think these needs to be propagated, as the 'syncthing-gtk' >> executable will be automatically wrapped with a PYTHONPATH that contains >> the Python inputs. > I didn't know that, I really should study deeper the build systems. >> I'm not sure about libappindicator, libnotify and psmisc though. >> Ideally we'd insert absolute references where appropriate to avoid >> propagation. In the worst case we can wrap it with those in PATH. >> >> Can you look into it and send an updated patch? > > As you suggested I managed to move all propagated-inputs to the inputs=20 > field, I'm not sure I did it right but from my tests the package seem to= =20 > be working. Excellent. > I'm attaching an updated version of the patch, I apologize for the delay. Apologies in return, this got lost in my email queue. Applied! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8cSr0ACgkQoqBt8qM6 VPq/2Af/b9yTEY6N7sjUZglTTVULju0B/k29dmg5Q5emXuJ7TWJOEEvG4HftaqYi EJej80Svc7JT2YmBMeJ9QS73UatI75kkh1LxPnYIweLw2JiCJXufqxaDX2l+vUfP Ffw3aZcYnYPhr32n+6k9BsqLuyx7iJuvwqMs4atYbtEXgacxC1+ymdq9Ia5hfygc 1qgG65/LG0ZZF8MncJbmYOZfZUUcMU20qhWCDGeoukGFlvTNiFNdAdqPqQV0BpGp 31CCWEB5F5ORgxZEcDOvDqOKY+bgNWw1zTqncn2tWPudHr55JStk5URgfyhDGmj1 8WQc43vVojZwPs9Zrm9oCIldEMU6jw== =WTOP -----END PGP SIGNATURE----- --=-=-=--