From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wBjAFqrQjV8MSAAA0tVLHw (envelope-from ) for ; Mon, 19 Oct 2020 17:45:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WK+fEqrQjV/TSgAAB5/wlQ (envelope-from ) for ; Mon, 19 Oct 2020 17:45:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C17D5940396 for ; Mon, 19 Oct 2020 17:45:13 +0000 (UTC) Received: from localhost ([::1]:60198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUZDb-0005SL-Hy for larch@yhetil.org; Mon, 19 Oct 2020 13:45:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUZDS-0005S8-SZ for guix-patches@gnu.org; Mon, 19 Oct 2020 13:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58983) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUZDS-00079N-I8 for guix-patches@gnu.org; Mon, 19 Oct 2020 13:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUZDS-00021v-FX for guix-patches@gnu.org; Mon, 19 Oct 2020 13:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44075] [PATCH] gnu: Add make-glibc-locales-collection. Resent-From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Oct 2020 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44075 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 44075@debbugs.gnu.org Received: via spool by 44075-submit@debbugs.gnu.org id=B44075.16031294747704 (code B ref 44075); Mon, 19 Oct 2020 17:45:02 +0000 Received: (at 44075) by debbugs.gnu.org; 19 Oct 2020 17:44:34 +0000 Received: from localhost ([127.0.0.1]:42292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUZD0-00020C-A3 for submit@debbugs.gnu.org; Mon, 19 Oct 2020 13:44:34 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUZCw-0001zw-O8 for 44075@debbugs.gnu.org; Mon, 19 Oct 2020 13:44:32 -0400 Received: by mail-wm1-f67.google.com with SMTP id e2so378264wme.1 for <44075@debbugs.gnu.org>; Mon, 19 Oct 2020 10:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=b9LQTHmeg1AK9QW5vyhvTdPoeLDB+lQ1GoJrgGhdEIE=; b=ptmsmJ5sSdy7fNep62eeFhx41IovaihpZhnyYbYyjwVoNDN9txGQ3moCoNRqQ5T7Oa Sf+Paiv0MR6yEpeQp8m7Ub2lfdP18ym1AJeRvmd2IU47sIoMHPRVZib0fnkECZrzXwNo BW8qJjuajxkQ112CCAeiHJ2MdI9KTvp99TRz7sI0Bp/YfsWpFJGsUaAEG1Idg5W1qHye Wxm0goy52uAKXldnY5fvN0PKjYDlvlReJVboK5dIuTC/LK8enKJcmIgZnx+o0yVi/b0s epe/J6/Di46kD6GueRRJdu2E+iRwa1lQl0a8Y5SrM9ycFvILcTRcTCtNaRPByW+iQKgL +Orw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=b9LQTHmeg1AK9QW5vyhvTdPoeLDB+lQ1GoJrgGhdEIE=; b=R3Nt7DB2BjWtYoZs+OhYagPfsBwQSRYtn3i6YHCwWYC8Jj3NWZv5hL+1uwTPupvS98 8Z1FB9gjr8Enp2iXfBqUHEF282xOgj2jZjqIU/ItCG4XJ4Lqp42NXXdZmLP3Ekz2+nbO OnhldRJPcu9wYp3xI7EZfuGM0W9gzv6rYwq+cAmYJex9UySQZfsLGgR77gP1Tkv0ibAd K3mmxaYCWqIlFRcS0uVWpIoSa0OOUiwWxqnoh1UJmnldRHV7qgeR6ZCJKffiRRt3Vwvp 0RSDcx3+yrqu/DDF/Y2ZUrJpYrVqa44B2hVfg/WI3IJegb7vRAlze4vlwoJwAj4WXjEd r3ag== X-Gm-Message-State: AOAM530FipMsRjz9+5yvDfpgfAmQ91ndPAwqetEiJq6TLTZqbGBqaIEP FJACto0jiDWa7RfAgqnsZkccoqkmJ3k7Pdhv X-Google-Smtp-Source: ABdhPJzMPzzdS56eOtju2tOFjFSIEfAA2mt8vcie6zSliUw4nmVxVYGWZnUR9mu0UyvU+TmKqB5Tug== X-Received: by 2002:a7b:c8c9:: with SMTP id f9mr369953wml.162.1603129464348; Mon, 19 Oct 2020 10:44:24 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id w4sm353128wmi.10.2020.10.19.10.44.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 10:44:23 -0700 (PDT) From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas References: <20201019064739.4736-1-efraim@flashner.co.il> <87tuuqnym5.fsf@gmail.com> <20201019140236.GF9117@E5400> Date: Mon, 19 Oct 2020 19:43:27 +0200 In-Reply-To: <20201019140236.GF9117@E5400> (Efraim Flashner's message of "Mon, 19 Oct 2020 17:02:36 +0300") Message-ID: <87mu0im7r4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.8 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=ptmsmJ5s; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: sF+0xkUP47KC Hello, Efraim Flashner writes: > Thanks for taking a look. No problem at all, I was thinking about something along these lines too, but then I saw your patch. :-) > For the utf8 vs UTF-8 there are a couple of comments in the code: > The above phase does not install locales with names using > the "normalized codeset." Thus, create symlinks like: > en_US.utf8 -> en_US.UTF-8 > > and also: > For backward compatibility with Guix > <=3D 0.8.3, add "xx_YY.UTF-8". Yes, what I mean is that the comments along the code may need to be clarified, but adding a "nobody knows" doesn't add much information. The actual source[1] says that the correct value is utf8, following the rules for the 'normalized codeset' naming, that I copy here: 1. Remove all characters besides numbers and letters. 2. Fold letters to lowercase. 3. If the same only contains digits prepend the string =E2=80=98"iso"=E2= =80=99. We should stick to that naming regarding libc locales (note to self), even though we keep the links for compatibility. That includes the other locale at en_us-glibc-locales. >> What do you think about replacing make-glibc-utf8-locales with a call of >> the new function (using that code) ensuring that the generated >> derivation stays the same for that case (i.e. it's optimized for the >> UTF-8 case)? > > This is what I originally wanted to do, but there's a glibc-locales > buried in the bootstrap path so it's not so easy to just swap it out. I guess you mean glibc-utf8-locales, if not I'm missing where that reference could come from. That's why I insist on leaving exactly the same derivation. > I can make the change in core-updates. I'll play around with it and > see if I can come out with the same derivation using a different > function, but I'm not expecting it to turn out identical. The colour of my lisp-rate belt isn't even close to some you can see around here but I could bring you some help if you want, because I think it's easier to do it without any change in current packages than it might sound. Not the definitions in scheme, of course, I mean the derivations the daemon actually sees. Said this, I've seen that [single-]locale-directory does mostly the same, and there is a build-locale function in gnu/build/locale.scm... so I'm starting to see as a better idea to clean up glibc-utf8-locales up in core-updates using the latter, as it would lead to cleaner code for the builder. Could you check that and tell if you consider feasible what I propose? Happy hacking! Miguel [1] info "(libc)Using gettextized software"