From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mM0MLtY2nV+QNwAA0tVLHw (envelope-from ) for ; Sat, 31 Oct 2020 10:05:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AmDKKdY2nV8mUQAAB5/wlQ (envelope-from ) for ; Sat, 31 Oct 2020 10:05:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 701B7940148 for ; Sat, 31 Oct 2020 10:05:10 +0000 (UTC) Received: from localhost ([::1]:56128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYnkz-0004Kk-EI for larch@yhetil.org; Sat, 31 Oct 2020 06:05:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYnkt-0004Kc-0l for guix-patches@gnu.org; Sat, 31 Oct 2020 06:05:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYnks-0005ej-Ni for guix-patches@gnu.org; Sat, 31 Oct 2020 06:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYnks-0006CA-JC for guix-patches@gnu.org; Sat, 31 Oct 2020 06:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44321] [PATCH 4/6] guix build: Move transformation options to (guix transformations). Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 31 Oct 2020 10:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44321 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Cc: 44321@debbugs.gnu.org Received: via spool by 44321-submit@debbugs.gnu.org id=B44321.160413868723786 (code B ref 44321); Sat, 31 Oct 2020 10:05:02 +0000 Received: (at 44321) by debbugs.gnu.org; 31 Oct 2020 10:04:47 +0000 Received: from localhost ([127.0.0.1]:60564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYnkc-0006Ba-W9 for submit@debbugs.gnu.org; Sat, 31 Oct 2020 06:04:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYnkb-0006BJ-OT for 44321@debbugs.gnu.org; Sat, 31 Oct 2020 06:04:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36102) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYnkW-0005UB-Hd; Sat, 31 Oct 2020 06:04:40 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=56720 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYnkU-0004zx-Cu; Sat, 31 Oct 2020 06:04:38 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201029231000.14568-1-ludo@gnu.org> <20201029231000.14568-4-ludo@gnu.org> <87lffn48rc.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 10 Brumaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 31 Oct 2020 11:04:37 +0100 In-Reply-To: <87lffn48rc.fsf@gmail.com> ("Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas"'s message of "Sat, 31 Oct 2020 00:03:03 +0100") Message-ID: <87mu02ww22.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: E2dnW/yYIRIP Hi, Miguel =C3=81ngel Arruga Vivas skribis: > Ludovic Court=C3=A8s writes: > >> * guix/transformations.scm: New file. > > The main comment regarding this patch is that file has to be added to > po/guix/POTFILES.in, or the translations will be lost. Indeed, I=E2=80=99ll add it to that file. > I've seen that you've changed some code identifiers, here: >> - (else (tarball-base-name (file-sans-extension file-name))))) >> + (_ (tarball-base-name (file-sans-extension file-name))))) > > And there: >> - (x >> + (_ > > And these changes seem sensible as the match parameter is unused. Yeah. Thanks! Ludo=E2=80=99.