all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Brice Waegeneire <brice@waegenei.re>
To: Leo Famulari <leo@famulari.name>
Cc: 46322@debbugs.gnu.org
Subject: [bug#46322] [staging 0/2] Update pulseaudio to 14.2 and move to meson build system
Date: Tue, 16 Feb 2021 09:01:52 +0100	[thread overview]
Message-ID: <87mtw4785r.fsf_-_@waegenei.re> (raw)
In-Reply-To: <YCmJMKnXBZMVgFYV@jasmine.lan> (Leo Famulari's message of "Sun, 14 Feb 2021 15:33:52 -0500")

Hello Leo,

Leo Famulari <leo@famulari.name> writes:

> On Fri, Feb 05, 2021 at 09:00:29AM +0100, Brice Waegeneire wrote:
>> * gnu/packages/pulseaudio.scm (pulseaudio)[build-system]: Switch from
>> gnu to meson.
>> [arguments]: Migrate configure flags for meson.
>> [propagated-inputs]: Replace 'gdbm' with 'tdb', upstream default.
>
>> +     `(#:configure-flags
>> +       (let ((out (assoc-ref %outputs "out")))
>> +         (list "-Doss-output=disable"
>> +               "-Dbluez5=true"
>> +               "-Dlocalstatedir=/var"
>> +               (string-append "-Dudevrulesdir="
>> +                              out "/lib/udev/rules.d")
>> +               ;; Ensure the RUNPATH contains all installed library locations.
>> +               (string-append "-Dc_link_args=-Wl,-rpath="
>> +                              out "/lib/pulseaudio:"
>> +                              out "/lib:"
>> +                              out "/lib/pulse-14.2/modules")))
>
> We should avoid hard-coding the version string with something like
> "/lib/pulse-" ,version "/modules"

Done.

> Overall LGTM for staging. Maybe you already did this but I recommend
> comparing the built outputs of the old and new versions to make sure we
> don't accidentally lose any components by using the new build system.

No, I hadn't so thank you for the heads up.  Esound support isn't
availaible with the new build system but that software isn't maintained
anymore and pulseaudio devs are looking to drop support for it¹.

Pushed as 0c25529c6c4d1da7483db3db8bdc4a10b580c85b.

¹ https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/b1f599dcd992e61c5ce2ed870bd913a43bb32deb/NEWS#L73

Cheers,
- Brice




  parent reply	other threads:[~2021-02-16  8:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05  7:55 [bug#46322] [staging 0/2] Update pulseaudio to 14.2 and move to meson build system Brice Waegeneire
2021-02-05  8:00 ` [bug#46322] [staging 1/2] gnu: pulseaudio: Update to 14.2 Brice Waegeneire
2021-02-14 20:31   ` Leo Famulari
2021-02-05  8:00 ` [bug#46322] [staging 2/2] gnu: pulseaudio: Use meson build system Brice Waegeneire
2021-02-14 20:33   ` Leo Famulari
2021-02-16  8:01     ` [bug#46322] [staging 0/2] Update pulseaudio to 14.2 and move to " Brice Waegeneire
2021-02-16  8:01     ` Brice Waegeneire [this message]
2021-02-16 17:59       ` Leo Famulari
2021-02-14 20:31 ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtw4785r.fsf_-_@waegenei.re \
    --to=brice@waegenei.re \
    --cc=46322@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.