From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8MX+GFy4SGDwZgAA0tVLHw (envelope-from ) for ; Wed, 10 Mar 2021 12:15:24 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GEbJFFy4SGC3JwAAB5/wlQ (envelope-from ) for ; Wed, 10 Mar 2021 12:15:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 0111E1D393 for ; Wed, 10 Mar 2021 13:15:24 +0100 (CET) Received: from localhost ([::1]:53894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJxkJ-0006En-4f for larch@yhetil.org; Wed, 10 Mar 2021 07:15:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJxjd-0006Ce-0s for guix-devel@gnu.org; Wed, 10 Mar 2021 07:14:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59987) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJxjc-0005SY-LV; Wed, 10 Mar 2021 07:14:40 -0500 Received: from [2a01:e0a:19b:d9a0:c4bd:335d:6b08:e2bd] (port=42086 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lJxjb-0007uN-UJ; Wed, 10 Mar 2021 07:14:40 -0500 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: 04/07: inferior: Break cached-channel-instance into two procedures. References: <20210310075017.12619.72665@vcs0.savannah.gnu.org> <20210310075020.83E6A211CF@vcs0.savannah.gnu.org> <871rcn72l7.fsf@gnu.org> Date: Wed, 10 Mar 2021 13:14:38 +0100 In-Reply-To: <871rcn72l7.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 10 Mar 2021 10:57:56 +0100") Message-ID: <87mtvb434h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615378524; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ZZ/Z11h/1kQU/Wutar0qheAkTtjV6mB3/6YTmoDqzgs=; b=ajH4flDLzfvspdMdvJsTEs1LQpo+LJ9Jtb/yckKhJnzApa+0GtC+30nJBXuwMZ1lgTb/Za nl9np25aJ9CqZO82vplO8q2PKihvGqtQZqhF7AUmF6JT19RM4yKjjyWaaTZnFvvTjRgSyp fyNaJKBF85eICfY5G0y5dT0yTDkZNlHBCVCBLe77aPAzHu9xUnYcYaw75W7LkK4xDcvq0O ES7NFX18yW35BE7JoQpwm6lkLtx3TYHoqCh7zKhsNJMQ88i5efQ3a7EqmE67CP3uId/ERN qUchdMgEY4MSbPvrjHKSut5LMni9CAxOWGreXwDXnnASC8JimoFlPTNC6KX1cw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615378524; a=rsa-sha256; cv=none; b=R4tlyhsAuE5KFA4cZsVWYPKWE+XC6Vn0gnXMe2UIccm6xhbxzGq9PWFsTUIVmnRKhBBHNv H0Nq1lw0vME2JffzvSuDjbX3wE4ewog4zNVlrunh+N/ucwO9Xv5kPrmdApejE5VxE6D7Ca /TtViRTOdtXBtbRpRsy++bWQIlOX+KEIuybon2v+bxuBDgqBc7i6HAsfEg5NY2ZsaIs4LB upKa85kflan1uQFvINFSSVeHKUag+H8vQK5gok1avH0knzQptTBfAxLVBL+hCIzYm7gGiK 1/ydGc4UCnt9Tbv8ko4qptiMowR6DuqnpbHTfJqEK333GzxomGc+npk+nEANOg== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=none; spf=pass (aspmx2.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.89 Authentication-Results: aspmx2.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx2.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 0111E1D393 X-Spam-Score: -2.89 X-Migadu-Scanner: scn0.migadu.com X-TUID: i1cY6iaeu0CX Hey, > We need to keep =E2=80=98cached-channel-instance=E2=80=99 because it=E2= =80=99s part of the > public API and used outside Guix (in Guix-Jupyter at least). We can use > =E2=80=98define-deprecated=E2=80=99. > > Also, I think =E2=80=98cached-profile=E2=80=99 doesn=E2=80=99t quite capt= ure what this is > about. :-) The docstring should mention what COMMITS is. The fact > that INSTANCES is a thunk is a bit awkward and IMO not great for a > public interface. > > WDYT? Yeah you're right the abstraction is really not great. I'll tweak Cuirass to use the existing API instead. Reverted with: 8898eaec57f6294221888e6dca1802abdd3d5868. Thanks, Mathieu