From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GJcYECwarGBvsgAAgWs5BA (envelope-from ) for ; Mon, 24 May 2021 23:27:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eIzHCywarGDkEQAAbx9fmQ (envelope-from ) for ; Mon, 24 May 2021 21:27:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E56C324BF6 for ; Mon, 24 May 2021 23:27:07 +0200 (CEST) Received: from localhost ([::1]:42266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llI6N-0008CR-0W for larch@yhetil.org; Mon, 24 May 2021 17:27:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llI6I-0008CG-Se for guix-patches@gnu.org; Mon, 24 May 2021 17:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llI6I-0008Fv-Jv for guix-patches@gnu.org; Mon, 24 May 2021 17:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llI6I-0000sv-G7 for guix-patches@gnu.org; Mon, 24 May 2021 17:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48630] [PATCH] adds `ack' package and it's perl module dependency File::Next Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 May 2021 21:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48630 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Gabriel Wicki , 48630@debbugs.gnu.org Received: via spool by 48630-submit@debbugs.gnu.org id=B48630.16218915933365 (code B ref 48630); Mon, 24 May 2021 21:27:02 +0000 Received: (at 48630) by debbugs.gnu.org; 24 May 2021 21:26:33 +0000 Received: from localhost ([127.0.0.1]:44037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llI5o-0000sD-S9 for submit@debbugs.gnu.org; Mon, 24 May 2021 17:26:33 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:60090 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llI5m-0000rz-R7 for 48630@debbugs.gnu.org; Mon, 24 May 2021 17:26:31 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1621891583; bh=CttyecTjS7GAmMHmjgk9lC2v56FRHnnVjWlAmGxSKwg=; h=From:To:Subject:In-Reply-To:References:Date; b=RKj7A+LIgmy0aj4AQU+CqYjAoNLClCkyVx4uQSGFnrRE33yz2PEej9kNbLWeyjYFC 9EgUiZfN78+wbLtLsxnAscxaGgiu5HchOpXkI/ea1iEJs4tG0qqznMm2oYhRn4trSR zNcNwdvOh6ISm0ERMcw5yrGS1RSDY2o/0ol0/CHw= In-Reply-To: <20210524191054.7wtb4wopstgx2c77@silver> References: <20210524191054.7wtb4wopstgx2c77@silver> Date: Mon, 24 May 2021 23:26:22 +0200 Message-ID: <87mtsj962p.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621891628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=nwu8/g2rA1fI2q1RG/WslgQ5zYslhiU1kXX0Ko2zm1w=; b=d5qeqfkucqAIZWrCkBiUw7Kp1Avp/yAmIpipwDFTaCPRvWGp+2YxamSLAFQYrT/mmhpd7B YCoEazVmRuZEJ04PIranjNWAmsXZf/SCL/Zi5d/I/gR1f1ttOPjOrMPA03RnSwFUZkZYK+ iwGqvRX1pIvrKSu37kjyO6uzEgbgk1wzY0FJakcEDAVC9SfyXEPV69tlD2S82KnwIHplKs 9E3TWRSjx60+l9fQYqdsLoBSjawrLb9w4Jxb+DbeziEQkYl0S4zG0Nt4YkwKz7dRncm6Jt BoEdgSCXFIwJvkHIeHwqNkRc/NAPo6cTOjdgaZ2I1lhC+jqQ3oqjiwUCGwVrAQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621891628; a=rsa-sha256; cv=none; b=izArGOl3tNyKx1dfgzke7e3FrTRlOocGY1rDEjFf/2tdyjaAIa/0FXHWSpklr76bvWFp+Q 8RJ2OvT3q6KTFhgZTGC1RiSvFi5q3y9/cLd6TBf3APh7a+IX2Q5PSNawxmvUAQ3A3IYaGB qotm1O46F50TJhFlef5+eCH3XuCsv+pm+Amfniy+r3ekGIwKbRwGdGFw7/UCPvJmMnnl8T Px4qolEUhGWxTxIMQGxxTt3cLNk0ciRx2sCMyeOcoiEbd27++YZkyNKCV+qKEGmzkEir3F Y79Dhi2MVlUzBsnila0hI7zMxP0wyq2qd6qzb0GbjiC8lmyu7Xp7iAND+cnJGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=RKj7A+LI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=RKj7A+LI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E56C324BF6 X-Spam-Score: -3.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: /xVHAJRGq1Ne --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, May 24 2021, Gabriel Wicki wrote: > modified: gnu/packages/perl.scm > - adds package `perl-file-next' (module File::Next) > > modified: gnu/packages/textutils.scm > - adds package `ack' with disabled tests Commit messages should be written in ChangeLog format[1], you can look at previous commits for examples. This commit should also be split into two separate commits, one adding =E2=80=98perl-file-next=E2=80=99, and the other adding =E2=80=98ack=E2=80= =99. > +(define-public perl-file-next > + (package > + (name "perl-file-next") > + (version "1.18") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/petdance/file-next") > + (commit version))) > + (file-name "perl-next-file") Use =E2=80=98(file-name (git-file-name name version))=E2=80=99. > + (sha256 > + (base32 > + "0zdrxk409qxkbbv4fl4wi285kfzyrpaja9wfl00vrxc078rs4afm")))) > + (build-system perl-build-system) > + (synopsis "File::Next is a lightweight, taint-safe file-finding Perl = module") Try to make the synopsis as concise as possible, just =E2=80=9CLightweight, taint-safe file-finding Perl module=E2=80=9D should do. See the =E2=80=98S= ynopses and Descriptions=E2=80=99 section of the manual. > + (description "A Perl CPAN module for finding files. It has no non-co= re > +prerequisites") The description should contain one or more complete sentences. > +(define-public ack > + (package > + (name "ack") > + (version "3.5.0") > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/beyondgrep/ack3") > + (commit (format #nil "v~a" version)))) We usually use =E2=80=98(string-append "v" version)=E2=80=99 instead of =E2= =80=98format=E2=80=99. > + (file-name "ack") Use =E2=80=98(file-name (git-file-name name version))=E2=80=99 (same as abo= ve). > + (sha256 > + (base32 "00131vqjbzcn6w22m0h3j6x9kp59dimfnnqhpmi78vbcj0jws1= dv")))) > + (build-system perl-build-system) > + (arguments '(#:tests? #f)) What=E2=80=99s the reason for disabling the tests? > + (propagated-inputs `(("perl-file-next" ,perl-file-next))) > + (synopsis "Code-searching tool optimized for programmers with large t= rees > +of source code") > + (description "ack is a tool for finding text inside files. it is desi= gned for ^^ Please use double spacing, and capitalize. > +hackers and programmers by being fast, ignoring VCS directories, letting= a user > +easily specify file types, match highlighting, Perl-Compatible Regular > +Expressions, and being faster to type than `grep '") ^^ Unecessary whitespace, and missing period. Could you send an updated series? [1]: https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-L= ogs --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmCsGf4VHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5aQ8QAIxabUMnGFQoYw1oOf8ojuow1Eqn A7uCsWBdxOKoeFEQzHhyvQgQHtgtVTld+pSngpElgSuBeD+HE/j4H477rMiFoj8Q hVFNDbH2BKDq9GJ7EaBMZA6ZAKTisqhqcbsoR7i78ir6pyFwlV24EA2AJ0H237gK NAA+9bVo991B4E0pe+nHgTQY9vsN1HstGhKFujTqdGHy++JWZCGNQSSPQmsSYyyT 1aLz7dfYkT+v24CMogIq/Fg5TscZE6Cy1YWtrb87v9rE4kVx9Wbw1WYtGaMtVItc LEXHNa5nIai2Xfo0VkgsaYmgm2JA7EP9WMGF4QL4h2s+huNkR/9dmpXEVzyEiHaM oIQIO5k+E77ZnMNqwMnDPc+4GowoDjS1ESyXwtPIK8lB9u0HJCdLDvf98iHJ2f33 mvDMOYuKY+FUDasOCNXZ/swF4OA8HjTT8gyEZ7SPfdcNAWyDxaVYSQclRCHAgwqx NwELoPRdu1Tm3N0szt55+zgj9uE4H9uFNUMA2VYf96I8ztr71vBa9GyQdti8hNIV PBu7Ce3gPQDUtvmL+0OzBfW6OOWCZpIdeHBcDL3y5b58OubcMm+wuju3nxyLplom gkKUqdUYNijBWzDbW+QuirBASZlOll7AdduoCL6ulW/k5bjAiTzRASRY7I1zW53z 5N2LHO9fBvxqgvN+ =Eoj3 -----END PGP SIGNATURE----- --=-=-=--