From: Andrew Tropin <andrew@trop.in>
To: Leo Famulari <leo@famulari.name>
Cc: 49486@debbugs.gnu.org
Subject: [bug#49486] [PATCH] gnu: msmtp: Make it configurable with envrinoment variables
Date: Mon, 12 Jul 2021 06:33:11 +0300 [thread overview]
Message-ID: <87mtqsrytk.fsf@trop.in> (raw)
In-Reply-To: <YOnlk502qx6js8g0@jasmine.lan>
[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Fri, Jul 09, 2021 at 01:26:30PM +0300, Andrew Tropin wrote:
>> From 38987bffcd1088315c6414d6c6141140c3969e6b Mon Sep 17 00:00:00 2001
>> From: Andrew Tropin <andrew@trop.in>
>> Date: Fri, 9 Jul 2021 13:20:10 +0300
>> Subject: [PATCH] gnu: msmtp: Make it configurable with envrinoment variables
>>
>> Add the support of following environment variables:
>> MSMTPQ_QUEUE_DIR
>> MSMTPQ_LOG
>> MSMTPQ_QUIET
>> MSMTPQ_CONN_TEST
>>
>> Add new --enqueue option, which forces to enqueue message instead of
>> attempting to send it.
>>
>> Make msmtpq quite by default for compatibility with emacs and use ping instead
>> of netcat for connection test.
>>
>> Use binary absolute path in msmtpq and msmtp-queue scripts instead of relying
>> on the binary being present in the $PATH.
>
> Thanks!
>
> Did you send these patches upstream?
>
> https://marlam.de/msmtp/contact/
>
Yes, just a few minutes ago.
> In general, we don't patch packages to add features in Guix. We try to
> stay close to what is offered by the upstream development team, except
> for bug fixes.
Agree, --enqueue is a feature and probably doesn't belong to the PM
repo, the rest is more like a fix. Ok, let's see, what Martin will
reply to proposed changes and I'll adjust this patch accordingly.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]
next prev parent reply other threads:[~2021-07-12 3:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 10:26 [bug#49486] [PATCH] gnu: msmtp: Make it configurable with envrinoment variables Andrew Tropin
2021-07-10 18:23 ` Leo Famulari
2021-07-12 3:33 ` Andrew Tropin [this message]
2021-07-12 14:56 ` Leo Famulari
2021-09-14 7:44 ` Andrew Tropin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtqsrytk.fsf@trop.in \
--to=andrew@trop.in \
--cc=49486@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.