From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wNTPMa4zU2FYHgEAgWs5BA (envelope-from ) for ; Tue, 28 Sep 2021 17:24:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yGyJLa4zU2EqWwAA1q6Kng (envelope-from ) for ; Tue, 28 Sep 2021 15:24:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6B3F6127D0 for ; Tue, 28 Sep 2021 17:24:30 +0200 (CEST) Received: from localhost ([::1]:48294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVEy5-0005Ho-9k for larch@yhetil.org; Tue, 28 Sep 2021 11:24:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVExt-0005HL-9W for guix-devel@gnu.org; Tue, 28 Sep 2021 11:24:17 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:50152 helo=mail.yoctocell.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVExq-0005IQ-Na; Tue, 28 Sep 2021 11:24:17 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1632842650; bh=GpDwLGekV6sa8XbXwPCPd6lOFXdc6Q2qBcr4BbOY1/c=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=r0pCvFK0AkvI2YigrNofSZE2xpl2Dae5WKNQW4vOBQE5jxXA/jgTuHdSu6jDZ7xSA III2traT/h7K8NNMJ47WVEg8PO5m+bqu3U+eU+MYNmh4LIcICBzRXyXFdjjdg83zw8 RVXbJW+66F+R55I372Clm9VYEay6ZAwdKWdBfZYc= To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: Merging wip-guix-home to master In-Reply-To: <87ee98c1kx.fsf@gnu.org> References: <87sfxvehyf.fsf@trop.in> <87sfxujdp2.fsf@yoctocell.xyz> <87ee98c1kx.fsf@gnu.org> Date: Tue, 28 Sep 2021 17:23:57 +0200 Message-ID: <87mtnw4tbm.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=87.96.130.155; envelope-from=public@yoctocell.xyz; helo=mail.yoctocell.xyz X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, PDS_OTHER_BAD_TLD=1.999, PDS_RDNS_DYNAMIC_FP=0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, Andrew Tropin Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632842670; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=27gw/87H526LPGK3Ejl+IBCJ1iLjl0wcBSIF3iMLtbM=; b=Avy9sU52I9uImd4Du+wIVRDHgV/KOgTXapeTDMguZGteD7+qxn8p0K7JJpKam7yfxwotyh o4oTDo9pvsIPIV8F47pvGn4KSreRU6vaWNkDLKnZHZP4zT3BP8lvUDM9w/hHxAtXutTWdx RNOOti70uoGwtWKhTxVEalAo/bNnjdC6OcUn8raC93mm/VR397he1adp7RkGlXJQup22tB ltI5VN8ZHkvNDZ1kH9eIg5ysNyThcst4kdmVKEurXMbSlxDY0+97B47cVpcGHfELLxe5YJ Vo4AnB1vUT5P41GvEcmt4eYE3IiAxDz73Kq9JP1niZ+yqVK44AYjzQ5qIg5tEA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632842670; a=rsa-sha256; cv=none; b=JOHcBu3I8n18PUegz4Mviwfm0brdFLYihJqgZfxvDj1bFnrB5kZaRnCRkn6k0Ivxntc0Zg r7xT2wLlOJ3p9HOePA9EBjO/Wnpc5pHtxhlTPKYYgDRJlH2j218E7X31P1rU+TsJlR8cxn 13FkqmWwih9oDCk9fRO5Y5aGO/iFT5z4ibG62cR7obsgI/xJ7x7V3AePkXeb1cZFEMQKld 7xJ0KP7kVeduKQ59eYM5U3xlQS2t8+s8pMkknG9zlkBIDcLzKJW7cJh4BrcKxvrgwzmlZn r7lYjdsuP5PwypEK7V6rBB15Q1PLMNRkcdlr7pohLcQ4uwH1tEJXXxp73BXM8Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=yoctocell.xyz header.s=mail header.b=r0pCvFK0; dmarc=pass (policy=none) header.from=yoctocell.xyz; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -5.20 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=yoctocell.xyz header.s=mail header.b=r0pCvFK0; dmarc=pass (policy=none) header.from=yoctocell.xyz; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 6B3F6127D0 X-Spam-Score: -5.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: oNnJPA2e2b80 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Sep 28 2021, Ludovic Court=C3=A8s wrote: > Xinglu Chen skribis: > >> I noticed that the =E2=80=98guix home import=E2=80=99 subcommand is incl= uded, but I >> think it needs more thought and feedback from people before it makes its >> way into =E2=80=98master=E2=80=99; it also seems to lack documentation. > > Agreed. There are a few (very few) exceptions, but in general each > command needs (1) a section in the manual and (2) unit tests and/or > integration tests in a shell script. > > Could you submit patches for that? Sure! :-) > IWBN if others could do an after-the-fact review of the code, too. Agreed. I quickly skimmed through (gnu home-services xdg), and I can already see some things that can be improved. :-) >> I just realized that it generates the following service declaration >> >> (service >> home-bash-service-type >> (home-bash-configuration >> (bashrc >> (list (slurp-file-gexp >> (local-file "/home/yoctocell/.bashrc")))))) >> >> but when running =E2=80=98guix home reconfigure=E2=80=99, the ~/.bashrc = file will be >> moved, so when running =E2=80=98guix home reconfigure=E2=80=99 for the s= econd time, it >> would read the ~/.bashrc which is itself a symlink to a file the store. >> =E2=80=98guix home import=E2=80=99 clearly isn=E2=80=99t in a usable sta= te as of right now=E2=80=A6 > > Also, I argued earlier against =E2=80=98slurp-file-gexp=E2=80=99: > > https://lists.gnu.org/archive/html/guix-devel/2021-06/msg00192.html > > I haven=E2=80=99t checked the different service configuration APIs, but I= think > we should avoid uses of =E2=80=98slurp-file-gexp=E2=80=99 entirely and in= stead do the > same as in the majority of Guix System services, which is to accept > file-like objects. > > Thoughts? Could you take a look? Yeah, I never really liked =E2=80=98slurp-file-gexp=E2=80=99; using =E2=80= =98local-file=E2=80=99 & co. would be better and more consistent. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFTM40VHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5RbAP/Ap2es9XkSXyUBzwdlP3Iemyz5Ms DEkUtMu7eQHPxzOC96lHJRVW/XWlx6nNE2qkffMzoesBPAHA35Z77U8/yz4N17WX yA0RpOga6POWhmLCo9t3mSOu9EHKN/CQ70XFsXSjMKduEkum/NPcEEfExuneuFPd pOC2Ttu1oIl1TA8MneEmj9wlS/EVYhyqO6y/BZIbnP1CNdUtuFkOXz5aTPZXlqIK YPqOyqklW39dEtzw+cIH7W9gT3vYvZCYl9veKEaWrkc/50up8z1Dbs4RWGIMXvQ4 T7DWqVnAH6acSmhcFI0QISkMfM0978q72TXtC6yHyOG1GjjThpSIH3RxfzYqkSGO xCTbu3TYaqXKEFl5GHFZzHa8/F8tHylMnaEuA3DXi/Ohs/wmCO9EFO6g+VJG2Rqq nb0kKb2Qf622CvXH/uAMOLjBggg7PbnsxvvMzWUJg/lhVpzkq3jZv00lnWxjRdTo 7vJ9dv00axQZIjYSIEwQiQGA7o1u24x9IR6s1xo0dWYrDNfEZW5gNTbYuCK/XWFz fZNDjMHKP/OoBQixKCnd46TQimWXKvu50w9FhzNHjZHpZXQ7LEUaGBNeMPo6qkZu ZBM07Oyo+18H7us6czoul6RMPFIUyIVA1ZHWgkqCrT+B/Hpc63ItS8INyckpMSLc RiKi14uhqS/UVx0L =aqzT -----END PGP SIGNATURE----- --=-=-=--