From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8EtJAnH5bmGtcAAAgWs5BA (envelope-from ) for ; Tue, 19 Oct 2021 18:59:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WLGFOXD5bmEAIAAAB5/wlQ (envelope-from ) for ; Tue, 19 Oct 2021 16:59:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 90C212C7C1 for ; Tue, 19 Oct 2021 18:59:28 +0200 (CEST) Received: from localhost ([::1]:38230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcsSV-0000Do-9B for larch@yhetil.org; Tue, 19 Oct 2021 12:59:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcrF2-0006Gm-Fp for guix-devel@gnu.org; Tue, 19 Oct 2021 11:41:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57068) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcrF0-0006vu-OW; Tue, 19 Oct 2021 11:41:27 -0400 Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54032 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcrF0-0006c0-Do; Tue, 19 Oct 2021 11:41:26 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Incentives for review References: <874k9if7am.fsf@inria.fr> <86ee8hfm1k.fsf@gmail.com> <87sfwx896z.fsf@inria.fr> <86k0i9drh5.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?utf-8?Q?Vend=C3=A9miaire?= an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 19 Oct 2021 17:41:23 +0200 In-Reply-To: <86k0i9drh5.fsf@gmail.com> (zimoun's message of "Tue, 19 Oct 2021 16:22:30 +0200") Message-ID: <87mtn56mzg.fsf_-_@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634662768; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=gKaw0OHMA/chzY5DcIejtHa+9o/BL4tlS5QFmpq/W1w=; b=RIihF38NhFpUI5T2ZC/3lCn6EYVq/L4/KemOKwYAatZ/qGnHsghH8KUaHTssNtn9YaaR3J 8G7o5as/+7bOBXm1TJEppm+CD3AtE3wc9QtucQfiB0RoCgEs6luk1w446chVs5A9ythbQU QgwmzWVw9dDHx+5jo82OiN0S88ts1UXkOTP2gHUQ3yCPqRGAj0f/ogsq57uyM7z43mvfO4 gFpc7Hn0MGVokY6mJ9CnF8n6d4tWwLbozUIx+noxUH2AqMoKOlpIDzCHeZ941vK/muAYdn HQiniLuEp+1kRGgDokkoYe2HJzOLqifZK4qNPnKaGnZdJfvMCLelu+2MKCxc5Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634662768; a=rsa-sha256; cv=none; b=SAuUoc2FAcmA9MwnfWULmCEUXhdZVJpOqSs0NFAQCp1/KKpK/AVmfqtWY64dMMNwWjwTJG k2Dl4W4mT6WYr5jKjsF5y6HGh9Lr4a66Z4yZ2NMURz6aLLTwaxOsCEJYxk7BbJboOqQidU fEVYUSnGk+adKXph1JgONwfzrSo4w8sxIlTMrN+IAIRgVwAdfEIzfZ/PDmia5KHX+wD/jL EHmTOV8nmIMlBRuSooN1s2OVsPShnaWXBeTU0Y7CJrZpzfjoLZQTPu2HqmdOsQGZrcWPU2 AwOl2WjeoIHybdlNMboYILv/unAs5OSGXCsl+XZzkCqBiTHR/bo9MQPyVk2qIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.53 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 90C212C7C1 X-Spam-Score: -3.53 X-Migadu-Scanner: scn1.migadu.com X-TUID: R95+LemGLHXC zimoun skribis: > On Tue, 19 Oct 2021 at 14:56, Ludovic Court=C3=A8s wrote: [...] > One question is =E2=80=9Cencouragement=E2=80=9D for reviewing, somehow. = Asking for new > package additions to go via guix-patches is a call making kind of > equality between contributors. As someone without commit access, I can > tell you that it is often demotivating to send a trivial addition, wait > forever, ping people (aside I know who I have to ping :-)). Usually, it > means people are busy elsewhere, so I try to help to reduce the workload > by reviewing stuff or by doing bug triage. However, in the same time, I > see committers push their own trivial additions. It appears to me > =E2=80=9Cunfair=E2=80=9D. I understand and sympathize (I also see us slipping off-topic :-)). > Why are committer=E2=80=99s trivial additions more =E2=80=9Curgent=E2=80= =9D than mine? Yeah, I see what you mean. I would like to see us committers do more review work. But I also view things from a different angle: everyone contributes in their own way, and each contribution is a gift. We can insist on community expectations (reviewing other people=E2=80=99s work), but we should also we= lcome contributions as they come. There=E2=80=99s a balance to be found between no formal commitment on behal= f of committers, and a strict and codified commitment similar to what is required for participation in the distros list=C2=B9. A good middle ground may be to provide incentives for review. How? I=E2= =80=99m not sure exactly, but first by making it clear that review is makes the project move forward and is invaluable. You once proposed having =E2=80=98Reviewed-By=E2=80=99 tags to acknowledge non-committer reviews, an= d I think that would be one step in that direction. Perhaps there are other things we could do? [...] >> I think it=E2=80=99s about finding the right balance to be reasonably ef= ficient >> while not compromising on quality. > > I totally agree. And I do not see nor understand where is the > inefficiency here when asking to go via guix-patches and wait two weeks > for adding a new package. It=E2=80=99s not about urgency but rather about not contributing to the gro= wth of our patch backlog, which is a real problem. Thanks, Ludo=E2=80=99. =C2=B9 https://oss-security.openwall.org/wiki/mailing-lists/distros