From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GDbuMRvjlGHvPQEAgWs5BA (envelope-from ) for ; Wed, 17 Nov 2021 12:10:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kLTELRvjlGFbHQAAB5/wlQ (envelope-from ) for ; Wed, 17 Nov 2021 11:10:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7DD869553 for ; Wed, 17 Nov 2021 12:10:19 +0100 (CET) Received: from localhost ([::1]:33130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnIpW-0000si-Nq for larch@yhetil.org; Wed, 17 Nov 2021 06:10:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnIpG-0000sB-Al for guix-patches@gnu.org; Wed, 17 Nov 2021 06:10:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48766) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnIpG-00075m-21 for guix-patches@gnu.org; Wed, 17 Nov 2021 06:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnIpF-00020n-RB for guix-patches@gnu.org; Wed, 17 Nov 2021 06:10:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51914] Acknowledgement ([PATCH 0/2] Fix asdf-build-system on non-package inputs) Resent-From: Guillaume Le Vaillant Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 Nov 2021 11:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51914 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Neidhardt Cc: 51914@debbugs.gnu.org Received: via spool by 51914-submit@debbugs.gnu.org id=B51914.16371473987717 (code B ref 51914); Wed, 17 Nov 2021 11:10:01 +0000 Received: (at 51914) by debbugs.gnu.org; 17 Nov 2021 11:09:58 +0000 Received: from localhost ([127.0.0.1]:60312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnIpC-00020O-GQ for submit@debbugs.gnu.org; Wed, 17 Nov 2021 06:09:58 -0500 Received: from mout02.posteo.de ([185.67.36.66]:54369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnIp8-000204-9f for 51914@debbugs.gnu.org; Wed, 17 Nov 2021 06:09:58 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id B529F240105 for <51914@debbugs.gnu.org>; Wed, 17 Nov 2021 12:09:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1637147387; bh=DH9svi9gmXrEmkFyxPsE8wlpYCKrqclFfOBJUZwQH4U=; h=From:To:Cc:Subject:Date:From; b=O4ZC0QBmU+lQq9udoe9T7ATv4mSeC2rruVdZqEdSo778+rsSiSYZaOAbgpgPdarSh rY024F0VIhZc/NsNThe/SGa0Hv+gB4URQQAgm7GIx47CuAEkXR9oRcN5qvMF3ruufR GWNUWj478Oe52NWkzn6hEw4nwtaNBBtvscJ51LozhlsNccQB1qsEwCun34vR3wAvjG dDGSK1O34PSN8dHoY+OlG6nkv08asOfNEW+Yf5nHPrr1s5O1fIW9ILIGaXXwyJO6mx QKKmo8prLbFePxX/kjlGc6UW/c7hMF5tr5gxph1S6XHi1XJVOoVYzrGr+5ss+7hXR7 lxOFz2NXpHuZA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HvKvZ57PJz6tmW; Wed, 17 Nov 2021 12:09:46 +0100 (CET) References: <20211117082905.29499-1-mail@ambrevar.xyz> <87ilwrrxb1.fsf@ambrevar.xyz> From: Guillaume Le Vaillant Date: Wed, 17 Nov 2021 10:56:35 +0000 In-reply-to: <87ilwrrxb1.fsf@ambrevar.xyz> Message-ID: <87mtm3ujgm.fsf@kitej> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637147419; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=X1UsIouBsayEd4VlDI7x3OVmdJFMkU5LFhDdgHp+Wuk=; b=t2AjorDq5+sfsfaWsCRabFIDnaYDeUDgX6AkUrqJHNolBljvuswwLUhAGjzMSx0E1s+NQl OEtaFqtY2nQykoYrcZkN97NLcOew1CGhD+aNMHFACvLZ44igEMJWDmMc4coWgyWhscO7Gb kKM7oq5mF1evFe2akCcelK5Kwpw6gK1ePHAn7SjIdqgB/fZyGVWfAUfjCvo9zthsBJ0Jcq 4kBqmRNvTlT6xDgNCSmmFoNh6yUi4Jw2d51MjQDQPu4IvmpSaRUvHJidegbPcWmcr5qYxa L5z5ljNtwpKrz3MTgue/6gHv/EWl71wfajgmmlptTiGOlmwbz3OZPZcbVH/Eng== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637147419; a=rsa-sha256; cv=none; b=ltz9evtqbNl91Uwe8hoHw6KYASq5qGJlNKbda6J5H1WLXw43/h5M1oYK+xquOhqH2euwty 0ZSu4Io7LIvJIM6Ei7ZJviHKfRNd45nwtHBv29yGQ4PSPtXfZ0zgvAK83bcHVzfSMb+Vk+ r2bL6BV4kJ6WcpImtSmjOIZMkXIkU5b1TGKL5oSF+Sg3vYLGSQLdy0adl871Zne7JufQv4 Tjhw/KpZZiwBkFiJIH9QiO51WiPGlv7n2bH2RvFALMF5+XHWm77m6tBnswnzEmIZAKEIBY FVBBR15XvZW4T0gSc/TnNALCofyyWGoTAQmyV7nfF21NXOD1BN3rgEZvcuVF8g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=O4ZC0QBm; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.15 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=O4ZC0QBm; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7DD869553 X-Spam-Score: -3.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: g8/QXDX7sfg6 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Pierre Neidhardt skribis: > diff --git a/guix/build-system/asdf.scm b/guix/build-system/asdf.scm > index b4e40ee8c2..538812d620 100644 > --- a/guix/build-system/asdf.scm > +++ b/guix/build-system/asdf.scm > @@ -162,7 +162,8 @@ (define (transform-package-name name) > name)) >=20=20 > (define (has-from-build-system? pkg) > - (eq? from-build-system (package-build-system pkg))) > + (when (package? pkg) > + (eq? from-build-system (package-build-system pkg)))) >=20=20 > (define (find-input-package pkg) > (let* ((name (package-name pkg)) Maybe use "(and (package? pkg) (eq? ...))" instead of "(when ...)" so that the function returns #f instead of returning nothing when pkg is not a package. Otherwise LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYZTi+Q8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j92/gEApZgmKXtFWdHrwvMCvyZyx1CaNQIIH0r1g4pj B70uQkIA/1jNfHC4JLiHszRO2nCSOX2V/saeQYTdajZN6UAo1u/n =3FTN -----END PGP SIGNATURE----- --=-=-=--