From: Guillaume Le Vaillant <glv@posteo.net>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 51914@debbugs.gnu.org
Subject: [bug#51914] Acknowledgement ([PATCH 0/2] Fix asdf-build-system on non-package inputs)
Date: Wed, 17 Nov 2021 10:56:35 +0000 [thread overview]
Message-ID: <87mtm3ujgm.fsf@kitej> (raw)
In-Reply-To: <87ilwrrxb1.fsf@ambrevar.xyz>
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
Pierre Neidhardt <mail@ambrevar.xyz> skribis:
> diff --git a/guix/build-system/asdf.scm b/guix/build-system/asdf.scm
> index b4e40ee8c2..538812d620 100644
> --- a/guix/build-system/asdf.scm
> +++ b/guix/build-system/asdf.scm
> @@ -162,7 +162,8 @@ (define (transform-package-name name)
> name))
>
> (define (has-from-build-system? pkg)
> - (eq? from-build-system (package-build-system pkg)))
> + (when (package? pkg)
> + (eq? from-build-system (package-build-system pkg))))
>
> (define (find-input-package pkg)
> (let* ((name (package-name pkg))
Maybe use "(and (package? pkg) (eq? ...))" instead of "(when ...)" so
that the function returns #f instead of returning nothing when pkg is
not a package.
Otherwise LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2021-11-17 11:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 8:29 [bug#51914] [PATCH 0/2] Fix asdf-build-system on non-package inputs Pierre Neidhardt
2021-11-17 8:33 ` [bug#51914] [PATCH 1/2] build-system/asdf: Don't fail in sbcl-package->cl-source-package " Pierre Neidhardt
[not found] ` <handler.51914.B.16371377731213.ack@debbugs.gnu.org>
2021-11-17 8:38 ` [bug#51914] Acknowledgement ([PATCH 0/2] Fix asdf-build-system on non-package inputs) Pierre Neidhardt
2021-11-17 9:01 ` Pierre Neidhardt
2021-11-17 10:36 ` zimoun
2021-11-17 10:56 ` Guillaume Le Vaillant [this message]
2021-11-17 12:40 ` Pierre Neidhardt
2021-11-18 7:57 ` Pierre Neidhardt
2021-11-18 10:06 ` Guillaume Le Vaillant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtm3ujgm.fsf@kitej \
--to=glv@posteo.net \
--cc=51914@debbugs.gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.