From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yG9MA6CdAWL4fAAAgWs5BA (envelope-from ) for ; Mon, 07 Feb 2022 23:30:56 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8H6LAKCdAWINBAEA9RJhRA (envelope-from ) for ; Mon, 07 Feb 2022 23:30:56 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A7B2F29799 for ; Mon, 7 Feb 2022 23:30:53 +0100 (CET) Received: from localhost ([::1]:56016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHCX6-0007Cx-2V for larch@yhetil.org; Mon, 07 Feb 2022 17:30:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHCWL-0007CP-SQ for guix-patches@gnu.org; Mon, 07 Feb 2022 17:30:13 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHCWI-0003uN-S1 for guix-patches@gnu.org; Mon, 07 Feb 2022 17:30:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHCWI-0005ly-Lm for guix-patches@gnu.org; Mon, 07 Feb 2022 17:30:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53676] [PATCH 0/5] *** PulseAudio service improvements *** Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Feb 2022 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53676 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill Cc: 53676@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 53676-submit@debbugs.gnu.org id=B53676.164427298622144 (code B ref 53676); Mon, 07 Feb 2022 22:30:02 +0000 Received: (at 53676) by debbugs.gnu.org; 7 Feb 2022 22:29:46 +0000 Received: from localhost ([127.0.0.1]:44035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHCW1-0005l5-JC for submit@debbugs.gnu.org; Mon, 07 Feb 2022 17:29:45 -0500 Received: from mail-qt1-f170.google.com ([209.85.160.170]:33291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHCVx-0005kq-BU for 53676@debbugs.gnu.org; Mon, 07 Feb 2022 17:29:44 -0500 Received: by mail-qt1-f170.google.com with SMTP id p14so13351907qtx.0 for <53676@debbugs.gnu.org>; Mon, 07 Feb 2022 14:29:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=g+WuRMSrw+7x4gBdTdIddoQ4T/rY2WgSpVQT9K8SYlM=; b=Eq3RzJox31ZOJFCmBewgjn42Kh5H5WuHWY2/BT+CCt0pdukKkZfrzDwqZHc/NldJA3 cCTvMq2Lzg0eZpXPrkcn2rR0MTuX0KPhcHuVKSq+LzCbDY69xcExST/GZ6RdVcjfDx6e wAqDzQ4hkvU7ZwZsxUjKx9/1kJohwpfX6l23ivwf6VUXq86WG+8iFXVpR6N8WRvHQrYR B6FbRc3VMcQdBTohT0LHA6b69l6ejeLOad1WsD0gc/z1ZQ/zWIl/A7b18juaw/DDUKZf KHT7TMSooE7iNKRcsSfqR6kjQdfWGbn/DvYIvzipsp1Vo1rFtyq3Q0ZpwzzT+36xy7ug i21Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=g+WuRMSrw+7x4gBdTdIddoQ4T/rY2WgSpVQT9K8SYlM=; b=72pHrciJuYC1ugGSmTeBkzp1WpSId1e5WXtyUfN6OWfCF+IpftaehhgCdWdC1XU5pw enTuYy0uA5uZjGkr5hg2ipB0yWuhDHAy/SCYQE9DGLYB84wnywCpWgtMUchhufeGb4HQ l6plMge40Ma4AjCQnz3/iAiIrhDEkbglbEXnNB+wlpdVtUKG4iXf5FGp77buQ5keXWUf Cvzw1I0AN3QjdxHsi5WsF5QvlDVUbHrSgAtEo6+cd8WUqBTtPwwtmDx1Ts10ybR70bg1 LAu6vKdZPixI17SF0WqQXfMfZ5mas6HVUYD7mrdB5JW00R31bVyV3YLZqia/RnyiBPqX ENdA== X-Gm-Message-State: AOAM532XW/RhcqsjI/y+OSOG6dXeVZyzLQTW4A9dn34J6rDI2b7u3mWC Scjx6RpTHTu51EJtV2u68L1PkrHrhdI= X-Google-Smtp-Source: ABdhPJx2TEjaLHIGsoRVK8FSb024yk61rbGGhuLW20TJwWHfSEqlgq867LATcWNwdZiEeZAjI8oMhQ== X-Received: by 2002:ac8:5b91:: with SMTP id a17mr1260491qta.570.1644272975427; Mon, 07 Feb 2022 14:29:35 -0800 (PST) Received: from hurd (dsl-154-179.b2b2c.ca. [66.158.154.179]) by smtp.gmail.com with ESMTPSA id x13sm6307586qko.114.2022.02.07.14.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 14:29:34 -0800 (PST) From: Maxim Cournoyer References: <20220201041933.16603-1-maxim.cournoyer@gmail.com> <20220201041933.16603-5-maxim.cournoyer@gmail.com> Date: Mon, 07 Feb 2022 17:29:33 -0500 In-Reply-To: (Jack Hill's message of "Wed, 2 Feb 2022 17:43:21 -0500 (EST)") Message-ID: <87mtj2z4xe.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644273053; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=g+WuRMSrw+7x4gBdTdIddoQ4T/rY2WgSpVQT9K8SYlM=; b=doJGaCfo/diqx3w+zYrnFIdn3kp6H8vNB/CEXyv8guR/f2Dx2hRHTc4DsaItANQm/bkRN7 k/Z6EGQYREDlg3ox0K4dpI6GXjM4AhH1KD6AsHnbRpJXfbernPKz0xJdSo6mHzmHfbbvjw VYEafP+Wg5XxHRBwLtqH7ePlk3gHJEZ8W7ZkxzENmiRx4CIFsbJxpgGYcN4NwHVaJQLIRZ nL5izpAa/1xSW2da8y/Pf/lTP4drA7iCvYBSwq3WG4Hsdspz/EdI7LufU5PgpMzNc/R8kt F/2044fZRfmHbloWEbkrVoWiibxox3wsjspCH9DdNYEnVO43oVWn+/wfiBRxgQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644273053; a=rsa-sha256; cv=none; b=j39J1VatnWMOIiqfzTmF8UI87lbR8+9CYJy6jdN6zWMuQp8OO/QnLIWZLab4ncIb1Hgs/x ooyVtJz0ojOYTMxS1/2dB9n0yROtoKn6wJVBApAAul0e7HzbBjsVJtzZEZq4FLTBIHkXxH VN9Jqd9R9DwmEjrYxoPtNLvwKm1JugnpfXUPjEUS2S8EQzuktkIK7ns2pSIBSEA28P/4vv +iLRVMw+sIUkXqmzZxS0hZa8oedp+bQmQm1iu2pBXRLEhrXUFQzJ8O1oevUgMz05xLlw+u bKxdUuVUBAPRhsUhEBPunbXJWGOZTcp4NrLpF/4hpgyxzEXdx+zP/5rbiXFDqg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Eq3RzJox; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Eq3RzJox; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A7B2F29799 X-Spam-Score: -2.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: /aEslbJXnvtr Hi Jack, Jack Hill writes: > On Tue, 1 Feb 2022, Liliana Marie Prikler wrote: > >> Hi, >> >> Am Montag, dem 31.01.2022 um 23:19 -0500 schrieb Maxim Cournoyer: >>> * gnu/services/sound.scm (pulseaudio-environment) >>> [PULSE_CONFIG, PULSE_CLIENTCONFIG]: Use fix locations, and move logic >>> to... >>> (pulseaudio-etc): ... this service extension.=C2=A0 Guard against produ= cing >>> empty files. >> >> This patch reproduces (more or less) the initial layout we had for >> pulseaudio-service-type. =C2=A0However, that layout has been reported to= not >> work with some sandboxes. I tried tracking down a specific bug, but >> could only gather . >> >>> Due to a bug with webkit sandboxing, we no longer put daemon.conf >>> into /etc/pulse (my bad), but rather set PULSE_CONFIG to directly >>> point to it. >> >> In other words, we should check whether Epiphany still plays sound >> properly with this patch applied. >> >> Cheers > > I reported the original bugs for this in Guix [0] and WebKitGTK [1], > so it was easy for me to find the references; hope they help! > Unfortunately, it doesn't look like the WebKitGTK bug has been fixed > (probably waiting on a C++ hacker). Note that the symptom I saw wasn't > just that sound didn't work, but that the sandboxed processes crashed, > so no web content was rendered. > > [0] https://issues.guix.gnu.org/40837 > [1] https://bugs.webkit.org/show_bug.cgi?id=3D211131 > > Unfortunately, I haven't had time to test this series. Thanks for this! I wasn't aware of the history; I tried it and it failed the same. The following fix I attempted in webkitgtk did not seem to do anything: --8<---------------cut here---------------start------------->8--- modified Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include @@ -337,7 +338,16 @@ static void bindIfExists(Vector& args, const = char* path, BindFlags bind bindType =3D "--ro-bind-try"; else bindType =3D "--bind-try"; - args.appendVector(Vector({ bindType, path, path })); + + // Canonicalize the source path, otherwise a symbolic link could + // point to a location outside of the namespace. + char canonicalPath[PATH_MAX]; + if (!realpath(path, canonicalPath)) { + if (strlen(path) + 1 > PATH_MAX) + return; // too long of a path + strcpy(path, canonicalPath); // no-op + } + args.appendVector(Vector({ bindType, canonicalPath, path })); } =20 static void bindDBusSession(Vector& args, XDGDBusProxyLauncher& p= roxy) --8<---------------cut here---------------end--------------->8--- Thanks, Maxim