From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4K6KHTJApGIrEgAAbAwnHQ (envelope-from ) for ; Sat, 11 Jun 2022 09:11:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iOCSHTJApGLWXQAA9RJhRA (envelope-from ) for ; Sat, 11 Jun 2022 09:11:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 876172F853 for ; Sat, 11 Jun 2022 09:11:45 +0200 (CEST) Received: from localhost ([::1]:35226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzvHa-00062i-Eg for larch@yhetil.org; Sat, 11 Jun 2022 03:11:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzvFy-00062T-V9 for guix-patches@gnu.org; Sat, 11 Jun 2022 03:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzvFy-0003K3-MU for guix-patches@gnu.org; Sat, 11 Jun 2022 03:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzvFy-0001zg-BX for guix-patches@gnu.org; Sat, 11 Jun 2022 03:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55891] [PATCH] gnu: Add iec16022 Resent-From: Remco van 't Veer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 11 Jun 2022 07:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55891 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55891@debbugs.gnu.org Received: via spool by 55891-submit@debbugs.gnu.org id=B55891.16549313857633 (code B ref 55891); Sat, 11 Jun 2022 07:10:02 +0000 Received: (at 55891) by debbugs.gnu.org; 11 Jun 2022 07:09:45 +0000 Received: from localhost ([127.0.0.1]:51769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzvFh-0001z3-Ir for submit@debbugs.gnu.org; Sat, 11 Jun 2022 03:09:45 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:50619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzvFe-0001yn-NV for 55891@debbugs.gnu.org; Sat, 11 Jun 2022 03:09:43 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6A4CA5C010E; Sat, 11 Jun 2022 03:09:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 11 Jun 2022 03:09:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1654931377; x= 1655017777; bh=huBRyexz3BDfvtH5UBbSem4btvmCQC+H/CRsjSb59bY=; b=M FF8MuQC21UH9z7I9we/XGFD1p4q5M2XwOIG7ZCyQssCtjLg8cI/jhyD5y79eqj88 LpyuIhTkY7ExNi3OZUNom47uD31QPOinhyxJ453RbANpa0ROF+jJixcVBRWTJeID lcyL0UPhuGkEaumMdqQKgRdpqErBLfB5ry7gyDEx0AbES+wphy6bdnqYkXfouUY1 s1MAbb13F0VxNXqIbXT8iiDzu3IFu5k0iiuJ5G6PmqJJsDBciw8dnNWVqOAWZN+a 2qUGX5WUFl6kzzXH3EK8Gy3qKlZOfxQusUAi//+fKx7bCcINR3CbPYnh29LdhESx K3KmdNT3tFQG2trpm4dtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1654931377; x= 1655017777; bh=huBRyexz3BDfvtH5UBbSem4btvmCQC+H/CRsjSb59bY=; b=l gnzcT+6S787gZZjEhZrRBBNRCcYrdcCcjh1d6Ee9e/guXa0MlQ5lg7IOFFt3w13p b6ZadLkDJGnxmsSgX82vuaAyqVc56iQDFayHN/W4khbICDAiu8OTS/RWRTDQRlvx EFDRT334lYd6feR78sig7Fqc1rqgO8LBpGRLy3JAnzYDrjyT/elv6CJUN+WtZ63+ lnrk6wn53QJGMQX7OK27lhnEBHS/Txkqqli/Ijw4/k/9EEJSLyOJ11+vpkyXNAl3 Vl/4gP2Heaa51vXb/hVgXqnyoow1BI92jIpKdtJMN7PnU7cu6/90dpzDF+Gx4XY4 fkEn0QyywXUzrGVHdOxCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudduvddgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufgjfffkgggtgfesthhqredttderjeenucfhrhhomheptfgv mhgtohcuvhgrnhcukdhtucggvggvrhcuoehrvghmtghosehrvghmfihorhhkshdrnhgvth eqnecuggftrfgrthhtvghrnhepudfhgfevueegvdfgvdffieduheffuedtfefhffegvdek ieduieevtddtudejkeeunecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvghmtghosehrvghm fihorhhkshdrnhgvth X-ME-Proxy: Feedback-ID: i568842cc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 11 Jun 2022 03:09:36 -0400 (EDT) References: <20220610150448.9513-1-remco@remworks.net> <2dfe4787038a3c9b6fe21982aea621c4447eca75.camel@telenet.be> <877d5opgd4.fsf@remworks.net> User-agent: mu4e 1.6.11; emacs 28.1 From: Remco van 't Veer In-reply-to: Date: Sat, 11 Jun 2022 09:09:34 +0200 Message-ID: <87mtejhe1d.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654931506; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=huBRyexz3BDfvtH5UBbSem4btvmCQC+H/CRsjSb59bY=; b=H2aTGMk3Wx1KU1GiU4to8iT001v58FNwc/9Of4IwDWirtXHNLz86dkRGgHI2xW1+3+o9EE vrgjySvNSXT6ot4fzsWCD8mS20dFDnutyN1g/lpxR1Ct8L3GiyCu3DNhzwNxb8yvIbbwxd N3O2olmryqYifAHOVDdfxQhhIyIbmo7/weYaQMBRHG06klBZK3m5HFlTrU+p8hxy5C6VXB 3dcFEVYF3M4dICNn9rF2M+XMLQQNGCGr64WIbtATx+5+P6pNofYlWzxgWfO+CADqK+6z/z uUn8VnkPOoKgS+8Dz/KzqUlWZOlDbDvKKsQKLMegcRWPeE9KE4jwWNc5eSAFKw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654931506; a=rsa-sha256; cv=none; b=aEObwreNdvKcN3wuPDiCWmADpCmVoFDODCXGZaHEYofDpS7kfXFPJY0Z65ZWfuJdpSwnKA l1aDGTjm2ya4SYD6PfIZHO71/fp6KhLEHZuo+PvYMzqFb4cfvVfZLbshcHWokL4LtYhVT6 IYOvc4hnl1TXheDjG+2+ZUOKKnX+d67E406gqhh4/dnlVThYehbncOkvuIRQTYQCc6D0P4 FpVejc+9GDJYulvPe3bMsQFpFTm/kKLeoguKLQPEM+69dMll2p7S5xI4/6GwqKdvtKB37l pAx/3YbCZg3fUjKB67DHtU8LJYzM05jAN7Lm4EqcT7EAhrqaHm3EIcyhA66KPA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=remworks.net header.s=fm1 header.b="M FF8MuQ"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="l gnzcT+"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=remworks.net header.s=fm1 header.b="M FF8MuQ"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="l gnzcT+"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 876172F853 X-Spam-Score: -0.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: foi0OJbDTjuv 2022/06/10 23:47, Maxime Devos: > Remco van 't Veer schreef op vr 10-06-2022 om 19:39 [+0200]: >> > Contains a bug: on line >> > >> > https://github.com/rdoeffinger/iec16022/blob/c9a9fd926fd1e6cca9782fe3f= 8c2bab66010ca51/image.c#L284 >> > >> > , it allocates a buffer, which can fail (by returning NULL). >> > It then passes the possibly NULL buffer to compress2. >> > Also, it writes files without checking for errors >> > (e.g. EIO, ENOSPC or EDQUOT). >> >> Good catch!=C2=A0 I'll need to brush up on my C skills to fix these. >> Meanwhile I'd like to ship including bugs, WDYT? > > I think it's ok, _if_ the bugs are eventually at least reported > upstream if we (i.e., you) cannot fix them timely (needs some contrived > circumstances to trigger the bug). https://github.com/rdoeffinger/iec16022/pull/17