From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8C/sNB4yxGL83wAAbAwnHQ (envelope-from ) for ; Tue, 05 Jul 2022 14:44:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gIawNB4yxGJ7ewAAauVa8A (envelope-from ) for ; Tue, 05 Jul 2022 14:44:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3773BFAB9 for ; Tue, 5 Jul 2022 14:44:14 +0200 (CEST) Received: from localhost ([::1]:44082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8huX-0001nD-3B for larch@yhetil.org; Tue, 05 Jul 2022 08:44:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8huN-0001n5-CX for guix-patches@gnu.org; Tue, 05 Jul 2022 08:44:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8huM-00031t-9L for guix-patches@gnu.org; Tue, 05 Jul 2022 08:44:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8huM-0003km-1S for guix-patches@gnu.org; Tue, 05 Jul 2022 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56257] [PATCH] fenics: Do not use mpirun for tests References: <87bkuefiwu.fsf@dlr.de> In-Reply-To: <87bkuefiwu.fsf@dlr.de> Resent-From: "Paul A. Patience" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Jul 2022 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56257 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56257@debbugs.gnu.org Received: via spool by 56257-submit@debbugs.gnu.org id=B56257.165702500714369 (code B ref 56257); Tue, 05 Jul 2022 12:44:02 +0000 Received: (at 56257) by debbugs.gnu.org; 5 Jul 2022 12:43:27 +0000 Received: from localhost ([127.0.0.1]:49623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8htm-0003jg-V3 for submit@debbugs.gnu.org; Tue, 05 Jul 2022 08:43:27 -0400 Received: from mail-40136.proton.ch ([185.70.40.136]:32161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8htk-0003jP-2Q for 56257@debbugs.gnu.org; Tue, 05 Jul 2022 08:43:26 -0400 Date: Tue, 05 Jul 2022 12:43:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apatience.com; s=protonmail2; t=1657024996; x=1657284196; bh=Kh7C5mMhKtLzvLV4zqYMcnEaTv6dwgSmCXIxV2sodes=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=oIyZkDcScEQo5QcBl9MjhGmDtPBszPZFWn4yAYMsjFEEAXFmZglTj0F6lB5rP0lid 3yrspn7tQ0tJOLy1O+5CT27bcDCrdN/lb99MjIbnTIL9+ZFM0RKDRzR4qv2w1XjOrZ OKbfTegNfaYRzD5wCQvl1L1A+Sh9CxtIfW88+5dd7hQoYM6YwDdYkh2hvEL48NkjSB MFG5fgg9um+aYGfvVUoRc+2A7kVDw7rcCsBFJPYSmCgRogqukMDJyg8zI6XAOe208M 4pRkeIh+H7GzYSJ3QZJ6odLdrLYwp4fOnDwc4gbDzeigEd6Bfh3a75SxqaS1RnUk4o fqp/8wmicPbeA== From: "Paul A. Patience" Message-ID: <87mtdnu4af.fsf@apatience.com> Feedback-ID: 19227857:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "Paul A. Patience" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657025054; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Kh7C5mMhKtLzvLV4zqYMcnEaTv6dwgSmCXIxV2sodes=; b=mVviZ+SMcj82J4HYRwp8s8U0LMg/60iV+qgKAjdwtt+TahIYe8xqcZpjrPXP6kLAHBG1GB N9cSCRIuiy+HG3Pq/TUNM/lg263ckqSuDizi+CLeVJ1gt4WU60slW8Bh1ilPswUT3o3jev NISteX9/vjA3SYos9S1pSVwNvC0qTj18Lkx0nWjG2H817c/JjMah7Ua1cUafXLBDVlnKd0 ximQW+Xw4wn64uj/WkLLLw31D5uwseiWesKw3OAjH5iibk5OG/NGQlx3nmoc3oDYHDh1ZJ Pvor6HPI5tsxHKNMSOGyA87hEhn9Jt0kb/fVPFTunVZW0AZUgk7JAMEZ/7H/GQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657025054; a=rsa-sha256; cv=none; b=N59cwC2LQ4RUf8z1Ifl9bxTAeNdxvxuXRuFpcS9jRmPDwsYNUQ0l2f5bfuywr0m2RSFVaC PHf9HWXwK3ankL0hiY94i+jmJGjNK/SWIinvejWJQgWStO8fpYJu64DJMDo0UG6va6iIvH 7iwEsd8Kn7eZRZw0UB7wXRZT5basgCHEDnEImUI4NAbdjGaYiJK7eP86Ima5YfWrdCK1MW ffBHmM8BSxW9oqZoa9CIC2Ul2Uk8RUIvDncpmYlj+aL2otw3Xp1pxj5TdSSOq/iv7KgiBv bC0xY3MrFeA09plz7zYNQB2o2PcXdIiwBGS38g3RwjQGHC730u4VYPblPQ73fg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=apatience.com header.s=protonmail2 header.b=oIyZkDcS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.65 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=apatience.com header.s=protonmail2 header.b=oIyZkDcS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3773BFAB9 X-Spam-Score: -3.65 X-Migadu-Scanner: scn1.migadu.com X-TUID: wn5hPhjEeVCr Hi, Ludovic Court=C3=A8s writes: > Good question. Paul, do you remember the reasons for doing so? If I'm the Paul you're referring to, it would be better to CC me in the future, as I'm not subscribed to the list and only intermittently check it (which happens more often when I'm submitting patches). >> Anyhow, in the attached patch, the tests are executed directly using >> pytest. This prevents the tests from getting stuck and subsequently I >> discovered a failure in XDMF tests. With this test also disabled, the >> package builds fine for me. > > Let=E2=80=99s see what Paul thinks, and otherwise I=E2=80=99ll apply the = patch shortly > so fenics can be installed again. Actually, I'm not the original author of the fenics package; I just added support for #:tests? (and fixed the sanity check), so I don't know why the tests are run with mpirun. However, the reason I had added support for the #:tests? flag is to skip the fenics tests, which were failing for me. I'm no expert in MPI and pytest, but it does seem that pytest_mpi [1] is recommended when combining the two, and there are no instances of @pytest.mark.mpi in the fenics repository. Further, running pytest tests under MPI is accomplished with [2]: mpirun -n 2 python -m pytest --with-mpi In other words, it seems as if the current tests are repeated in parallel, as Ontje discovered. The patch looks good to me. Best regards, Paul [1]: https://pypi.org/project/pytest-mpi/ [2]: https://pytest-mpi.readthedocs.io/en/latest/usage.html