From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oHWBO8s8wWPmrAAAbAwnHQ (envelope-from ) for ; Fri, 13 Jan 2023 12:13:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2AyKO8s8wWMhdgAA9RJhRA (envelope-from ) for ; Fri, 13 Jan 2023 12:13:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B437A6E2A for ; Fri, 13 Jan 2023 12:13:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGHzd-0007BB-KO; Fri, 13 Jan 2023 06:13:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGHzb-0007Ax-Lk for guix-patches@gnu.org; Fri, 13 Jan 2023 06:13:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGHza-0006MA-SC for guix-patches@gnu.org; Fri, 13 Jan 2023 06:13:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pGHza-0007yl-FA for guix-patches@gnu.org; Fri, 13 Jan 2023 06:13:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60629] [PATCH 0/3] Add '--with-version' package transformation Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 13 Jan 2023 11:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60629 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: 60629@debbugs.gnu.org, h.goebel@crazy-compilers.com Received: via spool by 60629-submit@debbugs.gnu.org id=B60629.167360836530647 (code B ref 60629); Fri, 13 Jan 2023 11:13:02 +0000 Received: (at 60629) by debbugs.gnu.org; 13 Jan 2023 11:12:45 +0000 Received: from localhost ([127.0.0.1]:49727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGHzI-0007yE-IG for submit@debbugs.gnu.org; Fri, 13 Jan 2023 06:12:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGHzE-0007xz-F6 for 60629@debbugs.gnu.org; Fri, 13 Jan 2023 06:12:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGHz7-0006II-Pr; Fri, 13 Jan 2023 06:12:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=e8LkjbloKWVAiiLYpLhV2Nqj8d3ciHZXgMJ63bn4r5c=; b=m8SwcKL6gK3hyRhHTD00 QB6hsijkdWQGXwmrg50LRc52p1ATmz+moU+mIJGAgh39i+VNa5kEc9rPz2td9c9XglDtTGA0RZWRI aF81uOc73gdH71qsvEQQPDXk9xRewRkGlh2wdE5ZPglWB9sZdwgd6Liv6antyWpFNGhdA4UKBizZA mlAOU1fgXAbh62mK0xwD/z+mUzY8C+Ua6rs2k/9U/huXU51UqBxflOog9cfZdnOUDdvdmWlvc0Aja ZuTopeAAP2GxFKHHVVBCLO1uON+ewc90+70F1Es4vJCuk9PXcg2o/Nsbe8c/75LlSO7dI7evCh0KN pvTwDi1Xu/Rutg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGHyu-0006vi-Jr; Fri, 13 Jan 2023 06:12:33 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230107150457.4446-1-ludo@gnu.org> <87o7r3wy55.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 24 =?UTF-8?Q?Niv=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Cuivre X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 13 Jan 2023 12:12:17 +0100 In-Reply-To: <87o7r3wy55.fsf@gmail.com> (Simon Tournier's message of "Thu, 12 Jan 2023 16:49:58 +0100") Message-ID: <87mt6melim.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673608395; a=rsa-sha256; cv=none; b=imqss4PYFxxzKCsC3/Q9g4OE13grOxukBrE3IwMjgWs8UTew9Y4dPXVzTTJxDI8KuS0HQF jLMsVjodq/vDFbo8s2GMhCtJKzEBeHBujXV6CFOjgtSEhsyfXadL28Ok9JSjgP1H8FDI9U +FQi6HJ826g4cCPDuUaVemvDQlg08yDOMDhuBMvqKv2/FbndKytBxl9ZAeM3Rsj/t4QSSV zTvSxabR9Lqzk64ww08nfFJy3M5rjyly+7tV39PjOGW9wQi8QSY9m7SADK/R0zniKhuizD yBZUe5C1CA81EPTa1ULoAMJU+vjaAD1RQNLZFwP9I104WkDmgxHLEBFw6Ws/wg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=m8SwcKL6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673608395; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=e8LkjbloKWVAiiLYpLhV2Nqj8d3ciHZXgMJ63bn4r5c=; b=Orghldu8g0WAe3eKKJzqyEz9EKH70p4IbdFajuge2Ap6aiktAcbaBxMX+ncVx/VvhbKoMb x6e2PXfbw6ham56okv0sdG1u3dmmJsd5AiVKRpOU5Y+2zylxL+mRFqjQoDQas5WoQS3Kgi +GsVuJURbR15EXeTSmWZWPYHBzgJX8D/b/hHjqS5AEB9hvPsQs9R85FGHDPZJO1wdZe2KI ZjUrUQ60S+4qqaySwBhLAhNCkKJnyGR+59FP3qncjmQZbD1SXPZm3uwt/2tUVAl+ClGOGI BTHARU8MzBEzm991VqukpVj1hEwsDaraRWp25mAV5qKGUZKalPRET/3eWvh3uA== X-Migadu-Spam-Score: -2.50 X-Spam-Score: -2.50 X-Migadu-Queue-Id: B437A6E2A X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=m8SwcKL6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: 3RyNudvperpA Hello! Simon Tournier skribis: > On sam., 07 janv. 2023 at 16:04, Ludovic Court=C3=A8s wrot= e: > >> Now that updaters can (to some extent) import any upstream version, we >> can provide a =E2=80=98--with-version=E2=80=99 package transformation op= tion that picks >> the given upstream version. > > Well, transformation bypasses the checksum control and so it is not > really a fixed-output, right? It=E2=80=99s not fixed-output at all because we don=E2=80=99t know in advan= ce what we=E2=80=99ll get from that download. > Therefore, the result depends on the state of the world and thus it is > not necessary reproducible. Absolutely. [...] > All that said, this option is cool to have. :-) It is missing some > guards, IMHO. Maybe: > > 1. Wording some warning for the manual Will do, that makes a lot of sense to me, I share your concerns. > 2. Add comments about reproducibility when exporting manifest with > transformations; for example, > > (define transform1 > ;; WARNING: some transformation might lead to non-reproducible prof= ile. > ;; For more details, please see the Package Transformation Options = section. > (options->transformation > '((with-version . "python-numpy=3D1.22.4") > (with-c-toolchain . "python-scipy=3Dgcc-toolchain@7")))) This one=E2=80=99s a bit more involved technically because we don=E2=80=99t= use (guix read-print) yet here, so I prefer to do that separately. > 3. Add a warning. Similarly, to this: > > warning: cannot authenticate source of 'python-numpy', version 1.22.4 > > For instance, > > warning: transformation for 'python-numpy' with version 1.22.4 might b= e non-reproducible I wonder about this one because it would be displayed unconditionally, there=E2=80=99s no =E2=80=9CI understand the risks=E2=80=9D button one can = click to make it disappear. I=E2=80=99d lean towards making a prominent warning in the manu= al and not have a warning message every time here, dunno. Thoughts? Thanks for your feedback! Ludo=E2=80=99.