From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2Jj0M+MR6GM/FgEAbAwnHQ (envelope-from ) for ; Sat, 11 Feb 2023 23:08:35 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id Dv6VMeMR6GOfrgAAG6o9tA (envelope-from ) for ; Sat, 11 Feb 2023 23:08:35 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9740A2A6F0 for ; Sat, 11 Feb 2023 23:08:35 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQy2O-0005G6-KB; Sat, 11 Feb 2023 17:08:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQy2M-0005Fc-V6 for guix-patches@gnu.org; Sat, 11 Feb 2023 17:08:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQy2M-0000Gl-MM for guix-patches@gnu.org; Sat, 11 Feb 2023 17:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQy2M-0005Vl-DY for guix-patches@gnu.org; Sat, 11 Feb 2023 17:08:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61207] [PATCH v2] gnu: Add opentaxsolver. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 11 Feb 2023 22:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61207 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61207@debbugs.gnu.org Cc: dev@jpoiret.xyz, stellarskylark@posteo.net X-Debbugs-Original-To: Josselin Poiret via Guix-patches via X-Debbugs-Original-Cc: Josselin Poiret , 61207@debbugs.gnu.org, Skylar Hill Received: via spool by submit@debbugs.gnu.org id=B.167615326421153 (code B ref -1); Sat, 11 Feb 2023 22:08:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Feb 2023 22:07:44 +0000 Received: from localhost ([127.0.0.1]:43469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQy24-0005V6-BE for submit@debbugs.gnu.org; Sat, 11 Feb 2023 17:07:44 -0500 Received: from lists.gnu.org ([209.51.188.17]:39512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQy21-0005Ur-JF for submit@debbugs.gnu.org; Sat, 11 Feb 2023 17:07:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQy21-0005Cz-9k for guix-patches@gnu.org; Sat, 11 Feb 2023 17:07:41 -0500 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQy1y-0000ES-BN for guix-patches@gnu.org; Sat, 11 Feb 2023 17:07:40 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 5FCFD60002; Sat, 11 Feb 2023 22:07:33 +0000 (UTC) From: Nicolas Goaziou Message-ID: <87mt5jsvt6.fsf@nicolasgoaziou.fr> References: <87edr6x169.fsf@jpoiret.xyz> Date: Sat, 11 Feb 2023 23:07:22 +0100 In-Reply-To: (Josselin Poiret via Guix-patches via's message of "Fri, 3 Feb 2023 15:41:27 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:4b98:dc4:8::223; envelope-from=mail@nicolasgoaziou.fr; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676153315; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=nOZCO7COncnXh6n7J48TlL7NdQEEUgNiq+gyxppvi/k=; b=sK9HjLGW2iaqIOXEx6uawX+odHZLmlzPm1dOuXizI3Y2jXZMMsbwGsW6MRNm2Yd4jps6KD Z3FL/OOR6NhTGJ1W1NcblUBLZp0v/VDH80KPNao1QnhCB4vRs+0I1VTGniOeoQmJw40kYD rdEZU4xKod4CcHXWVSq7O/c8e3/1HmmOASvdrU8Y21YERz7F4fPJI2FAU6q2W7H+dtSsqv Z1v8EgoKcMmC8fA/2hVPSIE7nNrDSc410epBvT65wRPKx129yCBiZU9sEMwyU4TCqJnW8E RdnbHhgPrPrJOXd1VMcbTcS8Fz0P83N/Mp2wYmvCvD6MsnUzh3ilJfIaBOq9nQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676153315; a=rsa-sha256; cv=none; b=gELkTmaIVpcoES+D9RBZF2yNXTTE8HIpia+1gldnJeSuVtdcDWVOlgLShEkUq8FHbRfpCI cMqOruYqS0O52nVFD6v+qTnDeoFMS9w259Pmeo581SpwlkLEntRsgI6CFRmqGY+9FxGsCY YF6CCAI9fB+qpq80syOvW+2BGyH8RWktMEbulEPq1htFvBjAnIpVQFjLlqkKip+FgLAPJR KksQPdt8JDJJJglOphPv/sYtpiYqN9nYzmnDUzbMc8D2HTClHlmjuiiguSinwlv8Aws0Zs kK+QUK0n/qleS8OWg3OcHBq32GQQQseKbk1e7ZvvfKZIN42cMpFRtnijiHqtSw== X-Migadu-Queue-Id: 9740A2A6F0 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -4.11 X-Spam-Score: -4.11 X-TUID: pfHKh80OTTXx Hello, Josselin Poiret via Guix-patches via writes: > From: Skylar Hill Thanks to both of you. > > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://sourceforge/opentaxsolver/OTS_" > + tax-year > + "/v" > + ots-version > + "_linux/OpenTaxSolver" > + version > + "_linux64.tgz")) Formatting needs some love here. > + (sha256 > + (base32 > + "06k0a72bmwdmr71dvrp8b4vl8vilnggsh92hrp7wjdgcjj9m074w")) > + (patches (search-patches > + "opentaxsolver-file-browser-fix.patch")))) This file needs to be registered in gnu/local.mk file. > + (build-system glib-or-gtk-build-system) > + (arguments > + (list #:phases #~(modify-phases %standard-phases (list #:phases #~(...)) > + (delete 'check) There are no tests. You need to use #:tests? keyword instead. > + (description > + "OpenTaxSolver is a free, safe, and secure program for calculating tax form entries for federal and state personal income taxes. It automatically fills out and prints your forms for mailing. I suggest to remove "free, safe, and secure". Description needs to be filled, too. > +Invoke with @code{ots_gui2} rather than the usual > @code{Run_taxsolve_GUI}.") Note that it is possible to create a symlink to reintroduce Run_taxsolve_GUI. > + (license license:gpl2+)))) I agree with Josselin. Licensing is unclear. Many files do not have a license, or are "user contributed" (under what terms?). Would it be possible to clarify this with upstream? Regards, -- Nicolas Goaziou