From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id InL9DyqEA2TGRAEAbAwnHQ (envelope-from ) for ; Sat, 04 Mar 2023 18:47:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MD3ZDiqEA2QLugAAG6o9tA (envelope-from ) for ; Sat, 04 Mar 2023 18:47:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5DCDF2CCE0 for ; Sat, 4 Mar 2023 18:47:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYVyT-0006D2-6s; Sat, 04 Mar 2023 12:47:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYVyI-00068v-Lp for guix-patches@gnu.org; Sat, 04 Mar 2023 12:47:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYVyI-0006Kn-Dq for guix-patches@gnu.org; Sat, 04 Mar 2023 12:47:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYVyI-0007Mk-A0 for guix-patches@gnu.org; Sat, 04 Mar 2023 12:47:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61959] [PATCH 0/7] Add some Asahi Linux packages References: <20230304144415.9644-1-roman@burningswell.com> In-Reply-To: <20230304144415.9644-1-roman@burningswell.com> Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 Mar 2023 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61959 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61959@debbugs.gnu.org Cc: roman@burningswell.com Received: via spool by 61959-submit@debbugs.gnu.org id=B61959.167795201028296 (code B ref 61959); Sat, 04 Mar 2023 17:47:02 +0000 Received: (at 61959) by debbugs.gnu.org; 4 Mar 2023 17:46:50 +0000 Received: from localhost ([127.0.0.1]:37688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYVy5-0007MK-Sl for submit@debbugs.gnu.org; Sat, 04 Mar 2023 12:46:50 -0500 Received: from sender3-of-o57.zoho.com ([136.143.184.57]:21794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYVy4-0007MC-IW for 61959@debbugs.gnu.org; Sat, 04 Mar 2023 12:46:49 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1677952005; cv=none; d=zohomail.com; s=zohoarc; b=OM6IvlADIzySUzazigfytwVw//KLVsw5JLxLAK5nUuAT5j7CsNWDnNmM1aceTNWDl2qFMYlKwfoVxC7/Mjxm59clIWml3xi6wDagPZ/1JNZ6SCwkGkGS6QVD4+TVkV58uPCc9BlEGrfOxP6p5YyddtKqJBjMAYGyRbSfLxlBijE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677952005; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=8Zb8/CZS3xVSf1Bu9MsEepWUfW75TIOxQo+RWeSX0Kc=; b=PV/+Y68cNrPsb+F4h/Z7WfApVJ3UCVg3seBXMi3MxDl6qQwJty9FygR3bgKvjhg9FgPHY/ltKQq1RIIZbyJDMtw8UgihanubegoUXeyoIOXY/eJtfICuN3Szz1CQ8t19U07fDf1BwCtCuZ16fuHRxJtGhBDZ/W+yLeagXXbwP54= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1677952005; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Subject:Subject:Date:Date:cc:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=8Zb8/CZS3xVSf1Bu9MsEepWUfW75TIOxQo+RWeSX0Kc=; b=i2xS5EMNqyz6XJx4sw8yRXc4gGklh2RkZktOkwKPIMS5uSwOyCjA22CY7X+1a5z3 OhzLDbuPaGJOqWLGRp8eMiqtEVEJB/5zvduzNP/hYx1P/ss9XEiDKs3+MM+g02JyqdL Q7TT1xrzpULM4Iih/KIiYoqADKjohHXgc52Qb+vg= Received: from localhost (110-108-142-46.pool.kielnet.net [46.142.108.110]) by mx.zohomail.com with SMTPS id 1677952004292273.46866667452764; Sat, 4 Mar 2023 09:46:44 -0800 (PST) User-agent: mu4e 1.8.13; emacs 28.2 From: Ricardo Wurmus Date: Sat, 04 Mar 2023 18:38:29 +0100 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87mt4sl88u.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=2; s=key1; d=yhetil.org; t=1677952042; a=rsa-sha256; cv=fail; b=gTT/8uo9T2AHjSq0pW9UVQqE6hZkcM29F0E6QD/xbNH42AHhHuChuR2CT+vVpXflG4dd6c sMt2R6RSp5sFxZ4SxdEdElywVVsd6g4G/6irOo446ezlOvRBC+09bFAdnrl7bXcyTLjxqh guY7ANZ9vBJYcLCmPp1Qw3wK3hh0KwH5fs2Y+Iz/iERHhrWMTViEi8EPrrCEzzv3s0m0Iy 8x9cebX+nb3EFrP7BmVUoQjSZsR9GTygBS3d7r0KXBI/1ppCAR7Rj07yWKfV+h1Dl/mXc+ mplkc6oPg0EYB0GHlCeXnOCu1UoP2hMZfQWCdN+N3pJw5jbP3XvjeA6bKRtP5Q== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=i2xS5EMN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677952042; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8Zb8/CZS3xVSf1Bu9MsEepWUfW75TIOxQo+RWeSX0Kc=; b=gjs18D10DQnNSSYPpvo3RhyKqFDNtYGzSOFuPBg30BLwQGKSNEWMdepD/WoNIE/V3Op7Sy fFWtV5ZfrZ3H3wyjzdklBotOFGNbK7eLfmlbd4JTs55NvVnJNE1+CmSpLRRIR31rCGR7L+ Dgs3f6dvdk+DGGUzQwBRpUVfNvpGxByIQS2d6JK5e1f+cZSVcdogCiQKH2mfiZyto8kuPA EamJ+bimtL+oSlmhJSgcCNpy5ih3sJkmAduU7RVrg0nEYBVyimbVSCDms7+F+eSWt7yrpc 1vHTh4eoK5ObKpZx/4/Z22DvlARjR8wH1W7X/NBn5aDDwfbA5xRruYpOmFZ+xg== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -1.20 X-Spam-Score: -1.20 X-Migadu-Queue-Id: 5DCDF2CCE0 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=i2xS5EMN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}") X-TUID: 9TRXUqAFeomZ Thank you for the patches. Here a couple of comments: * Please do not use Github archive URLs like "https://github.com/AsahiLinux/m1n1/archive/v=E2=80=A6.tar.gz". These are automatically generated and have changed in the past, leading to different hashes. In the interest of reproducibility please use =E2=80=9Cgit-fetch=E2=80=9D with plain commit hashes instead. * Please use G-expressions instead of simple quoting with (assoc-ref outputs "out"). Instead of this: --8<---------------cut here---------------start------------->8--- (arguments `(#:phases (modify-phases %standard-phases (replace 'configure (lambda _ (setenv "RELEASE" "1"))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) (let ((dir (string-append (assoc-ref outputs "out") "/libexec/= "))) (mkdir-p dir) (copy-file "build/m1n1.bin" (string-append dir "m1n1.bin")))= )) ;; There are no tests (delete 'check)))) --8<---------------cut here---------------end--------------->8--- Please do this: --8<---------------cut here---------------start------------->8--- (arguments (list ;; There are no tests #:tests? #false #:phases #~(modify-phases %standard-phases (replace 'configure (lambda _ (setenv "RELEASE" "1"))) (replace 'install (lambda _ (let ((dir (string-append #$output "/libexec/"))) (mkdir-p dir) (copy-file "build/m1n1.bin" (string-append dir "m1n1.bin")))= ))))) --8<---------------cut here---------------end--------------->8--- This also applies to =E2=80=9Casahi-fwextract=E2=80=9D. * The string labels for inputs are a deprecated style. Please use plain lists of package variables. If you want to modify an inherited list of inputs such as in =E2=80=9Casahi-mesa=E2=80=9D please use =E2=80=9Cmod= ify-inputs=E2=80=9D. * In =E2=80=9Casahi-fwextract=E2=80=9D the build phase =E2=80=9C'remove-ven= dor=E2=80=9D should be a source snippet instead. * Please use pyproject-build-system instead of python-build-system. The pyproject-build-system is going to be the default in the future, and it would be good to use it already to address any incompatibilities early. Could you please send a new version of this patch set? Thanks again! --=20 Ricardo