From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 2GbDL7q+NWWfcgAAauVa8A:P1 (envelope-from ) for ; Mon, 23 Oct 2023 02:30:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2GbDL7q+NWWfcgAAauVa8A (envelope-from ) for ; Mon, 23 Oct 2023 02:30:50 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3FD6A738C9 for ; Mon, 23 Oct 2023 02:30:50 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ikxTuGZX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698021050; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aou4E+YoKGcSkzf5g8sLulCAR5xkcUwtv/1izT4X11I=; b=X8v9qr7iwAEADcrET8qJ58QoHjPDM8zWqXwTlZBgEuYagiZeX7LihluU9hTvZyAjNRlKK5 kKwbsY5BnTIP3eseR8XloH62M0ne1FMaYhF+41vJfgYy2iKzr0EuXdqvjupWKhoqlM90TS FOhpqMDF6PIQqFl9flJVnawiaRF8KcJhW3z28Hp7+3OXOx7xLFNU+Qg6nabr8fxouHDIXl yTxefL9tQ3yYeJ5VyZYYm/cIHrz1j25dVrMCLGZhUo2971ss44ZLaQKlEmDEa+RHcW4Wn0 oWX1UxlhdYk0pMtGph3Qlnm1uqf+4f6Wh0okXt06SLxWOUfp0IM1vQrNTYMQtw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698021050; a=rsa-sha256; cv=none; b=kW6LsD3J0eRSjsjQFQsDPAQr9emuUNXpFiKnLLW2xiqE2cQ6pFXzDQym5KRpGT1GrqflBU G6kJnW4CLiCtdua/jvi3ePSiLg7fsIOvz70dqj0Q29kDGX3CkIIE8RGz5OQjI+h17n5wM2 VHxLnB4cI53WIGB/TuTmd3QKuupomW2Gx3ivPih5akaieWicAhozVmNM7/q8/YCB3MY773 Z7xf2+GvNqyVCuh3tX9Rx0aRG0pWgPpbvSa74jShjLTqbZHfSRA7CHApv7/QkJpSO7x5vg 8cVBCXxv6bjcj1AI5G/5Zn4ibl7ReWBqVXOU53KIDA/rXq4c8EohJ9MPVK8bbw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ikxTuGZX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quiq2-0005q0-HW; Sun, 22 Oct 2023 20:30:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quiq1-0005pk-Jj for guix-patches@gnu.org; Sun, 22 Oct 2023 20:30:33 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quiq1-0000Sk-Ai for guix-patches@gnu.org; Sun, 22 Oct 2023 20:30:33 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1quiqT-0000yd-MZ for guix-patches@gnu.org; Sun, 22 Oct 2023 20:31:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66618] [PATCH] etc: gitconfig: Remove the default email address to avoid mistakes. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Oct 2023 00:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66618 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 66618@debbugs.gnu.org, Simon Tournier Received: via spool by 66618-submit@debbugs.gnu.org id=B66618.16980210503738 (code B ref 66618); Mon, 23 Oct 2023 00:31:01 +0000 Received: (at 66618) by debbugs.gnu.org; 23 Oct 2023 00:30:50 +0000 Received: from localhost ([127.0.0.1]:48546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quiqH-0000yD-It for submit@debbugs.gnu.org; Sun, 22 Oct 2023 20:30:50 -0400 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]:51377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quiqD-0000xw-BN for 66618@debbugs.gnu.org; Sun, 22 Oct 2023 20:30:48 -0400 Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-66d060aa2a4so21314586d6.2 for <66618@debbugs.gnu.org>; Sun, 22 Oct 2023 17:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698021010; x=1698625810; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aou4E+YoKGcSkzf5g8sLulCAR5xkcUwtv/1izT4X11I=; b=ikxTuGZX5Vf7ZNjp60yhiIdcgnfANROziNrW/Q4+K0NTeVmx9daCTgNQKYZaOMWHZT y8jOy2uPJnUdvEcFoswQpe0PvEt54RGDdSSH573bjw7aZEiU4+EWESFjESnNpeWh6yHr kaF4nScO/LkLTRhoiglbQx8vm9cMS+99+al4di+ieZZVCMetogtdAGUWLuzOqfpAFrh4 42TI/B9l2B0lOCw//we/lUSWK4rXVFIkvlY0dJJBFLtpbXU6jnPhsCws2+FRvkAIspbA G0ZHyGViyk9Rjh+HwnITlEYQSV1Q10/9rJxb2l4H0v7+KLkzKvmgBepI7JEZixC8ncf0 95jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698021010; x=1698625810; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aou4E+YoKGcSkzf5g8sLulCAR5xkcUwtv/1izT4X11I=; b=kbn8q1LR7AgLPtkD0iWQbFIx52waSnCLtCxO0ByWMRhE4F4PPg6alOvJaq6wMlVxWi YupZnKqdENLKXT2bhxc3JyGmi/aTY19gZB+CSyWtofLGA6FJ+o8mzxFK8+Dl+c85AOaA r106/OjwBZJKN5gTMS7RQbdOdeIZ+H50ysvi0/UkJJ6dnJ7NYkJI4k/FmlIBHk8WahYj Pw/k06+wq+EusNazvgstCa8ULCyh+C19XyeGK32QwUEolXenB3XE4C6oywRsMTOgXVTE 4nGfiZI00PIKQSQTBe/roST7PNbUL8K/CX5oC13wKOEKRmi2L+coe7PkFWjqIMkQcJdC Qggw== X-Gm-Message-State: AOJu0Yz3cDwAS5kDqKg+SNPhVyOdt/5YRsI8yMPQMorU7FEVnE1b7h1y S6QK4Vkw3L/x4F+Q/aE3UJV2jnUdIxw= X-Google-Smtp-Source: AGHT+IHlDYtRFC9X8zs1s9sZAQOSdnHGvqEwXUhIR9mxa2EBBZiFFdQXIh1yN15FXGDIU+irUxVOVg== X-Received: by 2002:a05:6214:2427:b0:66d:a4d:84f7 with SMTP id gy7-20020a056214242700b0066d0a4d84f7mr9238585qvb.28.1698021010522; Sun, 22 Oct 2023 17:30:10 -0700 (PDT) Received: from hurd (dsl-205-236-230-191.b2b2c.ca. [205.236.230.191]) by smtp.gmail.com with ESMTPSA id g10-20020a0cf84a000000b0066d0621bb67sm2498505qvo.114.2023.10.22.17.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Oct 2023 17:30:09 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87mswav0lr.fsf@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?= Lassieur"'s message of "Sun, 22 Oct 2023 22:55:12 +0200") References: <87pm1bqtp1.fsf@gmail.com> <87zg0em529.fsf@gmail.com> <87cyx9mlq4.fsf@gmail.com> <87y1fxguxk.fsf@gmail.com> <87mswav0lr.fsf@lassieur.org> Date: Sun, 22 Oct 2023 20:30:08 -0400 Message-ID: <87mswab2pb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 2.88 X-Migadu-Queue-Id: 3FD6A738C9 X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: 2.88 X-TUID: eoGum0zUKG/L Hi, Cl=C3=A9ment Lassieur writes: > Maxim Cournoyer writes: > >> Hi Simon, >> >> Simon Tournier writes: >> >>> Hi Maxim, >>> >>> On Thu, 19 Oct 2023 at 21:54, Maxim Cournoyer wrote: >>> >>>> One could argue it's also a misleading documentation. It should say if >>>> a 'to' address is not specified *or* configured.=20=20 >>> >>> Well, personally I prefer: =C2=AB Explicit is better than implicit. =C2= =BB and >>> =C2=AB=C2=A0Errors should never pass silently. Unless explicitly silen= ced. =C2=BB. >>> >>> Here, the default >>> >>> [sendemail] >>> to =3D guix-patches@gnu.org >>> >>> makes something implicit =E2=80=93 which is not necessary bad =E2=80=93= but it hides >>> potential errors =E2=80=93 which is not good. >> >> But that's true for any automation of git. If we follow that logic we >> can remove the other git configurations because they may be surprising, >> and the send-email hook that notifies people, because that can again be >> surprising. > > Some automation is fine (although maybe not necessary) because it's > about things we want to enforce (like signed commits). > >> Obviously, I'd rather not go that slope. The small cost in surprise is >> offset by removing manual work for myself and I'd expect/hope other >> committers. Does that make sense? > > I don't think there is a need for `--to` automation in Guix repo because > it's something the user can automate in their own ~/.gitconfig (with > `includeIf`[0]). I often have single patches, or with series I need to send the cover letter first; just writing 'git send-email -1' is shorter than 'git send-email --to=3Dguix-patches@gnu.org -1' :-). I also often use patman (info "(u-boot) Patman patch manager") and there's no way to specify a --to from the command line (you use Series-to: NNNNN@debbugs.gnu.org as a git trailer after having received it for a cover letter), which would make things slightly more annoying... > [0]: https://git-scm.com/docs/git-config#_conditional_includes ... by having to configure this in a way that matches all my Guix worktrees spread around :-). I guess what I'm saying is that it provides value for me, and I'd expect for others, although I can see how it could generate surprise when you initially get your 'get send-email' foo wrong. Perhaps we should more prominently mention that 'mumi send-email' should be used for first timers, as it's less likely to get things wrong using it? --=20 Thanks, Maxim