From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id IFaZCR80u2WJ0QAAqHPOHw:P1 (envelope-from ) for ; Thu, 01 Feb 2024 07:03:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id IFaZCR80u2WJ0QAAqHPOHw (envelope-from ) for ; Thu, 01 Feb 2024 07:03:11 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=zFrZKRIB; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706767391; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=X6Nk28Pj3VbHL6xKME75YHTqCyrLxsp6doba4W6LAOM=; b=FmR+tZCoXw6BtZNR+qxStsKZcZDbTLOVa43MG7oEQgVjqW37AU9OuwJQW8oslqHay9sDj7 PFndUcLU1HjxAaZBQ2PobtFCORNiGVeZKIfqZhYXyxCyEs/9xnyQbx0FQN/x/Ng1Jssc7z 7KJoxXKKWKed7Wd/Q3J+FY27aK2MfjVmM+64WhlbF8ahUGOyQCQc43T2UOL9LgyiVPA8q6 GAPiQWXArwlLiZoqNNCfYoPcgixWVXer7265yJAB9k4cTmNHePeOyGJs2gjtvdFkV/hGS6 TstBT9bZ3lV8ZZW5Anj1PTgxQNYBnXPCVaAWTAliJHJPro7ngXLwA7COQ6ATCw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=zFrZKRIB; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706767391; a=rsa-sha256; cv=none; b=Q0nncNWI4ccKfDtlxzXPw/af0jS4lZuiEKogtYEVxuFK5FBXO9LItwUUX6gYcvjBgv8r/5 t/MUcBXZqUrgsihqUy7A7S6lfYHfkvhxZvUN1RrsWHLowxwdX2RhspXnxWhf6OUc0uV5l/ 9Yj7PMYm/78unIqPWKybMLusA8UHmzEnNLYbXAlp/O+pALJWN7DyGBqEN/rPx280doylVh GzyI+R82G0J9L5EZMzKFGyXWu8o9ReOytT4+dFyvgygdIhRds6Bd9d1Laoa/z9ador6bjt QNCS/oe7MXGBDqPa7LUaXTB9njJIYj7f2vNmH0D7KiAnKfQeLKCLP6ef4egVeg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 13FA718158 for ; Thu, 1 Feb 2024 07:03:11 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVQA3-0000OR-72; Thu, 01 Feb 2024 01:02:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVQA2-0000O2-1J for guix-patches@gnu.org; Thu, 01 Feb 2024 01:02:54 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVQA1-0002fN-PM for guix-patches@gnu.org; Thu, 01 Feb 2024 01:02:53 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVQAA-0004Ql-Br for guix-patches@gnu.org; Thu, 01 Feb 2024 01:03:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68420] [PATCH 1/1] scripts: size: Add =?UTF-8?Q?=E2=80=98system=E2=80=99?= argument to =?UTF-8?Q?=E2=80=98ensure-store-item=E2=80=99.?= Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Feb 2024 06:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68420 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: Josselin Poiret , Tobias Geerinckx-Rice , Simon Tournier , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 68420@debbugs.gnu.org, Zheng Junjie , Ricardo Wurmus , Christopher Baines Received: via spool by 68420-submit@debbugs.gnu.org id=B68420.170676735816998 (code B ref 68420); Thu, 01 Feb 2024 06:03:02 +0000 Received: (at 68420) by debbugs.gnu.org; 1 Feb 2024 06:02:38 +0000 Received: from localhost ([127.0.0.1]:40062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVQ9m-0004Q6-A1 for submit@debbugs.gnu.org; Thu, 01 Feb 2024 01:02:38 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:57124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVQ9k-0004Pw-6U for 68420@debbugs.gnu.org; Thu, 01 Feb 2024 01:02:37 -0500 Date: Thu, 01 Feb 2024 14:02:14 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1706767293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X6Nk28Pj3VbHL6xKME75YHTqCyrLxsp6doba4W6LAOM=; b=zFrZKRIBYYpUvqufYKnWqkjwtIek7ZcWm97gEJ11gGOQd0dTLrhljTHvFJfp6AU6asaRU+ OsNzRNfVR6aJqlzr0pAnf4FuER1VYM6Y9yfbGyLUxUKjpJ8hmkYYd+CFeqGd4s7elcGe8P R495CGQFSLZOADJHzNDqI0l08Qf8SElGR7Wa3xi8AA7+18MJ/bzCsOZyNt2SoMv7vYGYfM IB09oLdMCb7S12ebNfcBRVb5fOy9gq6txelEFJg9gfaonxdr+NapWq1yfJ0CUGF4vx0CPv 3smf5A+N5et+zm+YCPCRrtgiaFSI3eI1KL6orVHcgjS13dCYzwAHWyz1+N+jsQ== Message-ID: <87mssk4t95.wl-hako@ultrarare.space> In-Reply-To: <8734v1inh6.fsf@gnu.org> References: <8734v1inh6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ++ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.65 X-Spam-Score: -5.65 X-Migadu-Queue-Id: 13FA718158 X-Migadu-Scanner: mx12.migadu.com X-TUID: w+5vv6sDYrME Hi Mathieu, On Sat, 13 Jan 2024 17:36:37 +0800, Mathieu Othacehe wrote: > > > Hey, > > > -(define* (ensure-store-item spec-or-item) > > When I have a look to the derivation that is computed in that procedure, > it looks like it has the expected system (the one passed as a cli > argument). Do you have any evidence of `guix size` doing the wrong thing > after c245a54aab? Sorry for the confusion, c245a54aab did fix the issue, I should remove the "follow-up" line in the commit message. This patch is more of a style change: Since system has been passed to =A1run-with-store=A2 and parameterized with= in it, we only have to deal with the =A1mlet*=A2 bindings which are evaluated earlier. For this specefic case, only =A1ensure-store-item=A2 used in =A1mlet*=A2 bi= ndings needs the system, so we can simply handle it there. And I think parameterizing s= ystem around =A1run-with-store=A2 again made the procedure less clear. Thanks