From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: "Josselin Poiret" <dev@jpoiret.xyz>,
"Tobias Geerinckx-Rice" <me@tobias.gr>,
"Simon Tournier" <zimon.toutoune@gmail.com>,
"Ludovic Courtès" <ludo@gnu.org>,
68420@debbugs.gnu.org, "Zheng Junjie" <zhengjunjie@iscas.ac.cn>,
"Ricardo Wurmus" <rekado@elephly.net>,
"Christopher Baines" <guix@cbaines.net>
Subject: [bug#68420] [PATCH 1/1] scripts: size: Add ‘system’ argument to ‘ensure-store-item’.
Date: Thu, 01 Feb 2024 14:02:14 +0800 [thread overview]
Message-ID: <87mssk4t95.wl-hako@ultrarare.space> (raw)
In-Reply-To: <8734v1inh6.fsf@gnu.org>
Hi Mathieu,
On Sat, 13 Jan 2024 17:36:37 +0800,
Mathieu Othacehe wrote:
>
>
> Hey,
>
> > -(define* (ensure-store-item spec-or-item)
>
> When I have a look to the derivation that is computed in that procedure,
> it looks like it has the expected system (the one passed as a cli
> argument). Do you have any evidence of `guix size` doing the wrong thing
> after c245a54aab?
Sorry for the confusion, c245a54aab did fix the issue, I should remove the
"follow-up" line in the commit message.
This patch is more of a style change:
Since system has been passed to ‘run-with-store’ and parameterized within it, we
only have to deal with the ‘mlet*’ bindings which are evaluated earlier.
For this specefic case, only ‘ensure-store-item’ used in ‘mlet*’ bindings needs
the system, so we can simply handle it there. And I think parameterizing system
around ‘run-with-store’ again made the procedure less clear.
Thanks
prev parent reply other threads:[~2024-02-01 6:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 7:25 [bug#68420] [PATCH 0/1] scripts: size: Add ‘system’ argument to ‘ensure-store-item’ Hilton Chain via Guix-patches via
2024-01-13 7:29 ` [bug#68420] [PATCH 1/1] " Hilton Chain via Guix-patches via
2024-01-13 9:36 ` Mathieu Othacehe
2024-02-01 6:02 ` Hilton Chain via Guix-patches via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mssk4t95.wl-hako@ultrarare.space \
--to=guix-patches@gnu.org \
--cc=68420@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=hako@ultrarare.space \
--cc=ludo@gnu.org \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=zhengjunjie@iscas.ac.cn \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.