From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id qPKhMT7oUWYknwAAA41jLg (envelope-from ) for ; Sat, 25 May 2024 15:31:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id OKs+Lj7oUWanJwAA62LTzQ (envelope-from ) for ; Sat, 25 May 2024 15:31:42 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=r86fTAr6; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716643870; a=rsa-sha256; cv=none; b=egA6QJoqgWzU3aEb7pKLntCaFAi2KXY7IiwCwSOiBMR1T/agRv+IbOr0jRP7yF+GDtzKhO QyNC6twRiN0B7QOA+bLjNL5neDNoyTpVl30i5B4+CpbPCEwdWr+3SAfFzklRT1AnRJpmDP jthy327HGBgxiviittINY4ZM/b8MseKrn5YzS+Twahhb2PiqDtsPDOT1HNOTrvl7a7/GI6 dPPhgoeq3oFt8e45fQseTI9Ojy1V/PRqTwm0vhFP9jVsziCjFV8Own/HXfFGPvpZTpS8KZ 6J/MEWCDRA05S1BFBgVa0Hmf73OR2UE+oTcB6G1AIZceZa8FXmyx+jI5rNAEmg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=r86fTAr6; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716643870; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jjN2vz4uqPANkIQbRCutu4AP/Y1LpKfw3qVjSF3boFM=; b=G9fytqT0q7dciBHjd+G9ASVtnv9O/xTo0cheYPxUQ8w4TV2EWaNVwd+AApAo5L1clAikqQ Oda34nfs3YYqYRqQFLzf4fr/XLFN8vRq8Bcd4ykoxqTkg2lxkJTP5Mo9kywknw0hdESu5I BkHB6ILcB6aopm6eAEyRoBp8cHOkwq7r8sFDvlj2GqmrelhT4wvqfXzf5xQ1TL7u1SrRX2 KBHtWDT0FKFPRcVofo5AGUDgGPk229OKBsmjkuBYNdMoVtnYwG2GpJFxn467XHBf68rwxi qwfqya3N6q7mj4e13fYvm+5+yAJhgpw1RP86dWmopO82Ch5JELRGMfFxQXyMPA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7906B19938 for ; Sat, 25 May 2024 15:31:10 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sArUA-0003gj-LW; Sat, 25 May 2024 09:30:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sArU7-0003fp-Ph for guix-patches@gnu.org; Sat, 25 May 2024 09:30:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sArU7-0002hl-HJ for guix-patches@gnu.org; Sat, 25 May 2024 09:30:55 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sArUE-0006tF-OG for guix-patches@gnu.org; Sat, 25 May 2024 09:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-service-type. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 May 2024 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70460 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dariqq Cc: 70460@debbugs.gnu.org, felix@alternativebit.fr, Florian Pelz Received: via spool by 70460-submit@debbugs.gnu.org id=B70460.171664380626269 (code B ref 70460); Sat, 25 May 2024 13:31:02 +0000 Received: (at 70460) by debbugs.gnu.org; 25 May 2024 13:30:06 +0000 Received: from localhost ([127.0.0.1]:43441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sArTK-0006pc-1h for submit@debbugs.gnu.org; Sat, 25 May 2024 09:30:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sArTG-0006oe-U7 for 70460@debbugs.gnu.org; Sat, 25 May 2024 09:30:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sArT3-0002X7-Tw; Sat, 25 May 2024 09:29:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=jjN2vz4uqPANkIQbRCutu4AP/Y1LpKfw3qVjSF3boFM=; b=r86fTAr63SONdOTfgo9q zOrk/Y1SMOYXDk97Wxkj2mWmM7+TZ/hvGoMy9mRlEJTSB1hJ4B4+S7WPIdtLOGoOrQ6z6R0C/gnER AaEvtoBmSA3LgpgtBzNLloK3lVa5qCjPUqiLalLGOo5FJRHQio0hg0xM7EZ24vZueMWTHLWTLvu7a 9DOnRm9o8qOtou31EIOJsPKtjAwkxNDTEkaeJLlGHqDpLzoIAd5e5lJPx7Ul7eq2UOuNhujyHSUmZ 6tF0QGaoqjvaxlg8t8sod5w7HzPwZdyyZXsHgbshSw7qarQYCISI6zJYjm9J19k5LTFiy69yvgREX udUjj5FowCg9VQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (dariqq@posteo.net's message of "Thu, 2 May 2024 15:37:56 +0000") References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 7 Prairial an 232 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Fromental X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 25 May 2024 15:29:46 +0200 Message-ID: <87msoe10l1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 7906B19938 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -7.25 X-Spam-Score: -7.25 X-TUID: XIcZ6MrM4B5X Hi! Dariqq skribis: > * gnu/services/pm.scm > (power-profiles-configuration): New configuration. > (power-profiles-daemon-shepherd-service): New procedure. > (power-profiles-daemon-activation): New variable. > (power-profiles-daemon-service-type): New procedure. > * doc/guix.texi (Power Management Services): Document it. > > Change-Id: Ib035d993ed82eec2a43f3ba2b4c92f77e08a0fd7 [=E2=80=A6] > +@quotation Important > +The @code{power-profiles-daemon} conflicts with other power management t= ools > +like @code{tlp}. Using both together is not recommended. s/like/such as/ s/Using.*/Pick one or the other./ What about UPower? Do I get it right that this actually builds upon UPower? Should it say a word about how it defers from TLP? > +(define (power-profiles-daemon-shepherd-service config) > + (match-record > + config > + (power-profiles-daemon) > + (list (shepherd-service (provision '(power-profiles-daemon)) > + (requirement '(dbus-system)) Rather: (requirement '(user-processes dbus-system)). > + (documentation "Run the power-profiles-daemo= n.") Nitpick: =E2=80=9CRun the Power Profiles Daemon=E2=80=9D. Also please indent this procedure similar to how this is done elsewhere. > + (description "Run the power-profiles-daemon")))) Same as above. :-) Thanks! Ludo=E2=80=99.