[bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-service-type.

["Ludovic Courtès" <ludo@gnu.org>]

Hi!

Dariqq <dariqq@posteo.net> skribis:

> * gnu/services/pm.scm
> (power-profiles-configuration): New configuration.
> (power-profiles-daemon-shepherd-service): New procedure.
> (power-profiles-daemon-activation): New variable.
> (power-profiles-daemon-service-type): New procedure.
> * doc/guix.texi (Power Management Services): Document it.
>
> Change-Id: Ib035d993ed82eec2a43f3ba2b4c92f77e08a0fd7

[…]

> +@quotation Important
> +The @code{power-profiles-daemon} conflicts with other power management tools
> +like @code{tlp}. Using both together is not recommended.

s/like/such as/
s/Using.*/Pick one or the other./

What about UPower?  Do I get it right that this actually builds upon
UPower?

Should it say a word about how it defers from TLP?

> +(define (power-profiles-daemon-shepherd-service config)
> +  (match-record
> +      config <power-profiles-daemon-configuration>
> +      (power-profiles-daemon)
> +    (list (shepherd-service (provision '(power-profiles-daemon))
> +			    (requirement '(dbus-system))

Rather: (requirement '(user-processes dbus-system)).

> +                            (documentation "Run the power-profiles-daemon.")

Nitpick: “Run the Power Profiles Daemon”.

Also please indent this procedure similar to how this is done elsewhere.

> +     (description "Run the power-profiles-daemon"))))

Same as above.  :-)

Thanks!

Ludo’.