From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id MKXsATtohmZRAwAAe85BDQ:P1 (envelope-from ) for ; Thu, 04 Jul 2024 09:15:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id MKXsATtohmZRAwAAe85BDQ (envelope-from ) for ; Thu, 04 Jul 2024 11:15:39 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GYNKWc8c; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720084538; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dxVaHYSLbvyFn+dlcLi1h+zvkXwUr2BdtNaQe+TqEhA=; b=p4pvZRIk/2x3GTVoW8TcJqRhNTjK3ZEJ78DwN1BUkqMtjOgfd4e37YDydOJfyf4+Qmk36j H0sg7J1LiKPGu0Qv3ANHNiacDkcqsbSSwdW2GvMy7PgQMdT+WaG3T99tvHA3Ked5+g8bzR N/ac48cilblj9Jhrgx+LlCEI3ZTWhZZv5iLc1agYp9PGIZCWwKA6SyZOwF6N0cfanzJDoF VgxYMYGVMkSjobJSTIZie0JtKJl9C0IhbOOCiQhiLPiUvqdIz0OiY6TnrH3lQjmQ1feDm0 Ns2Gi7Gjo2YCfWTn2oO7pYksdd1dlJEbVsfoLXuUW909v9fsVst1MOwYk7qnyg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GYNKWc8c; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720084538; a=rsa-sha256; cv=none; b=bdlqu5Md/KFCyvk7pNgcbYMXw6nVKnsYtUWKspnYOJUO0EDdHVqHEh2zspPKRxS+q8WRMM 362F+eUuvaOFpppfJM/Uu8TDJMCPRTFGy9Q1XK6ieG+2u3INxNE6hVPhD2QUFqygIauxwS BH8ohTULqom3ldE4P2+YA2TJmI2/eL8S5jv343dMNWtOnChXPWzT5OS4+BKKVVosSwdBjZ SrBu+FSGucRL4LUjG1sdvfS2sMXzfZPSvILHt04dRvRPdK4tPUSjgn0STdfNib7DRitxdA gjMKKIZfylV1PHMQKgJT1lvtHRVHp8CDawgUNq2OaxMOn+uW2CE20qrQZ1KGFg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D68623FBDF for ; Thu, 4 Jul 2024 11:15:37 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPIYV-0004pX-OH; Thu, 04 Jul 2024 05:15:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPIYO-0004kD-EM for guix-patches@gnu.org; Thu, 04 Jul 2024 05:15:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPIYO-0007sC-3L for guix-patches@gnu.org; Thu, 04 Jul 2024 05:15:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPIYQ-0007yG-Bd for guix-patches@gnu.org; Thu, 04 Jul 2024 05:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71038] [PATCH v2 1/2] guix: store: Enable specifying the available builtin builders. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Jul 2024 09:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71038 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Christopher Baines , 71038@debbugs.gnu.org Received: via spool by 71038-submit@debbugs.gnu.org id=B71038.172008446530574 (code B ref 71038); Thu, 04 Jul 2024 09:15:02 +0000 Received: (at 71038) by debbugs.gnu.org; 4 Jul 2024 09:14:25 +0000 Received: from localhost ([127.0.0.1]:41486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPIXp-0007x4-Dr for submit@debbugs.gnu.org; Thu, 04 Jul 2024 05:14:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPIXn-0007wq-Bf for 71038@debbugs.gnu.org; Thu, 04 Jul 2024 05:14:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPIXe-0005LY-3a; Thu, 04 Jul 2024 05:14:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=dxVaHYSLbvyFn+dlcLi1h+zvkXwUr2BdtNaQe+TqEhA=; b=GYNKWc8ctXRzin3ltMsk M+goNgJEL0wmGRDrwaMlJ+yDZMZsQ8T667SSzNp3J0v3/np7ZFaCLtJfpOdqYrLdRhpMOVeOd0bo1 7uSoI3l3ci0SUPqc8mZ+oyRZWyrWlcVQC4GhKw+ZSh+GbUS7LB9XxoLViZMWBB4y7hVhmFfSVDkSv TtiDzOTiudNqYJhk1h8u8UYuvZ28kss3G94tPtfecs2garX1Pr9/AibpH/PFCV7mQMkaUGoG5J185 9zffp2giCuK1iE2AJjIZkPEK0hQCPw/XSPfr7kAjsEWIfit9bOUd8ogBHOAr4XPNcHWchhC1HGxjJ Y8l15TCRauDXDQ==; In-Reply-To: (Christopher Baines's message of "Mon, 24 Jun 2024 14:43:45 +0100") References: <87y187b6xv.fsf@cbaines.net> Date: Thu, 04 Jul 2024 11:14:07 +0200 Message-ID: <87msmx7c4g.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: =?utf-8?q?Ludovic_Court=C3=A8s_via_Guix-patches?= Reply-To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: D68623FBDF X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -5.79 X-Spam-Score: -5.79 X-TUID: 96lheEKJZ9zy Hello! Summarizing our live review session here=E2=80=A6 Christopher Baines skribis: > To open-connection and port->connection. This overrides the discovered > builtin builders that the daemon says it provides. > > This is useful when you want to generate compatible derivations that can = be > run with a daemon that potentially doesn't support builtin builders that = the > daemon you're using to generate the derivations has. > > I'm looking at this in particular because I want to use this in the data > service, since it provides substitutes for derivations, and since these c= an be > built on other machines, it's useful to control which builtin builders th= ey > depend on. > > * guix/store.scm (open-connection, port->connection): Accept > #:assume-available-builtin-builders and use this instead of > %built-in-builders. > > Fixes: . > > Change-Id: I45d58ab93b6d276d280552858fc81ebc2b58828a This is nice. Nitpick: you can drop =E2=80=9Cguix:=E2=80=9D from the commi= t message subject. > (define* (open-connection #:optional (uri (%daemon-socket-uri)) > #:key port (reserve-space? #t) cpu-affinity > - non-blocking?) > + non-blocking? assume-available-builtin-builder= s) My only suggestion here is to rename =E2=80=98assume-available-builtin-buil= ders=E2=80=99 to just =E2=80=98built-in-builders=E2=80=99 (so that it=E2=80=99s a noun ra= ther than a phrase). Ludo=E2=80=99.