From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id aBPPBV8ljWagPAAAe85BDQ:P1 (envelope-from ) for ; Tue, 09 Jul 2024 11:56:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id aBPPBV8ljWagPAAAe85BDQ (envelope-from ) for ; Tue, 09 Jul 2024 13:56:15 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="hyV/h4yk"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720526174; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=rGUq9F159fy5tuu0Qz2HoXB+DOKaeuCG0oOeP6HZKrg=; b=upG1Mh+TRUfyJ5/hKm4h8b6J+mNShXx1d2p7Go9xwgrFXAmI+y5utql2LHtc4hMpADL+D8 p6ghZn5voP6oyCcLZVD+5WG9lNHNg6s+oEkTgpPMzavoA4+/h/nIdXReH1YO+Th65P52o/ Kq+zVhTvKOgLAr/v7QTkzAGNYqrKbIHHerAJPvrWon6PFUpr0eckbdIbSvLU3mk6Ny0C1u B6d0Z98fLSAl5pZWzKdXdlivQNilNT3VaLfCY7qaUvcZydjTzP1SRbIJhbMCOBcuDQ/xt/ 2eI1gaoINkexI4MHBLF11MIaSqfN3EwpujkIcgbWY4RjPFMNA0jR3vqZ4iH2lg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="hyV/h4yk"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720526174; a=rsa-sha256; cv=none; b=tfLYhd7zqm1Mke3BhNn1PzXR9XBFFatxtWA0Yfo13VTxWNdv5c8ewSRbZafWdUmznKaR/h zATZu6Uw/PbJFlNeH87ZpyKXr26EjofH+3LlaDfICC5sCvWWuSDt8nFD7E0jLLAbUZW2kP uBQGBJHOqyV+PVj0dpivpBIX7qsdhOHcFhpdupJBIM6iQx9gYfhSVJCWvixyCpioQCVjsg IZzwF1JiHvaHi9Pvb5c97rSVnkWrGKG5UJ1w//dUyBwtJTZQPW+4Ras7v+vsTGrFUy3mRT r02A84JNtvtFYmCsIE3hMMA1Z0aM5Or+rqmKKGqAq9qmALK5WLrML7rRpKkkvA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 959C6FDA6 for ; Tue, 9 Jul 2024 13:56:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sR9Ru-0001M1-MO; Tue, 09 Jul 2024 07:55:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sR9Rt-0001GU-DY for guix-patches@gnu.org; Tue, 09 Jul 2024 07:55:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sR9Rt-0007Fz-3l for guix-patches@gnu.org; Tue, 09 Jul 2024 07:55:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sR9Ry-0005b9-6F for guix-patches@gnu.org; Tue, 09 Jul 2024 07:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71897] [PATCH 4/5] gnu: Add libprisma-for-telegram-desktop. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jul 2024 11:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71897 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: dan Cc: 71897@debbugs.gnu.org Received: via spool by 71897-submit@debbugs.gnu.org id=B71897.172052615321502 (code B ref 71897); Tue, 09 Jul 2024 11:56:02 +0000 Received: (at 71897) by debbugs.gnu.org; 9 Jul 2024 11:55:53 +0000 Received: from localhost ([127.0.0.1]:52265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sR9Rp-0005ak-5D for submit@debbugs.gnu.org; Tue, 09 Jul 2024 07:55:53 -0400 Received: from mail-qv1-f52.google.com ([209.85.219.52]:61465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sR9Rm-0005aH-ER for 71897@debbugs.gnu.org; Tue, 09 Jul 2024 07:55:51 -0400 Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6b2c95b6c5aso26855986d6.2 for <71897@debbugs.gnu.org>; Tue, 09 Jul 2024 04:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720526078; x=1721130878; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:cc:references:in-reply-to :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=rGUq9F159fy5tuu0Qz2HoXB+DOKaeuCG0oOeP6HZKrg=; b=hyV/h4ykd9h1+Qb8YLZh+zeNHmASlqyyzMv2quBcC1GtJJBCjDwaayoBI6FxPJzfKX p8xnzWILUXuKcbfFTfo9arVe8ZuJBy1uB7PDYf2slGnGCZAh5M1IZZ3gJAgQI7MfEIGj bpsF+oGxvV6xC4eqoRl7ugycH0MNvDPZYnvNmDq1evvXmwgxAuKy3tuymBGjcgVJevz3 N2WAKOK2yZqlWx+FLTbIinkIM7N4fGNRn/PSAU4zlLYQxMxuEjvCjJwn1fdstartbYBM jZwfU0fAvWgv0EMpcNCcxuziAeYlkcHykcscFYFUZ2JB3u2SeaWFcsUgS5GnSjvn1qE1 Qp5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720526078; x=1721130878; h=mime-version:user-agent:message-id:date:cc:references:in-reply-to :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rGUq9F159fy5tuu0Qz2HoXB+DOKaeuCG0oOeP6HZKrg=; b=rzHLlooiDqyaWEq7I770IgNkdhEmmDD32jXuONLlzAW1wIz5xv/yPSh5CZogxZlEcJ kCuooGNl6ca+Z+GvR9k0fSMW9Gf0BhDXG39Rsw+nOcmxVflP9K8sbUQlsSr4TJp7D7DC fWBOplmDeHXAiCqPBjLO47/BQLEMH36gtGHpHNA6cyw/YcxosqAOuhqtHAKxmC9Ll+K8 d1lRCAIB1VrdeJYq4CZgjDQtIge+OJ6pIzLSmnMWSkOH21uObWawHLFm14eR3W3cv8v1 oXHrx9/tLCoNuDWrqrtrj+kOGv9OGTPfLUlpSsr6u1j790ayZSF89lHUYIZdQhi6gCZH AJTA== X-Gm-Message-State: AOJu0YxuP+rNaMbnj3x+rCEAUu6E6cJz9j6R4K7EYYRALNXqgxsUwTqK 5+7+ZVnTGpqx0ztiPzJxgJqMCo0SmsWahgnXowjSKgO2uiJKgssY3JRxPg== X-Google-Smtp-Source: AGHT+IGgpAEKJBfwgsImWN4XQa39XSpeq9n+HuT7R7QoHM5C4s79ap8bPg4kWg02RNvum7YuIxvuBw== X-Received: by 2002:ad4:5ccc:0:b0:6a9:b253:58d5 with SMTP id 6a1803df08f44-6b61bca11a1mr28750056d6.17.1720526078015; Tue, 09 Jul 2024 04:54:38 -0700 (PDT) Received: from hurd (dsl-205-236-230-124.b2b2c.ca. [205.236.230.124]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b61ba73de5sm8081266d6.98.2024.07.09.04.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 04:54:37 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: (dan's message of "Tue, 9 Jul 2024 10:53:45 +0800") References: <3743fa793bf867b8112b2883815b573f955c12ce.1720364199.git.i@dan.games> <80dd2fffb3b605252f0cbea2bf802e8345c15eec.1720364199.git.i@dan.games> <87cynnxppn.fsf@gmail.com> Date: Tue, 09 Jul 2024 07:54:36 -0400 Message-ID: <87msmqwzk3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.60 X-Migadu-Queue-Id: 959C6FDA6 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 2.60 X-TUID: Tr+/YKvVM6a3 Hi Dan, dan writes: > Hi Maxim, > > On 7/9/2024 10:29 AM, Maxim Cournoyer wrote: >> Hi, >> dan writes: >> >>> * gnu/packages/telegram.scm (libprisma-for-telegram-desktop): New variable. >>> >>> Change-Id: I855b463993654a8cad491c7b56c9581b3083f5e4 >>> --- >>> gnu/packages/telegram.scm | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/gnu/packages/telegram.scm b/gnu/packages/telegram.scm >>> index 26ab27293f..0a48361eb4 100644 >>> --- a/gnu/packages/telegram.scm >>> +++ b/gnu/packages/telegram.scm >>> @@ -400,6 +400,18 @@ (define cld3-for-telegram-desktop >>> (base32 >>> "0ayrrhfdwrf4260h9fsirkhhfrcvc3qqnh6h9wj3ixij2lq0wwqb")))) >>> +(define libprisma-for-telegram-desktop >>> + (origin >>> + (method git-fetch) >>> + (uri (git-reference >>> + (url "https://github.com/desktop-app/libprisma") >>> + (commit "23b0d70f9709da9b38561d5706891a134d18df76"))) >>> + (file-name >>> + (git-file-name "libprisma-for-telegram-desktop" "5.2.3")) >>> + (sha256 >>> + (base32 >>> + "0fg4x4ikj7f3706bmfvkwq4smxc98qr3cgpm25w48n4ys6wfgadg")))) >>> + >> So this is built as part of telegram? If this doesn't have any >> proper >> build system to be built separately and linked, or if telegram lacks >> such a feature in its own build system (I like to report such feature >> request for that to upstream myself), another perhaps more maintainable >> strategy would be to use recursive? #t on the git-reference to clone >> these, and delete in a source snippet the submodules we don't want to >> have. > > Most of the dependencies of telegram-desktop are packaged this way, so > here I'm more or less following the convention. de If we decide to use > recursive? #t, I think it's better to fully revamp the packaging of > telegram-desktop. libprisma itself doesn't have a build system, and I > think it's only used in telegram-desktop. OK, fair enough. Thanks for the explanation (I also noticed the tens of git submodules as source variables in a later commit). Reviewed-by: Maxim Cournoyer -- Thanks, Maxim