From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id EBzUGOr8k2bIowAAqHPOHw:P1 (envelope-from ) for ; Sun, 14 Jul 2024 16:29:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id EBzUGOr8k2bIowAAqHPOHw (envelope-from ) for ; Sun, 14 Jul 2024 18:29:30 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=YNmdqzzw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720974570; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VYMQnuRHOH8uO6u2ndptssC0bBofnSWEnLrgSGZ1Yfo=; b=MMuGCqHWXOJNYrL9q47NjkvTZdcwfe3C/QciW0tVLhgjAurCdW/Jd6cFGOawN4sFiA9lXZ kHcmL+x3WR3VFN/2AHYP58IDeE6pU/nY5VYiHwYOGSf7UohYphMLhYf/6anUgjj3776JpS OSGI6CaMhHPXxmHjcTJB06BYmJc0Mzf2EM/Njr/6pbOgbWehQFaCHYgejvwLHMosMXR0UD ob0+uYA8J/tjvisfqEbw9woJ5GCCihy2XS76vf3LrvTdRR7cuF9Wv81LeESbOZ7qfnaOlb Tn2wDdAlSGVympc/f5J3FpFbbuglMFaP7vBxgv57pLRgVeL+euMnZzMamEY0WQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720974570; a=rsa-sha256; cv=none; b=IAHF99H5GPJCIwn62aNAaYIY0/g55HrSLuealRVEqhq+/bKSL9KagA05RU9HWz1pKAOw1Q Q2PtUznqbeNl63RgcXSu5uikJl6VEEiEKFX4XSb0bfNkPfMenFxmeQKcdp1oVghJpQmyBD WmPHWcddIs+xvkjBir0H3bqrzm9mrcwaOq7niHrQc47CeFV5lGyG0Y6ZIlh9NeqjgRccrh JqTPV/E7jo5tiVTBIFEG0AjzIChvbtNpwEZNq5YzXZ/EjxKaY7X3d1wVHZYyolPQCG83C4 ggQ+gMbByI8lirJN1LT7a06BxG0OnPtDwOkTsPpfqH91CjAgxwb1wi8X2XfGZg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=YNmdqzzw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1D6541466B for ; Sun, 14 Jul 2024 18:29:30 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sT25v-0006v7-RC; Sun, 14 Jul 2024 12:29:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sT25t-0006uq-4b for bug-guix@gnu.org; Sun, 14 Jul 2024 12:29:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sT25s-0007J8-He for bug-guix@gnu.org; Sun, 14 Jul 2024 12:29:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sT25t-00030L-Np for bug-guix@gnu.org; Sun, 14 Jul 2024 12:29:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#72045: Emacs graft lookup still fails Resent-From: Suhail Singh Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 14 Jul 2024 16:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72045 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: 72045@debbugs.gnu.org, Suhail Singh Received: via spool by 72045-submit@debbugs.gnu.org id=B72045.172097451111511 (code B ref 72045); Sun, 14 Jul 2024 16:29:01 +0000 Received: (at 72045) by debbugs.gnu.org; 14 Jul 2024 16:28:31 +0000 Received: from localhost ([127.0.0.1]:58503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT25P-0002zb-6L for submit@debbugs.gnu.org; Sun, 14 Jul 2024 12:28:31 -0400 Received: from mail-qv1-f65.google.com ([209.85.219.65]:41833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT25N-0002zL-F5 for 72045@debbugs.gnu.org; Sun, 14 Jul 2024 12:28:29 -0400 Received: by mail-qv1-f65.google.com with SMTP id 6a1803df08f44-6b605c48717so1915026d6.3 for <72045@debbugs.gnu.org>; Sun, 14 Jul 2024 09:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720974442; x=1721579242; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VYMQnuRHOH8uO6u2ndptssC0bBofnSWEnLrgSGZ1Yfo=; b=YNmdqzzwV/vpEYRzBojlu9vBYpw9IyAQcFjQGqVlaYFSjaSe9YdhFGNW8qQ682YeEI 2KTNRxrCmW32awJIXCT2wEMLd3StGmZcYeN4ntEWK0H1TbSoCUi5aVpbTLuTp8h7OaIk h0DGFnc5mffa5yBPkLqYKSeelfGSUDwf2xYiNJolI+wBIthEnSq8nkqdPAy0Qtfw3EMG pOvz5OvOrlL8g5ftn4vwE3VOz7RJ4KFqYRhAbH1SK+2N9C0+bg6Twp4bdNSgLGvTs7ss Y87pmI5yCHVJTVRQfWHmu7FwwxRWrBRIwquyCd1Cy5Ql8xOUcA7SdSz34mvSTi2+Z8/C TfYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720974442; x=1721579242; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VYMQnuRHOH8uO6u2ndptssC0bBofnSWEnLrgSGZ1Yfo=; b=qQuDb/CISVSWinaYGMfFH1XwnzGB2P8a25ftS1hIpWiNByp+5s3824kRzDc1P1ZwVk 6jODDIHjTFBhqZO1XzD15/WmBTIEdB7abaio+KBdE+ytH12FIOv6etE8JUW9W2dkB3vB SCxr0xVJ9AJYBnu6+tyNkh9nbO2nXBZ1TiWWkMOZb57BEOIlUF52jWIn/9zM68/4Rzib 3I6caYsIbfaiLlqKFygITOBqFPsaC7Mc+pXj4Al5rpa1ieoQYYS642iG+6sOsYyNJywZ SgOPthdBRn8Yin3MdFlb0UEB8RI5O8ilYQ0h2MkZg699uDgEMaVN9zt4yvawB5cFWja+ Wd9w== X-Forwarded-Encrypted: i=1; AJvYcCUsWyEb4Ip009n8T1A60rxCGb0N1EdQkJboig3afPv3GC923tdTkrDDxJs0ABMftpaNYkS7xb9u46yII42YBdgxmpCHbGo= X-Gm-Message-State: AOJu0YworMfUh7/MAPVGwUitUp1rI2nFH03tIINavXBmu3aIyPvWWgOP JFr//NRnV9lnaKTj6Ui+CfHSF9oMrhywi2nJi/EbyxidjzgsfXup+lAqNAfq X-Google-Smtp-Source: AGHT+IEwbmHbKDiuEkGlkFYgJZ3TGso/fAkw1tPoHLDgQWEIjcslKCqPB3V6AeFJBqf0RUACFIbToA== X-Received: by 2002:a05:620a:4725:b0:7a1:5683:51cf with SMTP id af79cd13be357-7a15683520bmr549527485a.10.1720974441935; Sun, 14 Jul 2024 09:27:21 -0700 (PDT) Received: from gnus ([65.93.169.47]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a160bbe26asm130576685a.33.2024.07.14.09.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jul 2024 09:27:21 -0700 (PDT) From: Suhail Singh In-Reply-To: <6cbb251b1fd031428ec254e401f01777084d1dc0.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 14 Jul 2024 10:50:41 +0200") References: <87zfqkho6x.fsf@gmail.com> <6cbb251b1fd031428ec254e401f01777084d1dc0.camel@gmail.com> Date: Sun, 14 Jul 2024 12:27:10 -0400 Message-ID: <87msmkos69.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 1D6541466B X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.30 X-Spam-Score: -5.30 X-TUID: 3qTOtdoRbzi8 Liliana Marie Prikler writes: >> IIUC, the issue is that replacement packages are grafted post-build. >> This means that when emacs-dash is built, its AOT native-compilation >> happens with Emacs 29.3.=C2=A0 However, at run-time Emacs 29.4 gets >> grafted in. > Nitpick: Emacs 29.4 gets grafted in at profile-building time. Agreed; thanks for the correction. >> There are at least two possible ways (ignoring feasibility) to >> resolve this: >>=20 >> 1. When emacs-dash etc. is being built we use Emacs 29.4 for native >> =C2=A0=C2=A0 compilation. > That kinda defeats the point of grafting, though. At this point, > rebuilding with newer Emacs makes more sense. I agree, and that is what I am leaning towards. The main concern I have is that it's not directly apparent based on the package version whether the ABI_VERSION has been bumped or not. As such, any time a Guix packager proposes a replacement, the patch reviewer has to manually review the Emacs source to ensure that the ABI_VERSION has not been bumped. Unless there is an automated way to ensure that, this would increase the maintenance overhead in Guix (as compared to a comment noting that grafts for Emacs aren't recommended). However, perhaps there is a way to ensure that the proposed replacement doesn't have a different ABI_VERSION. Could this be caught by a test or "sanity checker" of some kind? >> 2. When emacs-dash etc. is being built we use Emacs 29.3 for native >> =C2=A0=C2=A0 compilation, but ensure that said files are transferred to a >> location where Emacs 29.4 is able to find them. > Given that the ABI hash is used to guard against loading outdated > libraries like this, I'm not sure whether this makes too much sense. I > think what we would need is something like=20 > > 3. Accurately capture the compatibility between Emacs-used-to-compile > and Emacs-used-to-run. I.e. find a way to enable Emacs cross > compilation. I see. Now your RFC patch regd. dropping the version prefix from the .eln path makes sense. The intent being to allow grafting to work with AOT native compilation as long as ABI_VERSION remains the same. > Perhaps upstream already has some ideas on this, perhaps not. Hopefully upstream also has some thoughts as to where assertions regd. the validity of package replacements could be tested. >> Which do we desire?=C2=A0 My belief is that 1 is what we need, and that >> doing 2 may be inadequate for ensuring that appropriate security >> fixes are deployed (consider the case where the bug is in a macro in >> Emacs core). > I think 1 could be accomplished with a build system hack, but see > above. Noted, thank you for the elaboration. --=20 Suhail