all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Sergey Trofimov <sarg@sarg.org.ru>
To: Apoorv Singh <apoorvs569@gmail.com>
Cc: 73465@debbugs.gnu.org
Subject: [bug#73465] [PATCH] Wireguard: Rename field private-key to private-key-file
Date: Thu, 26 Sep 2024 19:39:38 +0200	[thread overview]
Message-ID: <87msju1fhh.fsf@sarg.org.ru> (raw)
In-Reply-To: <87h6a4jsej.fsf@gmail.com>

Apoorv Singh <apoorvs569@gmail.com> writes:

> The following patches renames the field private-key to private-key-file as it
> makes it more clear that it needs path to a file rather than the key it self
>

Hi, you have to deprecate the field instead using
`warn-about-deprecation` procedure and to adjust the documentation as
well.

Please note that there is also preshared-key parameter which also takes
a path. It'd be nice to rename it as well for consistency sake.




  reply	other threads:[~2024-09-26 19:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25  3:58 [bug#73465] [PATCH] Wireguard: Rename field private-key to private-key-file Apoorv Singh
2024-09-26 17:39 ` Sergey Trofimov [this message]
2024-09-28  5:29 ` [bug#73465] " Apoorv Singh
2024-09-30  7:04 ` Apoorv Singh
2024-10-05  3:35 ` [bug#73465] Wireguard: Deprecate and rename fields Apoorv Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msju1fhh.fsf@sarg.org.ru \
    --to=sarg@sarg.org.ru \
    --cc=73465@debbugs.gnu.org \
    --cc=apoorvs569@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.