From: Janneke Nieuwenhuizen <janneke@gnu.org>
To: 74798@debbugs.gnu.org
Cc: 74798-done@debbugs.gnu.org, Rutherther <rutherther@ditigal.xyz>
Subject: [bug#74798] [PATCH] gnu: gdb: Ensure configure-flags are appended to original package
Date: Wed, 11 Dec 2024 21:02:49 +0100 [thread overview]
Message-ID: <87msh22djq.fsf@gnu.org> (raw)
In-Reply-To: <da50345c588967a3e4332bd96b3c927657e3df4e.1733945442.git.rutherther@ditigal.xyz> (Rutherther via Guix-patches via's message of "Wed, 11 Dec 2024 20:35:45 +0100")
Rutherther via Guix-patches via writes:
Hello,
> Since recently there has been a change to gdb package that introduced
> configure-flags, three gdb packages broke, since they assumed there are no
> configure-flags in gdb. That means they produced the same gdb as gdb-14.
>
> * gnu/packages/embedded.scm (make-gdb-arm-none-eabi)[arguments]: Append
> configure-flags to original flags.
> * gnu/packages/gdb.scm (gdb-multiarch)[arguments]: Append
> configure-flags to original flags.
> * gnu/packages/gdb.scm (avr-gdb)[arguments]: Append
> configure-flags to original flags.
>
> Change-Id: Ia8748b86dc72197bd4eef307d091b6af44fc5611
Thank you! And sorry for breaking things :)
I've changed the commit message to
--8<---------------cut here---------------start------------->8---
gnu: gdb: Fix build of target-specific variants.
This is a follow-up to commit
baf4a3330762d184f5b10846151a9e3afd7c3dbe
gnu: Add gdb-15.2, with support for the 64bit Hurd.
That commit changed the gdb package, introducing #:configure-flags, breaking
three gdb packages, since they assumed there are no #:configure-flags in gdb.
That means they produced the same gdb as gdb-14.
This patch fixes that by ensuring #:configure-flags are appended to original
package.
* gnu/packages/embedded.scm (make-gdb-arm-none-eabi)[arguments]:
Append #configure-flags to original flags.
(gdb-multiarch)[arguments]: Likewise.
(avr-gdb)[arguments]: Likewise.
--8<---------------cut here---------------end--------------->8---
and pushed to master as 98908e0777889aeec2796dbdc4f0809a1898dd3b.
Greetings,
Janneke
--
Janneke Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com
prev parent reply other threads:[~2024-12-11 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 19:35 [bug#74798] [PATCH] gnu: gdb: Ensure configure-flags are appended to original package Rutherther via Guix-patches via
2024-12-11 20:02 ` Janneke Nieuwenhuizen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msh22djq.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=74798-done@debbugs.gnu.org \
--cc=74798@debbugs.gnu.org \
--cc=rutherther@ditigal.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.