all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Sisiutl <sisiutl@egregore.fun>
Cc: 73654@debbugs.gnu.org, Tomas Volf <~@wolfsden.cz>
Subject: [bug#73654] [PATCH] gnu: luks-device-mapping-with-options: Add allow-discards? argument.
Date: Sun, 15 Dec 2024 17:31:10 +0100	[thread overview]
Message-ID: <87msgwj4c1.fsf@gnu.org> (raw)
In-Reply-To: <20241006094239.7157-1-sisiutl@egregore.fun> (sisiutl@egregore.fun's message of "Sun, 6 Oct 2024 11:42:28 +0200")

Hi,

(Cc: Tomas, who I believe initially worked on this.)

Sisiutl <sisiutl@egregore.fun> skribis:

> * gnu/system/mapped-devices.scm (luks-device-mapping-with-options): Add allow-discards? argument.
>
> Change-Id: I0a43c13570a223d17698c7fe9ef4607e587bb8d0

> -\f
> +

This is a linefeed and it facilitates navigation in the file; please
preserve it.  :-)

> +(define* (open-luks-device source targets #:key key-file allow-discards?)
>    "Return a gexp that maps SOURCE to TARGET as a LUKS device, using
>  'cryptsetup'."

Please briefly document ‘allow-discards?’ in the docstring…

> +(define* (luks-device-mapping-with-options #:key key-file allow-discards?)
>    "Return a luks-device-mapping object with open modified to pass the arguments
>  into the open-luks-device procedure."

… also here, and also in a bit more detail in the relevant place in
‘doc/guix.texi’.

Thanks in advance!

Ludo’.




      parent reply	other threads:[~2024-12-15 16:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-06  9:42 [bug#73654] [PATCH] gnu: luks-device-mapping-with-options: Add allow-discards? argument Sisiutl
2024-11-06 13:57 ` Hilton Chain via Guix-patches via
2024-12-15 16:31 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msgwj4c1.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=73654@debbugs.gnu.org \
    --cc=sisiutl@egregore.fun \
    --cc=~@wolfsden.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.