all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH] Add tcsh.
Date: Tue, 05 Feb 2013 09:56:47 +0100	[thread overview]
Message-ID: <87lib3uoj4.fsf@gnu.org> (raw)
In-Reply-To: <511038D3.6020404@gmail.com> (Cyril Roelandt's message of "Mon, 04 Feb 2013 23:40:19 +0100")

Cyril Roelandt <tipecaml@gmail.com> skribis:

> On 02/04/2013 11:32 PM, Ludovic Courtès wrote:
>> Cyril Roelandt<tipecaml@gmail.com>  skribis:
>>
>>> This patch adds tcsh. It was a bit hard to make the testsuite work: I disabled a
>>> few tests that I could not get working during the "check" phase, but it should
>>> not be a problem, since they work fine with the installed binary.
>>
>> Good!
>
> Not so good: it's way too weird that some tests fail when running
> "make check", it'd be great to understand why.

If it’s deterministic, that shouldn’t be too difficult.  Most likely a
/bin/sh or similar issue, no?

>>
>>> +    (inputs
>>> +     `(("autoconf" ,autoconf)
>>> +       ("coreutils" ,coreutils)
>>> +       ("ncurses" ,ncurses)
>>> +       ("patch/skip-tests"
>>> +        ,(search-patch "tcsh-fix-autotest.patch"))))
>>
>> In general, rebuilding the build infrastructure with Autoconf&
>> co. should be avoided for several reasons: we may get it wrong, and it
>> will yield a rebuild on every Autoconf update.
>>
>> Could this be easily avoided here?  (I suspect you already tried...)
>> One option would be to make the patch against ‘testsuite’ instead of
>> against the .at files, with the risk of it no longer being applicable on
>> the next release.
>>
>> WDYT?
>
> It would make sense patch the .at files, generate a new "testsuite"
> file, and patch "testsuite" when running make check. But it would be
> nice to keep the *.at files somewhere to quickly regenerate the patch
> against "testsuite" when a new version of tcsh comes out. Can we do
> that ?

Seems tricky to me.  Better keep your current version than do that, I
think.

So what about patching ‘testsuite’ directly?  Did it seem feasible here?

Thanks,
Ludo’.

  reply	other threads:[~2013-02-05  8:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04 21:27 [PATCH] Add tcsh Cyril Roelandt
2013-02-04 22:32 ` Ludovic Courtès
2013-02-04 22:40   ` Cyril Roelandt
2013-02-05  8:56     ` Ludovic Courtès [this message]
2013-02-06  1:38   ` Cyril Roelandt
2013-02-06 14:17     ` Ludovic Courtès
2013-02-07  0:04       ` Cyril Roelandt
2013-02-07  0:09         ` [PATCH v2] " Cyril Roelandt
2013-02-07  9:29           ` Andreas Enge
2013-02-07 10:10             ` Cyril Roelandt
2013-02-07 10:34               ` Andreas Enge
2013-02-07 10:56                 ` Ludovic Courtès
2013-02-10 20:57                   ` [PATCH v3] gnu: " Cyril Roelandt
2013-02-10 21:44                     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lib3uoj4.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=bug-guix@gnu.org \
    --cc=tipecaml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.