From: Mark H Weaver <mhw@netris.org>
To: Guy Grant <tadnimi@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Fwd: [PATCH] Add font-terminus.
Date: Sun, 10 Aug 2014 23:21:59 -0400 [thread overview]
Message-ID: <87lhqvr9rc.fsf@yeeloong.lan> (raw)
In-Reply-To: <CABXEMcoXXbf7Tj465Rv92nrd2sdTOxfXgCR2=MNeO-T2BpyPcQ@mail.gmail.com> (Guy Grant's message of "Sun, 10 Aug 2014 09:25:59 -0500")
Guy Grant <tadnimi@gmail.com> writes:
> Okay, patch updated as recomended; Patch attatched. Again, if
> something looks wrong -- feel free to comment. Thanks!
>
>
> From 3244099f65c1c6bd99d6b0921213c0749e04be47 Mon Sep 17 00:00:00 2001
> From: Guy Grant <tadnimi@gmail.com>
> Date: Sun, 10 Aug 2014 08:58:08 -0500
> Subject: [PATCH 1/1] add terminus-font
>
> ---
This needs a proper commit message. Look in the git logs for examples.
> + (inputs
> + `(("bdftopcf" ,bdftopcf)
> + ("font-util", font-util)
> + ("mkfontdir" ,mkfontdir)
> + ("perl" ,perl)))
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
I suspect that all of those inputs should instead be native-inputs. If
the code in those packages is executed at build time, then they should
be native-inputs. If the code is executed at run-time, they should be
normal inputs. The distinction is important when cross compiling.
> + (arguments
> + `(#:configure-flags (list
> + ;; install fonts into subdirectory of package output instead of
> + ;; font-util-?.?.?/share/fonts/X11
> + (string-append "--with-fontrootdir=" %output "/share/fonts/X11"))
> + #:tests? #f)) ;; No test target in tarball
Please fix the indentation here.
> + (home-page "http://terminus-font.sourceforge.net/")
> + (synopsis "Simple bitmap programming font")
> + (description "Terminus Font is a clean, fixed width bitmap font, designed for long
> + (8 and more hours per day) work with computers.")
> + (license
> + (license:x11-style
> + "http://scripts.sil.org/cms/scripts/page.php?item_id=OFL_web"))))
Otherwise looks good to me.
Thanks!
Mark
next prev parent reply other threads:[~2014-08-11 3:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 0:15 [PATCH] Add font-terminus Guy Grant
2014-08-10 10:04 ` Andreas Enge
[not found] ` <CABXEMcpNkYY_Xdq+Op-9Lh35L3BeEMea9tVk3ZeALmtegOxXUQ@mail.gmail.com>
2014-08-10 14:25 ` Fwd: " Guy Grant
2014-08-10 18:39 ` Andreas Enge
2014-08-11 3:21 ` Mark H Weaver [this message]
2014-08-13 1:37 ` Guy Grant
2014-08-13 3:23 ` mhw
2014-11-10 15:34 ` Alex Kost
2014-11-10 22:18 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhqvr9rc.fsf@yeeloong.lan \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=tadnimi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.