[PATCH] packages: Remove dead code.

[PATCH] packages: Remove dead code.

[Alex Kost]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

If I understand correctly, ‘_’ is redundant in “gnu/packages.scm” as it
is already defined in (guix ui).

Also I fixed a double space in this commit (not sure if it's acceptable
here).  Also if this patch is OK, should a commit message be improved
somehow?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-packages-Remove-dead-code.patch --]
[-- Type: text/x-diff, Size: 984 bytes --]

From 376f974e1adad42882985cfc94f2ef4fde127948 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Sun, 17 Aug 2014 21:49:16 +0400
Subject: [PATCH] packages: Remove dead code.

* gnu/packages.scm (_): Remove.
  Remove an extra space.
---
 gnu/packages.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages.scm b/gnu/packages.scm
index 77d9d3e..83093a4 100644
--- a/gnu/packages.scm
+++ b/gnu/packages.scm
@@ -50,8 +50,6 @@
 ;;;
 ;;; Code:
 
-(define _ (cut gettext <> "guix"))
-
 ;; By default, we store patches and bootstrap binaries alongside Guile
 ;; modules.  This is so that these extra files can be found without
 ;; requiring a special setup, such as a specific installation directory
@@ -60,7 +58,7 @@
 
 (define %patch-path
   (make-parameter
-   (map (cut string-append <>  "/gnu/packages/patches")
+   (map (cut string-append <> "/gnu/packages/patches")
         %load-path)))
 
 (define %bootstrap-binaries-path
-- 
2.0.3

Re: [PATCH] packages: Remove dead code.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> If I understand correctly, ‘_’ is redundant in “gnu/packages.scm” as it
> is already defined in (guix ui).

Indeed, applied.

> Also I fixed a double space in this commit (not sure if it's acceptable
> here).

That’s fine, IMO.  If this were a wider change, like removing all
trailing whitespaces in one file or another, that would have to be a
different commit for clarity.

> Also if this patch is OK, should a commit message be improved somehow?

The commit message is good.  Perhaps you wouldn’t even need to mention
the space removal.

Thanks,
Ludo’.