From: Alex Kost <alezost@gmail.com>
To: guix-devel@gnu.org
Subject: [PATCH] packages: Remove dead code.
Date: Sun, 17 Aug 2014 22:09:07 +0400 [thread overview]
Message-ID: <87lhqnc7jw.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
If I understand correctly, ‘_’ is redundant in “gnu/packages.scm” as it
is already defined in (guix ui).
Also I fixed a double space in this commit (not sure if it's acceptable
here). Also if this patch is OK, should a commit message be improved
somehow?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-packages-Remove-dead-code.patch --]
[-- Type: text/x-diff, Size: 984 bytes --]
From 376f974e1adad42882985cfc94f2ef4fde127948 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Sun, 17 Aug 2014 21:49:16 +0400
Subject: [PATCH] packages: Remove dead code.
* gnu/packages.scm (_): Remove.
Remove an extra space.
---
gnu/packages.scm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/gnu/packages.scm b/gnu/packages.scm
index 77d9d3e..83093a4 100644
--- a/gnu/packages.scm
+++ b/gnu/packages.scm
@@ -50,8 +50,6 @@
;;;
;;; Code:
-(define _ (cut gettext <> "guix"))
-
;; By default, we store patches and bootstrap binaries alongside Guile
;; modules. This is so that these extra files can be found without
;; requiring a special setup, such as a specific installation directory
@@ -60,7 +58,7 @@
(define %patch-path
(make-parameter
- (map (cut string-append <> "/gnu/packages/patches")
+ (map (cut string-append <> "/gnu/packages/patches")
%load-path)))
(define %bootstrap-binaries-path
--
2.0.3
next reply other threads:[~2014-08-17 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-17 18:09 Alex Kost [this message]
2014-08-19 21:09 ` [PATCH] packages: Remove dead code Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhqnc7jw.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.