From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] packages: Remove dead code. Date: Tue, 19 Aug 2014 23:09:50 +0200 Message-ID: <87lhqk9of5.fsf@gnu.org> References: <87lhqnc7jw.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK1WX-0007gh-7r for guix-devel@gnu.org; Wed, 20 Aug 2014 04:45:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XK1WM-0002al-7h for guix-devel@gnu.org; Wed, 20 Aug 2014 04:45:41 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:39928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK1WL-0002a1-VB for guix-devel@gnu.org; Wed, 20 Aug 2014 04:45:30 -0400 In-Reply-To: <87lhqnc7jw.fsf@gmail.com> (Alex Kost's message of "Sun, 17 Aug 2014 22:09:07 +0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > If I understand correctly, =E2=80=98_=E2=80=99 is redundant in =E2=80=9Cg= nu/packages.scm=E2=80=9D as it > is already defined in (guix ui). Indeed, applied. > Also I fixed a double space in this commit (not sure if it's acceptable > here). That=E2=80=99s fine, IMO. If this were a wider change, like removing all trailing whitespaces in one file or another, that would have to be a different commit for clarity. > Also if this patch is OK, should a commit message be improved somehow? The commit message is good. Perhaps you wouldn=E2=80=99t even need to ment= ion the space removal. Thanks, Ludo=E2=80=99.