From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] packages: Remove dead code.
Date: Tue, 19 Aug 2014 23:09:50 +0200 [thread overview]
Message-ID: <87lhqk9of5.fsf@gnu.org> (raw)
In-Reply-To: <87lhqnc7jw.fsf@gmail.com> (Alex Kost's message of "Sun, 17 Aug 2014 22:09:07 +0400")
Alex Kost <alezost@gmail.com> skribis:
> If I understand correctly, ‘_’ is redundant in “gnu/packages.scm” as it
> is already defined in (guix ui).
Indeed, applied.
> Also I fixed a double space in this commit (not sure if it's acceptable
> here).
That’s fine, IMO. If this were a wider change, like removing all
trailing whitespaces in one file or another, that would have to be a
different commit for clarity.
> Also if this patch is OK, should a commit message be improved somehow?
The commit message is good. Perhaps you wouldn’t even need to mention
the space removal.
Thanks,
Ludo’.
prev parent reply other threads:[~2014-08-20 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-17 18:09 [PATCH] packages: Remove dead code Alex Kost
2014-08-19 21:09 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhqk9of5.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.