From: mhw@netris.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] utils: Allow wrap-program to be called multiple times.
Date: Sun, 14 Sep 2014 00:05:29 -0400 [thread overview]
Message-ID: <87lhpmyhh2.fsf@netris.org> (raw)
In-Reply-To: <87sijw122v.fsf@gmail.com> (Eric Bavier's message of "Sat, 13 Sep 2014 01:12:08 -0500")
Eric Bavier <ericbavier@gmail.com> writes:
> diff --git a/guix/build/utils.scm b/guix/build/utils.scm
> index d169053..7257b30 100644
> --- a/guix/build/utils.scm
> +++ b/guix/build/utils.scm
> @@ -687,8 +687,7 @@ known as `nuke-refs' in Nixpkgs."
> result))))))
>
> (define* (wrap-program prog #:rest vars)
[... docstring changes ...]
> + (define (wrapper-file-name number)
> + (format #f "~a/.~a-wrap-~2'0d" (dirname prog) (basename prog) number))
When compiling core-updates, I now see the following warning:
--8<---------------cut here---------------start------------->8---
LC_ALL=C \
./pre-inst-env \
/home/mhw/.guix-profile/bin/guild compile -L "." -L "." \
-Wformat -Wunbound-variable -Warity-mismatch \
--target="i686-pc-linux-gnu" \
-o "guix/build/utils.go" "guix/build/utils.scm"
guix/build/utils.scm:718:4: warning: "~a/.~a-wrap-~2'0d": unsupported format option ~2, use (ice-9 format) instead
wrote `guix/build/utils.go'
--8<---------------cut here---------------end--------------->8---
Have you verified that this call to 'format' works as expected in all
the relevant cases?
Thanks,
Mark
next prev parent reply other threads:[~2014-09-14 4:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 22:56 [PATCH] utils: Allow wrap-program to be called multiple times Eric Bavier
2014-09-10 13:40 ` Ludovic Courtès
2014-09-10 19:16 ` Eric Bavier
2014-09-11 13:10 ` Ludovic Courtès
2014-09-13 6:12 ` Eric Bavier
2014-09-13 12:20 ` Ludovic Courtès
2014-09-14 4:05 ` mhw [this message]
2014-09-14 14:27 ` Ludovic Courtès
2014-09-14 15:16 ` Eric Bavier
2014-09-14 15:58 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhpmyhh2.fsf@netris.org \
--to=mhw@netris.org \
--cc=ericbavier@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.