From: Alex Kost <alezost@gmail.com>
To: Ian Denhardt <ian@zenhack.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/1] gnu: add feh
Date: Sun, 05 Oct 2014 12:18:42 +0400 [thread overview]
Message-ID: <87lhovj5el.fsf@gmail.com> (raw)
In-Reply-To: <4c48d1bdc7977e98f1248ad5e9255b0430beb759.1412489062.git.ian@zenhack.net> (Ian Denhardt's message of "Sat, 4 Oct 2014 23:32:14 -0400")
Hello,
I confirm that the package is built successfully (at least for me).
Several comments:
There should be a header (a comment with author, license, …) in the
beginning of “feh.scm” – see any file in the "gnu/packages" dir.
Ian Denhardt (2014-10-05 07:32 +0400) wrote:
[...]
> +(define-public feh
> + (package
> + (name "feh")
> + (version "2.12")
> + (home-page "https://feh.finalrewind.org/")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append home-page
> + name "-" version ".tar.bz2"))
Double space after ‘version’.
> + (sha256 (base32
> + "0ckhidmsms2l5jycp0qf71jzmb3bpbhjq3bcgfpvfvszah7pmq30"))))
This is rather unusual indentation. As for me, I prefer:
(sha256
(base32
"0ckhidmsms2l5jycp0qf71jzmb3bpbhjq3bcgfpvfvszah7pmq30"))
People also use:
(sha256 (base32
"0ckhidmsms2l5jycp0qf71jzmb3bpbhjq3bcgfpvfvszah7pmq30"))
> + (build-system gnu-build-system)
> + (arguments
Remove trailing space here please.
> + '(#:phases (alist-delete 'configure %standard-phases)
> + #:tests? #f
> + #:make-flags
> + (list "CC=gcc" (string-append "PREFIX=" (assoc-ref %outputs "out")))))
> + (inputs `(("imlib2" ,imlib2)
> + ("curl" ,curl)
> + ("libpng" ,libpng)
> + ("libxt" ,libxt)
> + ("libx11" ,libx11)
> + ("libxinerama" ,libxinerama)))
> + (synopsis "Fast and light imlib2-based image viewer")
> + (description (string-append
> + "feh is an X11 image viewer aimed mostly at console users. "
> + "Unlike most other viewers, it does not have a fancy GUI, "
> + "but simply displays images. It is controlled via "
> + "commandline arguments and configurable key/mouse actions."))
This will make a long one-line description, which is not preferable.
Descriptions should be multi-lined and they usually look like this:
--8<---------------cut here---------------start------------->8---
(description
"feh is an X11 image viewer aimed mostly at console users.
Unlike most other viewers, it does not have a fancy GUI, but simply
displays images. It is controlled via commandline arguments and
configurable key/mouse actions.")
--8<---------------cut here---------------end--------------->8---
Also I think it is worth mentioning (in the description) that feh can
also be used as a wallpaper setter.
--
Thanks,
Alex
next prev parent reply other threads:[~2014-10-05 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-05 6:04 [PATCH 0/1] gnu: add feh Ian Denhardt
2014-10-05 3:32 ` [PATCH 1/1] " Ian Denhardt
2014-10-05 8:18 ` Alex Kost [this message]
2014-10-05 12:31 ` Ludovic Courtès
2014-10-05 16:06 ` [PATCH 0/1] (updated) " Ian Denhardt
2014-10-05 3:32 ` [PATCH 1/1] " Ian Denhardt
2014-10-06 7:59 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhovj5el.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ian@zenhack.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.