From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: Bugs in parsing build options
Date: Fri, 27 Feb 2015 00:08:07 +0300
Message-ID: <87lhjkmle0.fsf@gmail.com>
References: <CAJ41eeyECrUPfEhS+9puU3y0iczEeCs8JgKB8RnTRofVNOW_4w@mail.gmail.com>
	<CAJ41eewKNWaw8ufRS3N6CdrK7j=isv7LKhSh3J0oUVSv8DxBUA@mail.gmail.com>
	<87fvcszuno.fsf@gnu.org> <87bnkopawy.fsf_-_@gmail.com>
	<87oaoj7wu0.fsf@gnu.org> <871tlegiot.fsf@gmail.com>
	<87oaoh1tiw.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37476)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1YR5fN-0003Sl-AI
	for guix-devel@gnu.org; Thu, 26 Feb 2015 16:08:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1YR5fI-0001wp-An
	for guix-devel@gnu.org; Thu, 26 Feb 2015 16:08:17 -0500
In-Reply-To: <87oaoh1tiw.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Thu, 26 Feb 2015 00:05:43 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s (2015-02-26 02:05 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> Suppose a user specifies "--no-substitutes" in his GUIX_BUILD_OPTIONS
>> and then he calls "guix system reconfigure".  What would happen?
>> Substitutes _will be used_ anyway, because:
>> =E2=80=98(parse-options-from args)=E2=80=99 will contain =E2=80=98(subst=
itutes? . #t)=E2=80=99 among
>> other things and it will shadow the false value for substitutes returned
>> by =E2=80=98(parse-options-from (environment-build-options))=E2=80=99.
>>
>> Now (after your patch) the same will happen with "--no-grub":
>> =E2=80=9Cexport GUIX_BUILD_OPTIONS=3D--no-grub=E2=80=9D will not be hono=
red unless a user
>> explicitly specifies "--no-grub" option one more time in a "guix system"
>> command.
>
> Oh, that=E2=80=99s right.  AFAICS, commit cf6ce3e fixes it.

Yes, thank you, now I'm satisfied :-)

> It was a good opportunity to factorize all that and to add tests.
>
> Thanks!
>
> Ludo=E2=80=99.

Thank YOU for being so productive!

--=20
Alex