From: Mark H Weaver <mhw@netris.org>
To: David Thompson <dthompson2@worcester.edu>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Update ncmpcpp to v0.6.2
Date: Fri, 27 Feb 2015 11:13:12 -0500 [thread overview]
Message-ID: <87lhjj72p3.fsf@netris.org> (raw)
In-Reply-To: <87vbin8qo2.fsf@fsf.org> (David Thompson's message of "Fri, 27 Feb 2015 07:50:05 -0500")
David Thompson <dthompson2@worcester.edu> writes:
> Paul van der Walt <paul@denknerd.org> writes:
[...]
>> + (arguments
>> + '(#:configure-flags
>> + '("BOOST_LIB_SUFFIX=")
>> + #:phases
>> + (alist-cons-after
>> + 'unpack 'autogen
>> + (lambda _
>> + (substitute* "autogen.sh"
>> + (("/bin/sh") (which "bash")))
>
> Is "autogen.sh" not executable? If it starts with a shebang, Guix
> should patch the file appropriately.
The problem here is that this 'autogen' phase is run before the
'patch-source-shebangs' phase, at my suggestion. It has to be that way,
because 'patch-source-shebangs' (and 'patch-usr-bin-file') will need to
be run on the files created by 'autogen.sh'.
>> + (setenv "NOCONFIGURE" "true")
>> + (zero? (system* "bash" "autogen.sh")))
>
> If its executable, you can say:
>
> (zero? (system* "./autogen.sh"))
Yes, after the 'substitute*' above, this should presumably work. My
guess is that Paul added the "bash" here before he realized that he
also needed the 'substitute*'.
Mark
next prev parent reply other threads:[~2015-02-27 16:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 10:13 [PATCH] Update ncmpcpp to v0.6.2 Paul van der Walt
2015-02-27 12:50 ` David Thompson
2015-02-27 16:13 ` Mark H Weaver [this message]
2015-02-27 16:18 ` David Thompson
2015-02-27 16:27 ` Paul van der Walt
2015-02-27 17:13 ` David Thompson
2015-02-27 18:21 ` Mark H Weaver
2015-02-27 18:53 ` Paul van der Walt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhjj72p3.fsf@netris.org \
--to=mhw@netris.org \
--cc=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.