all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] build: ruby: Install executables in /bin.
@ 2015-02-27 19:04 David Thompson
  2015-02-28 19:44 ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: David Thompson @ 2015-02-27 19:04 UTC (permalink / raw
  To: guix-devel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-build-ruby-Install-executables-in-bin.patch --]
[-- Type: text/x-diff, Size: 1475 bytes --]

From af6a7e03fc6debea314b88d616d035acc1b6ed50 Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson2@worcester.edu>
Date: Fri, 27 Feb 2015 12:03:20 -0500
Subject: [PATCH] build: ruby: Install executables in /bin.

* guix/build/ruby-build-system.scm (install): Add '--bindir' flag to gem
  command.
---
 guix/build/ruby-build-system.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/guix/build/ruby-build-system.scm b/guix/build/ruby-build-system.scm
index 933788c..4221295 100644
--- a/guix/build/ruby-build-system.scm
+++ b/guix/build/ruby-build-system.scm
@@ -61,13 +61,14 @@ directory."
           (match:substring (string-match "ruby-(.*)$"
                                          (assoc-ref inputs "ruby"))
                            1))
-         (gem-home (string-append (assoc-ref outputs "out")
-                                  "/lib/ruby/gems/"
-                                  ruby-version)))
+         (out (assoc-ref outputs "out"))
+         (gem-home (string-append out "/lib/ruby/gems/" ruby-version)))
     (setenv "GEM_HOME" gem-home)
     (mkdir-p gem-home)
     (zero? (system* "gem" "install" "--local"
-                    (first-matching-file "\\.gem$")))))
+                    (first-matching-file "\\.gem$")
+                    ;; Executables should go into /bin, not /lib/ruby/gems.
+                    "--bindir" (string-append out "/bin")))))
 
 (define %standard-phases
   (alist-cons-after
-- 
2.1.4


[-- Attachment #2: Type: text/plain, Size: 136 bytes --]


-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] build: ruby: Install executables in /bin.
  2015-02-27 19:04 [PATCH] build: ruby: Install executables in /bin David Thompson
@ 2015-02-28 19:44 ` Ludovic Courtès
  2015-02-28 20:27   ` David Thompson
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2015-02-28 19:44 UTC (permalink / raw
  To: David Thompson; +Cc: guix-devel

David Thompson <dthompson2@worcester.edu> skribis:

> From af6a7e03fc6debea314b88d616d035acc1b6ed50 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Fri, 27 Feb 2015 12:03:20 -0500
> Subject: [PATCH] build: ruby: Install executables in /bin.
>
> * guix/build/ruby-build-system.scm (install): Add '--bindir' flag to gem
>   command.

Sounds good.

Do you know what the rationale is for bindir to default to
lib/ruby/gems/X.Y?  Parallel-installability?

That makes the search path specification for $PATH useless, right?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] build: ruby: Install executables in /bin.
  2015-02-28 19:44 ` Ludovic Courtès
@ 2015-02-28 20:27   ` David Thompson
  0 siblings, 0 replies; 3+ messages in thread
From: David Thompson @ 2015-02-28 20:27 UTC (permalink / raw
  To: Ludovic Courtès; +Cc: guix-devel

Ludovic Courtès <ludo@gnu.org> writes:

> David Thompson <dthompson2@worcester.edu> skribis:
>
>> From af6a7e03fc6debea314b88d616d035acc1b6ed50 Mon Sep 17 00:00:00 2001
>> From: David Thompson <dthompson2@worcester.edu>
>> Date: Fri, 27 Feb 2015 12:03:20 -0500
>> Subject: [PATCH] build: ruby: Install executables in /bin.
>>
>> * guix/build/ruby-build-system.scm (install): Add '--bindir' flag to gem
>>   command.
>
> Sounds good.
>
> Do you know what the rationale is for bindir to default to
> lib/ruby/gems/X.Y?  Parallel-installability?

I don't know exactly, but it seems like parallel-installability.  Each
gem is installed to a directory that corresponds to its name + version,
so it would make sense.  I also read somewhere that OS X also configures
'gem' to use /usr/local/bin (I think) as the bindir.

> That makes the search path specification for $PATH useless, right?

Yup.  :)

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-28 20:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-27 19:04 [PATCH] build: ruby: Install executables in /bin David Thompson
2015-02-28 19:44 ` Ludovic Courtès
2015-02-28 20:27   ` David Thompson

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.