Bug in configure.ac - Wrong guile version

Bug in configure.ac - Wrong guile version

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

configure.ac contains the line:

PKG_CHECK_MODULES([GUILE], [guile-2.0 >= 2.0.5])

But guix does not seem to be buildable using guile-2.0.5

J'


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: Bug in configure.ac - Wrong guile version

[Ludovic Courtès]

John Darrington <john@darrington.wattle.id.au> skribis:

> But guix does not seem to be buildable using guile-2.0.5

What makes you say so?  Could you post any errors that you have?

TIA,
Ludo’.

Re: Bug in configure.ac - Wrong guile version

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 2535 bytes --]

On Fri, May 01, 2015 at 12:20:41AM +0200, Ludovic Courtès wrote:
     John Darrington <john@darrington.wattle.id.au> skribis:
     
     > But guix does not seem to be buildable using guile-2.0.5
     
     What makes you say so?  Could you post any errors that you have?

  GUILEC guix/gnu-maintenance.go
Backtrace:
In system/base/compile.scm:
 200: 19 [read-and-compile #<input: guix/gnu-maintenance.scm 5> #:from ...]
 212: 18 [lp () #f #<module (#{ g38}#) 938120>]
 178: 17 [lp (#<procedure compile-tree-il (x e opts)>) (define-module # # ...) ...]
In ice-9/boot-9.scm:
2111: 16 [save-module-excursion #<procedure c851e0 at language/scheme/compile-tree-il.scm:29:3 ()>]
In language/scheme/compile-tree-il.scm:
  31: 15 [#<procedure c851e0 at language/scheme/compile-tree-il.scm:29:3 ()>]
In ice-9/psyntax.scm:
1101: 14 [expand-top-sequence ((define-module # # # ...)) () ((top)) ...]
 986: 13 [scan ((define-module (guix gnu-maintenance) #:use-module ...)) () ...]
 270: 12 [scan ((#(syntax-object let # ...) (#) (# #) ...)) () ...]
In ice-9/eval.scm:
 392: 11 [eval # ()]
In ice-9/boot-9.scm:
2667: 10 [define-module* (guix gnu-maintenance) #:filename ...]
2642: 9 [resolve-imports (((web uri)) ((web client)) ((web response)) ...)]
2580: 8 [resolve-interface (guix http-client) #:select ...]
2505: 7 [#<procedure 888e60 at ice-9/boot-9.scm:2493:4 (name #:optional autoload version #:key ensure)> # ...]
2772: 6 [try-module-autoload (guix http-client) #f]
2111: 5 [save-module-excursion #<procedure dde8a0 at ice-9/boot-9.scm:2773:17 ()>]
2783: 4 [#<procedure dde8a0 at ice-9/boot-9.scm:2773:17 ()>]
In unknown file:
   ?: 3 [primitive-load-path "guix/http-client" #f]
In ice-9/eval.scm:
 407: 2 [eval # ()]
In unknown file:
   ?: 1 [scm-error misc-error #f ...]
In ice-9/boot-9.scm:
 106: 0 [#<procedure 9c7b40 at ice-9/boot-9.scm:97:6 (thrown-k . args)> misc-error ...]

ice-9/boot-9.scm:106:20: In procedure #<procedure 9c7b40 at ice-9/boot-9.scm:97:6 (thrown-k . args)>:
ice-9/boot-9.scm:106:20: No variable named make-delimited-input-port in #<directory (web response) dc8240>
make[2]: *** [guix/gnu-maintenance.go] Error 1
make[2]: Leaving directory `/scratch/john/guix-guix'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/scratch/john/guix-guix'
make: *** [all] Error 2

J'


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: Bug in configure.ac - Wrong guile version

[Ricardo Wurmus]

John Darrington writes:

> On Fri, May 01, 2015 at 12:20:41AM +0200, Ludovic Courtès wrote:
>      John Darrington <john@darrington.wattle.id.au> skribis:
>      
>      > But guix does not seem to be buildable using guile-2.0.5
>      
>      What makes you say so?  Could you post any errors that you have?
>

[...]

> ice-9/boot-9.scm:106:20: In procedure #<procedure 9c7b40 at ice-9/boot-9.scm:97:6 (thrown-k . args)>:
> ice-9/boot-9.scm:106:20: No variable named make-delimited-input-port in #<directory (web response) dc8240>

In ./guix/http-client.scm I see a definition of
"make-delimited-input-port" and it is loaded for any Guile version until
2.0.9:

 (unless (guile-version>? "2.0.9")
   ;; Guile <= 2.0.9 had a bug whereby 'response-body-port' would read more
   ;; than what 'content-length' says.  See Guile commit 802a25b.
   (module-set! (resolve-module '(web response))
                'make-delimited-input-port make-delimited-input-port))

What version of Guix are you using?

~~ Ricardo

Re: Bug in configure.ac - Wrong guile version

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

On Fri, May 01, 2015 at 07:41:29PM +0200, Ricardo Wurmus wrote:
     
     John Darrington writes:
     
     > On Fri, May 01, 2015 at 12:20:41AM +0200, Ludovic Courtès wrote:
     >      John Darrington <john@darrington.wattle.id.au> skribis:
     >      
     >      > But guix does not seem to be buildable using guile-2.0.5
     >      
     >      What makes you say so?  Could you post any errors that you have?
     >
     
     [...]
     
     > ice-9/boot-9.scm:106:20: In procedure #<procedure 9c7b40 at ice-9/boot-9.scm:97:6 (thrown-k . args)>:
     > ice-9/boot-9.scm:106:20: No variable named make-delimited-input-port in #<directory (web response) dc8240>
     
     In ./guix/http-client.scm I see a definition of
     "make-delimited-input-port" and it is loaded for any Guile version until
     2.0.9:
     
      (unless (guile-version>? "2.0.9")
        ;; Guile <= 2.0.9 had a bug whereby 'response-body-port' would read more
        ;; than what 'content-length' says.  See Guile commit 802a25b.
        (module-set! (resolve-module '(web response))
                     'make-delimited-input-port make-delimited-input-port))
     
     What version of Guix are you using?
     
See my post above.


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: Bug in configure.ac - Wrong guile version

[Ricardo Wurmus]

John Darrington writes:

> On Fri, May 01, 2015 at 07:41:29PM +0200, Ricardo Wurmus wrote:
>      
>      John Darrington writes:
>      
>      > On Fri, May 01, 2015 at 12:20:41AM +0200, Ludovic Courtès wrote:
>      >      John Darrington <john@darrington.wattle.id.au> skribis:
>      >      
>      >      > But guix does not seem to be buildable using guile-2.0.5
>      
>      What version of Guix are you using?
>      
> See my post above.

The post above only mentions the version of Guile, not of Guix.  Are you
trying to build Guix from master?

~~ Ricardo

Re: Bug in configure.ac - Wrong guile version

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

On Fri, May 01, 2015 at 10:25:32PM +0200, Ricardo Wurmus wrote:
     
     John Darrington writes:
     
     > On Fri, May 01, 2015 at 07:41:29PM +0200, Ricardo Wurmus wrote:
     >      
     >      John Darrington writes:
     >      
     >      > On Fri, May 01, 2015 at 12:20:41AM +0200, Ludovic Court??s wrote:
     >      >      John Darrington <john@darrington.wattle.id.au> skribis:
     >      >      
     >      >      > But guix does not seem to be buildable using guile-2.0.5
     >      
     >      What version of Guix are you using?
     >      
     > See my post above.
     
     The post above only mentions the version of Guile, not of Guix.  Are you
     trying to build Guix from master?
     
Oh sorry.  I misread what you wrote.  Yes I'm building from Guix master.

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: Bug in configure.ac - Wrong guile version

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

John Darrington <john@darrington.wattle.id.au> skribis:

>    ?: 3 [primitive-load-path "guix/http-client" #f]
> In ice-9/eval.scm:
>  407: 2 [eval # ()]
> In unknown file:
>    ?: 1 [scm-error misc-error #f ...]
> In ice-9/boot-9.scm:
>  106: 0 [#<procedure 9c7b40 at ice-9/boot-9.scm:97:6 (thrown-k . args)> misc-error ...]
>
> ice-9/boot-9.scm:106:20: In procedure #<procedure 9c7b40 at ice-9/boot-9.scm:97:6 (thrown-k . args)>:
> ice-9/boot-9.scm:106:20: No variable named make-delimited-input-port in #<directory (web response) dc8240>

The problem is an incomplete compatibility later with Guile 2.0.5.

You should be able to get compilation going with the patch below, but
getting the HTTP client to work with 2.0.5 will require more work.

At this point, we may have to bundle our own (web ...) modules rather
than try to monkey-patch things.  Needs more thought...

Thanks,
Ludo’.


[-- Attachment #2: Type: text/x-patch, Size: 1004 bytes --]

--- a/guix/http-client.scm
+++ b/guix/http-client.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2012, 2013, 2014 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2012, 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2012, 2015 Free Software Foundation, Inc.
 ;;;
@@ -173,8 +173,8 @@ closes PORT, unless KEEP-ALIVE? is true."
  (unless (guile-version>? "2.0.9")
    ;; Guile <= 2.0.9 had a bug whereby 'response-body-port' would read more
    ;; than what 'content-length' says.  See Guile commit 802a25b.
-   (module-set! (resolve-module '(web response))
-                'make-delimited-input-port make-delimited-input-port))
+   (module-define! (resolve-module '(web response))
+                   'make-delimited-input-port make-delimited-input-port))
 
  (define (read-response-body* r)
    "Reads the response body from @var{r}, as a bytevector.  Returns

Bumping the Guile version requirement

[Ludovic Courtès]

ludo@gnu.org (Ludovic Courtès) skribis:

> You should be able to get compilation going with the patch below, but
> getting the HTTP client to work with 2.0.5 will require more work.

I think for 0.8.2 I will actually bump the requirement to Guile 2.0.7 or
2.0.9 (the latter is what Debian 8 has.)  People on older systems will
still be able to install Guix using the binary tarball.

What do people think?

Ludo’.

Re: Bumping the Guile version requirement

[David Thompson]

Ludovic Courtès <ludo@gnu.org> writes:

> ludo@gnu.org (Ludovic Courtès) skribis:
>
>> You should be able to get compilation going with the patch below, but
>> getting the HTTP client to work with 2.0.5 will require more work.
>
> I think for 0.8.2 I will actually bump the requirement to Guile 2.0.7 or
> 2.0.9 (the latter is what Debian 8 has.)  People on older systems will
> still be able to install Guix using the binary tarball.
>
> What do people think?

I think it's a great idea.  Less monkey patches for us.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: Bumping the Guile version requirement

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Thu, May 07, 2015 at 06:06:16PM +0200, Ludovic Courtès wrote:
>ludo@gnu.org (Ludovic Courtès) skribis:
>
>> You should be able to get compilation going with the patch below, but
>> getting the HTTP client to work with 2.0.5 will require more work.
>
>I think for 0.8.2 I will actually bump the requirement to Guile 2.0.7 or
>2.0.9 (the latter is what Debian 8 has.)  People on older systems will
>still be able to install Guix using the binary tarball.
>
>What do people think?

No objections with my openSUSE or Gentoo packagers hat.

S_W

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: Bumping the Guile version requirement

[Mark H Weaver]

ludo@gnu.org (Ludovic Courtès) writes:

> I think for 0.8.2 I will actually bump the requirement to Guile 2.0.7 or
> 2.0.9 (the latter is what Debian 8 has.)  People on older systems will
> still be able to install Guix using the binary tarball.
>
> What do people think?

Sounds good to me.  The binary tarball should probably be the preferred
method for installing on top of other distros anyway.

     Mark

Re: Bumping the Guile version requirement

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

On Sat, May 09, 2015 at 01:21:27AM -0400, Mark H Weaver wrote:
>ludo@gnu.org (Ludovic Courtès) writes:
>
>> I think for 0.8.2 I will actually bump the requirement to Guile 2.0.7 or
>> 2.0.9 (the latter is what Debian 8 has.)  People on older systems will
>> still be able to install Guix using the binary tarball.
>>
>> What do people think?
>
>Sounds good to me.  The binary tarball should probably be the preferred
>method for installing on top of other distros anyway.

Why?

From packagers POV it is much less welcome to provide binary package instead
building package (which can be reviewed and reproduced) from source code
(which can be reviewed as well).

S_W

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: Bumping the Guile version requirement

[Ludovic Courtès]

Tomáš Čech <sleep_walker@gnu.org> skribis:

> On Sat, May 09, 2015 at 01:21:27AM -0400, Mark H Weaver wrote:
>>ludo@gnu.org (Ludovic Courtès) writes:
>>
>>> I think for 0.8.2 I will actually bump the requirement to Guile 2.0.7 or
>>> 2.0.9 (the latter is what Debian 8 has.)  People on older systems will
>>> still be able to install Guix using the binary tarball.
>>>
>>> What do people think?
>>
>>Sounds good to me.  The binary tarball should probably be the preferred
>>method for installing on top of other distros anyway.
>
> Why?

I think Mark was referring to users of distros that do not have a Guix
package.  Of course when a distro has a Guix package, that’s the
preferred and most convenient way.

Ludo’.

Re: Bumping the Guile version requirement

[Ludovic Courtès]

Thanks everyone for your feedback.  I went ahead and bumped the
requirement to 2.0.7.

Please report any issues with ‘guix download’ or with substitutes, or
test suite failures!

Ludo’.