From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: make-bootstrap: Produce the correct
	%glibc-bootstrap-tarball for Hurd systems.
Date: Tue, 07 Jul 2015 16:58:46 +0200
Message-ID: <87lhesdnfd.fsf@gnu.org>
References: <CAFtzXzPhSU4YjmVAN4TqTK_wvPTbKmuGdoO1Aj97bpmLSvsbjg@mail.gmail.com>
	<87egktynp0.fsf@gnu.org>
	<CAFtzXzOv693nZzpFmBqVp2GN8FxTn03q=o8nZdfz4qNGE9AFZg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36977)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZCUKh-0007NH-7A
	for Guix-devel@gnu.org; Tue, 07 Jul 2015 10:58:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZCUKf-0008EM-Of
	for Guix-devel@gnu.org; Tue, 07 Jul 2015 10:58:51 -0400
In-Reply-To: <CAFtzXzOv693nZzpFmBqVp2GN8FxTn03q=o8nZdfz4qNGE9AFZg@mail.gmail.com>
	(Manolis Ragkousis's message of "Thu, 2 Jul 2015 00:50:47 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>

Manolis Ragkousis <manolis837@gmail.com> skribis:

> * gnu/packages/make-bootstrap.scm (%glibc-bootstrap-tarball): Make it a p=
rocedure.
>   (%glibc-stripped): Make it a procedure and move the kernel specific par=
t from
>   here to ...
> * guix/build/make-bootstrap.scm (make-stripped-libc): ... here. New file.
>
> Co-authored-by: Ludovic Court=C3=A8s <ludo@gnu.org>

[...]

> +(define-module (guix build make-bootstrap)
> +  #:use-module (srfi srfi-1)
> +  #:use-module (srfi srfi-11)
> +  #:use-module (srfi srfi-19)
> +  #:use-module (srfi srfi-26)
> +  #:use-module (guix build utils)
> +  #:export (make-stripped-libc))

Please add a comment like:

;;; Commentary:
;;;
;;; This module provides facilities to build the bootstrap binaries.
;;;
;;; Code:

> +(define (make-stripped-libc output libc kernel-headers)
> +  "Copy to OUTPUT the subset of LIBC and KERNEL-HEADERS that is needed
> +  when producing a bootstrap libc."
   ^
extra space

Make sure to add this new file to Makefile.am.

Otherwise LGTM.

Could you make sure that =E2=80=98guix build glibc-stripped-tarball=E2=80=
=99 still works
as expected?  (I assume you already tested with --target=3Di586-pc-gnu.)

If that passes, OK to commit to =E2=80=98master=E2=80=99 with the above cha=
nges.

Thanks!

Ludo=E2=80=99.