From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] Add Emacs PDF tools
Date: Fri, 10 Jul 2015 09:16:11 +0200
Message-ID: <87lheoiitg.fsf@elephly.net>
References: <878uaujxiu.fsf@elephly.net> <87twthflpk.fsf@gmail.com>
	<87615t4eph.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59352)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZDSXn-000549-E4
	for guix-devel@gnu.org; Fri, 10 Jul 2015 03:16:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZDSXk-0004Ig-82
	for guix-devel@gnu.org; Fri, 10 Jul 2015 03:16:23 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:25622)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZDSXk-0004IJ-0F
	for guix-devel@gnu.org; Fri, 10 Jul 2015 03:16:20 -0400
In-reply-to: <87615t4eph.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>


Alex Kost <alezost@gmail.com> writes:

> Since now we have 'emacs-byte-compile-directory', the elisp files may
> also be compiled.  I modified your patch to:
>
> - move patching the variables (including 'pdf-tools-handle-upgrades')
>   into a separate phase;
> - compile the elisp files;
> - generate autoloads.

Thank you!

> So if there is no way to "build" elisp files using the top-level
> Makefile, and then to "build" epdfinfo using "autogen.sh" and friends
> from the "server" subdir, I think the attached patch will do.  WDYT?

The top-level Makefile uses ‘cask’ to bytecompile and test the package
tarball.  The ‘$(PACKAGE_NAME).tar’ target contains the only line that
copies the elisp files to the target directory, but it’s amidst lines
required for building the tarball.  I don’t think there’s a good way to
reuse the top-level Makefile.

~~ Ricardo